You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jena.apache.org by "afs (via GitHub)" <gi...@apache.org> on 2023/07/03 12:59:51 UTC
[GitHub] [jena] afs opened a new issue, #1948: Depreate API operations that may be affected by Jena5.
afs opened a new issue, #1948:
URL: https://github.com/apache/jena/issues/1948
### Version
4.8.0
### Feature
This is preparation for Jena5 changes by deprecating API calls to features that are "at risk". (Direct use of LiteralLabels, the "well formed" or "isXML" special case for literals).
Discussion on dev@ please.
### Are you interested in contributing a solution yourself?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org
[GitHub] [jena] cdekok commented on issue #1948: Deprecate API operations that may be affected by Jena5.
Posted by "cdekok (via GitHub)" <gi...@apache.org>.
cdekok commented on issue #1948:
URL: https://github.com/apache/jena/issues/1948#issuecomment-1658852666
I have a literlabe from the literlalfactory, but with this change i can't convert it to a node anymore which is a bit weird.
I can do a workaround with the NodeFactory but IMO then the LiteralLabelFactory has little use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org
[GitHub] [jena] afs closed issue #1948: Deprecate API operations that may be affected by Jena5.
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs closed issue #1948: Deprecate API operations that may be affected by Jena5.
URL: https://github.com/apache/jena/issues/1948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org
[GitHub] [jena] afs commented on issue #1948: Deprecate API operations that may be affected by Jena5.
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on issue #1948:
URL: https://github.com/apache/jena/issues/1948#issuecomment-1661066170
Interesting.
I have been looking at the Node area to see what can be simplified. Some generality is not used anywhere and has not come up on the mailing list of StackOverflow. I doubt it'll make a significant impact to be simpler, maybe a little extra performance because of less indirections for some processing intense code, and maybe a bit of space saving at scale.
Node_Literal and LiteralLabel, especially in the light of the new term-centric graphs, are a area. I really do wonder what the significant of LiteralLabel is and I was wondering if LiteralLabel could be pulled up into Node_Literal. There is an impact on the `RDFDataype.isEqual` operation -- which should really be called "sameValueAs" because "equal" has multiple meanings (java .equals, sameTermAs sameValueAs).
What are you using LiteralLabel for? Is Node_Literal not teh right concept for the usage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org
[GitHub] [jena] cdekok commented on issue #1948: Deprecate API operations that may be affected by Jena5.
Posted by "cdekok (via GitHub)" <gi...@apache.org>.
cdekok commented on issue #1948:
URL: https://github.com/apache/jena/issues/1948#issuecomment-1667721481
Currently I have some code that is writing code to RDF, so for example.
```kotlin
val value = LiteralLabelFactory.createTypedLiteral(true)
val node = NodeFactory.createLiteral(label)
```
Now this can be converted ofcourse to just using the NodeFactory e.g
```
NodeFactory.createLiteralByValue(true, XSDDatatype.XSDboolean)
```
It would be nice if the doc block would point to a use method when marking methods as deprecated.
Currently the method `NodeFactory.createLiteral` is marked as deprecated, but the `LiteralLabelFactory` is not only it's not possible to convert a LiteralLabel to a Node anymore since Node_Literal constructor is private.
The intention of the deprecated is a bit unclear for me, what incorrect states should it prevent, and why can I create LiteralLabels but not turn them into nodes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org
[GitHub] [jena] afs commented on issue #1948: Deprecate API operations that may be affected by Jena5.
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on issue #1948:
URL: https://github.com/apache/jena/issues/1948#issuecomment-1668131401
A lot of this is legacy (in relation to RDF 1.0), and reasons can be lost in the lost in the mists of time.
I don't see the point of LiteralLabel from the viewpoint of today's Jena. As an interface, it has one implementation. It's in teh `impl` package but has leaked. Maybe the possibility was for complex values was there, but that does not make sense in a SPARQL world.
`NodeFactory.createLiteralByValue` is the operation to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org
[GitHub] [jena] cdekok commented on issue #1948: Deprecate API operations that may be affected by Jena5.
Posted by "cdekok (via GitHub)" <gi...@apache.org>.
cdekok commented on issue #1948:
URL: https://github.com/apache/jena/issues/1948#issuecomment-1658429038
What is the alternative API to use? it's marked as deprecated but no alternative seems to be provided as Node_Literal has a private constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org
[GitHub] [jena] afs commented on issue #1948: Deprecate API operations that may be affected by Jena5.
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on issue #1948:
URL: https://github.com/apache/jena/issues/1948#issuecomment-1658715243
Which operation are you referring to? What is the caller trying to do?
NodeFactory is the preferred way to create nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org