[jira] [Work logged] (BEAM-5192) Support Elasticsearch 7.x

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-5192?focusedWorklogId=366525&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-366525 ]

ASF GitHub Bot logged work on BEAM-5192:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Jan/20 09:02
            Start Date: 06/Jan/20 09:02
    Worklog Time Spent: 10m 
      Work Description: echauchot commented on issue #10433: [BEAM-5192] Add support for Elasticsearch v7 in ElasticsearchIO
URL: https://github.com/apache/beam/pull/10433#issuecomment-571059552
 
 
   > @echauchot another change needed is removing the type in the request for es 7.0. I made that change to avoid some warnings for my own usage.
   > 
   > https://github.com/apache/beam/blob/233ec7d10afe4b8824829553b91afa7a002ec51e/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java#L718
   > 
   > In the api, the user shouldn't specify the type.
   > 
   > https://www.elastic.co/guide/en/elasticsearch/reference/7.x/breaking-changes-7.0.html#include-type-name-defaults-false
   > 
   > https://www.elastic.co/guide/en/elasticsearch/reference/master/removal-of-types.html
   
   I know but it is just a deprecation for now in ES 7.0, types will be removed later on. 
   For backward compatibility reasons (address indexes created using ES <= 6 we could keep the type. Once the type API is removed (in ES 8.0 I guess), we could address this breaking change during the migration of the IO. WDYT ?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 366525)
    Time Spent: 2.5h  (was: 2h 20m)

> Support Elasticsearch 7.x
> -------------------------
>
>                 Key: BEAM-5192
>                 URL: https://issues.apache.org/jira/browse/BEAM-5192
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-elasticsearch
>            Reporter: Etienne Chauchot
>            Assignee: Etienne Chauchot
>            Priority: Major
>             Fix For: 2.19.0
>
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> ES v7 is not out yet. But Elastic team scheduled a breaking change for ES 7.0: the removal of the type feature. See 
> [https://www.elastic.co/blog/index-type-parent-child-join-now-future-in-elasticsearch]
> This will require a good amont of changes in the IO. 
> This ticket is there to track the future work.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)