You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/02/04 21:18:43 UTC
Re: Review Request 65346: Updated Web UI to show quota guarantee and
limit for roles.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65346/
-----------------------------------------------------------
(Updated Feb. 4, 2018, 9:18 p.m.)
Review request for mesos, Benjamin Mahler, Kapil Arya, Michael Park, and Meng Zhu.
Changes
-------
Used first sheet given by bmahler in his comment as a mockup for the new UI.
Bugs: MESOS-8486
https://issues.apache.org/jira/browse/MESOS-8486
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/webui/master/static/css/mesos.css 3e3a3b13cfc4d63aea73d0a6572b22a2de94541e
src/webui/master/static/index.html 46cb2843c2221ccebb7d811c0045be2c124afec1
src/webui/master/static/js/app.js 8960f9d4421f7b96ba06deb623afafb06013b622
src/webui/master/static/roles.html 1c84ad33a554e078d854e25b4d5ca311c8507f91
Diff: https://reviews.apache.org/r/65346/diff/2/
Changes: https://reviews.apache.org/r/65346/diff/1-2/
Testing (updated)
-------
New UI:
The group columns cannot be ordered as they have sub-columns, this is expected.
Thanks,
Armand Grillet
Re: Review Request 65346: Updated Web UI to show quota guarantee and
limit for roles.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65346/#review198451
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65346']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65346
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65346/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (151 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1245 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (37 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (43 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (83 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2482 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2506 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2483 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2508 ms total)
[----------] Global test environment tear-down
[==========] 915 tests from 90 test cases ran. (484849 ms total)
[ PASSED ] 914 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 211 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65346/logs/mesos-tests-stderr.log):
```
I0301 16:30:48.914669 9844 executor.cpp:176] Received SUBSCRIBED event
I0301 16:30:48.918663 9844 executor.cpp:180] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0301 16:30:48.919664 9844 executor.cpp:176] Received LAUNCH event
I0301 16:30:48.924666 9844 executor.cpp:648] Starting task 923a8c79-580e-40e6-bdd2-ea3cd7646797
I0301 16:30:49.008666 9844 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0301 16:30:49.547646 9844 executor.cpp:661] Forked command at 6720
I0301 16:30:49.585644 10348 exec.cpp:445] Executor asked to shutdown
I0301 16:30:49.586691 9844 executor.cpp:176] Received SHUTDOWN event
I0301 16:30:49.586691 9844 executor.cpp:758] Shutting down
I0301 16:30:49.586691 9844 executor.cpp:868] Sending SIGTERM to process tree at pid 67c2688e741-0000 (default) at scheduler-65ea8e28-9415-4c1d-9486-f9e724645bd4@10.3.1.5:60866
I0301 16:30:49.582643 4024 master.cpp:3239] Deactivating framework f6b9ff81-a5f5-4e81-bc89-f27c2688e741-0000 (default) at scheduler-65ea8e28-9415-4c1d-9486-f9e724645bd4@10.3.1.5:60866
I0301 16:30:49.582643 7356 slave.cpp:922] Agent terminating
I0301 16:30:49.582643 6932 hierarchical.cpp:405] Deactivated framework f6b9ff81-a5f5-4e81-bc89-f27c2688e741-0000
I0301 16:30:49.583644 7356 slave.cpp:3879] Shutting down framework f6b9ff81-a5f5-4e81-bc89-f27c2688e741-0000
I0301 16:30:49.583644 4024 master.cpp:10258] Updating the state of task 923a8c79-580e-40e6-bdd2-ea3cd7646797 of framework f6b9ff81-a5f5-4e81-bc89-f27c2688e741-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0301 16:30:49.583644 7356 slave.cpp:6586] Shutting down executor '923a8c79-580e-40e6-bdd2-ea3cd7646797' of framework f6b9ff81-a5f5-4e81-bc89-f27c2688e741-0000 at executor(1)@10.3.1.5:60887
I0301 16:30:49.588641 5596 containerizer.cpp:2338] Destroying container 737ae9eb-ae05-4f54-b250-b255608c5fdb in RUNNING state
I0301 16:30:49.587708 4024 master.cpp:10357] Removing task 923a8c79-580e-40e6-bdd2-ea3cd7646797 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework f6b9ff81-a5f5-4e81-bc89-f27c2688e741-0000 on agent f6b9ff81-a5f5-4e81-bc89-f27c2688e741-S0 at slave(398)@10.3.1.5:60866 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0301 16:30:49.588641 5596 containerizer.cpp:2952] Transitioning the state of container 737ae9eb-ae05-4f54-b250-b255608c5fdb from RUNNING to DESTROYING
I0301 16:30:49.590642 5596 launcher.cpp:156] Asked to destroy container 737ae9eb-ae05-4f54-b250-b255608c5fdb
I0301 16:30:49.590642 4024 master.cpp:1306] Agent f6b9ff81-a5f5-4e81-bc89-f27c2688e741-S0 at slave(398)@10.3.1.5:60866 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0301 16:30:49.591645 4024 master.cpp:3276] Disconnecting agent f6b9ff81-a5f5-4e81-bc89-f27c2688e741-S0 at slave(398)@10.3.1.5:60866 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0301 16:30:49.591645 1136 hierarchical.cpp:344] Removed framework f6b9ff81-a5f5-4e81-bc89-f27c2688e741-0000
I0301 16:30:49.592641 4024 master.cpp:3295] Deactivating agent f6b9ff81-a5f5-4e81-bc89-f27c2688e741-S0 at slave(398)@10.3.1.5:60866 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0301 16:30:49.592641 4192 hierarchical.cpp:766] Agent f6b9ff81-a5f5-4e81-bc89-f27c2688e741-S0 deactivated
I0301 16:30:49.677039 1136 containerizer.cpp:2791] Container 737ae9eb-ae05-4f54-b250-b255608c5fdb has exited
I0301 16:30:49.709038 7356 master.cpp:1149] Master terminating
I0301 16:30:49.712038 6932 hierarchical.cpp:609] Removed agent f6b9ff81-a5f5-4e81-bc89-f27c2688e741-S0
I0301 16:30:50.414041 2880 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 1, 2018, 7:23 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65346/
> -----------------------------------------------------------
>
> (Updated March 1, 2018, 7:23 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Kapil Arya, Michael Park, Meng Zhu, and Till Toenshoff.
>
>
> Bugs: MESOS-8486
> https://issues.apache.org/jira/browse/MESOS-8486
>
>
> Repository: mesos
>
>
> Description
> -------
>
> There is no limit field yet thus the limit displayed is currently
> the guarantee. We will access this field once it will be exposed.
>
>
> Diffs
> -----
>
> src/webui/master/static/css/mesos.css 3e3a3b13cfc4d63aea73d0a6572b22a2de94541e
> src/webui/master/static/index.html 46cb2843c2221ccebb7d811c0045be2c124afec1
> src/webui/master/static/js/app.js 8960f9d4421f7b96ba06deb623afafb06013b622
> src/webui/master/static/roles.html 1c84ad33a554e078d854e25b4d5ca311c8507f91
>
>
> Diff: https://reviews.apache.org/r/65346/diff/4/
>
>
> Testing
> -------
>
> New UI:
> 
> The group columns cannot be ordered as they have sub-columns, this is expected.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 65346: Updated Web UI to show quota guarantee and
limit for roles.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65346/#review198455
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65503, 65346]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 1, 2018, 3:23 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65346/
> -----------------------------------------------------------
>
> (Updated March 1, 2018, 3:23 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Kapil Arya, Michael Park, Meng Zhu, and Till Toenshoff.
>
>
> Bugs: MESOS-8486
> https://issues.apache.org/jira/browse/MESOS-8486
>
>
> Repository: mesos
>
>
> Description
> -------
>
> There is no limit field yet thus the limit displayed is currently
> the guarantee. We will access this field once it will be exposed.
>
>
> Diffs
> -----
>
> src/webui/master/static/css/mesos.css 3e3a3b13cfc4d63aea73d0a6572b22a2de94541e
> src/webui/master/static/index.html 46cb2843c2221ccebb7d811c0045be2c124afec1
> src/webui/master/static/js/app.js 8960f9d4421f7b96ba06deb623afafb06013b622
> src/webui/master/static/roles.html 1c84ad33a554e078d854e25b4d5ca311c8507f91
>
>
> Diff: https://reviews.apache.org/r/65346/diff/4/
>
>
> Testing
> -------
>
> New UI:
> 
> The group columns cannot be ordered as they have sub-columns, this is expected.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 65346: Updated Web UI to show quota guarantee and
limit for roles.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65346/#review198487
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65346']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65346
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65346/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (131 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1287 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (51 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (47 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (101 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2445 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2475 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2451 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2480 ms total)
[----------] Global test environment tear-down
[==========] 915 tests from 90 test cases ran. (493883 ms total)
[ PASSED ] 914 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 211 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65346/logs/mesos-tests-stderr.log):
```
I0301 23:51:14.249897 8856 slave.cpp:922] Agent terminating
I0301 23:51:14.253895 10112 hierarchical.cpp:405] Deactivated framework f5fd0edc-a903-4f4d-9c8c-4e4a8736e1d4-0000
I0301 23:51:14.253895 8856 slave.cpp:3879] Shutting down framework f5fd0edc-a903-4f4d-9c8c-4e4a8736e1d4-0000
I0301 23:51:14.253895 9660 master.cpp:10258] Updating the state of task 2d18c18a-64ad-4ae3-801c-442ded53e4c1 of framework f5fd0edc-a903-4f4d-9c8c-4e4a8736e1d4-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0301 23:51:14.255899 9660 master.cpp:10357] Removing task 2d18c18a-64ad-4ae3-801c-442ded53e4c1 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework f5fd0edc-a903-4f4d-9c8c-4e4a8736e1d4-0000 on agent f5fd0edc-a903-4f4d-9c8c-4e4a8736e1d4-S0 at slave(398)@10.3.1.5:51925 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0301 23:51:14.253895 88I0301 23:51:13.541932 9992 exec.cpp:162] Version: 1.6.0
I0301 23:51:13.570891 10808 exec.cpp:236] Executor registered on agent f5fd0edc-a903-4f4d-9c8c-4e4a8736e1d4-S0
I0301 23:51:13.574920 5376 executor.cpp:176] Received SUBSCRIBED event
I0301 23:51:13.579936 5376 executor.cpp:180] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0301 23:51:13.579936 5376 executor.cpp:176] Received LAUNCH event
I0301 23:51:13.584933 5376 executor.cpp:648] Starting task 2d18c18a-64ad-4ae3-801c-442ded53e4c1
I0301 23:51:13.665928 5376 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0301 23:51:14.213949 5376 executor.cpp:661] Forked command at 8744
I0301 23:51:14.259930 3636 exec.cpp:445] Executor asked to shutdown
I0301 23:51:14.260900 5376 executor.cpp:176] Received SHUTDOWN event
I0301 23:51:14.260900 5376 executor.cpp:758] Shutting down
I0301 23:51:14.260900 5376 executor.cpp:868] Sending SIGTERM to process tree at pid 856 slave.cpp:6586] Shutting down executor '2d18c18a-64ad-4ae3-801c-442ded53e4c1' of framework f5fd0edc-a903-4f4d-9c8c-4e4a8736e1d4-0000 at executor(1)@10.3.1.5:51946
I0301 23:51:14.258903 8888 hierarchical.cpp:344] Removed framework f5fd0edc-a903-4f4d-9c8c-4e4a8736e1d4-0000
I0301 23:51:14.259930 9416 master.cpp:1306] Agent f5fd0edc-a903-4f4d-9c8c-4e4a8736e1d4-S0 at slave(398)@10.3.1.5:51925 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0301 23:51:14.259930 9416 master.cpp:3276] Disconnecting agent f5fd0edc-a903-4f4d-9c8c-4e4a8736e1d4-S0 at slave(398)@10.3.1.5:51925 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0301 23:51:14.259930 9416 master.cpp:3295] Deactivating agent f5fd0edc-a903-4f4d-9c8c-4e4a8736e1d4-S0 at slave(398)@10.3.1.5:51925 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0301 23:51:14.259930 7948 hierarchical.cpp:766] Agent f5fd0edc-a903-4f4d-9c8c-4e4a8736e1d4-S0 deactivated
I0301 23:51:14.261904 7948 containerizer.cpp:2338] Destroying container 02edc328-4d80-4514-ba89-0809bc17aac8 in RUNNING state
I0301 23:51:14.263900 7948 containerizer.cpp:2952] Transitioning the state of container 02edc328-4d80-4514-ba89-0809bc17aac8 from RUNNING to DESTROYING
I0301 23:51:14.264897 7948 launcher.cpp:156] Asked to destroy container 02edc328-4d80-4514-ba89-0809bc17aac8
I0301 23:51:14.289896 5052 containerizer.cpp:2791] Container 02edc328-4d80-4514-ba89-0809bc17aac8 has exited
I0301 23:51:14.321919 8856 master.cpp:1149] Master terminating
I0301 23:51:14.323902 7512 hierarchical.cpp:609] Removed agent f5fd0edc-a903-4f4d-9c8c-4e4a8736e1d4-S0
I0301 23:51:14.964946 6272 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 1, 2018, 10:50 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65346/
> -----------------------------------------------------------
>
> (Updated March 1, 2018, 10:50 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Kapil Arya, Michael Park, Meng Zhu, and Till Toenshoff.
>
>
> Bugs: MESOS-8486
> https://issues.apache.org/jira/browse/MESOS-8486
>
>
> Repository: mesos
>
>
> Description
> -------
>
> There is no limit field yet thus the limit displayed is currently
> the guarantee. We will access this field once it will be exposed.
>
>
> Diffs
> -----
>
> src/webui/master/static/css/mesos.css 3e3a3b13cfc4d63aea73d0a6572b22a2de94541e
> src/webui/master/static/index.html 46cb2843c2221ccebb7d811c0045be2c124afec1
> src/webui/master/static/js/app.js 8960f9d4421f7b96ba06deb623afafb06013b622
> src/webui/master/static/roles.html 1c84ad33a554e078d854e25b4d5ca311c8507f91
>
>
> Diff: https://reviews.apache.org/r/65346/diff/5/
>
>
> Testing
> -------
>
> New UI:
> 
> The group columns cannot be ordered as they have sub-columns, this is expected.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 65346: Updated Web UI to show quota guarantee and
limit for roles.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65346/#review198491
-----------------------------------------------------------
Ship it!
Looks great, thank you!
- Benjamin Mahler
On March 1, 2018, 10:50 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65346/
> -----------------------------------------------------------
>
> (Updated March 1, 2018, 10:50 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Kapil Arya, Michael Park, Meng Zhu, and Till Toenshoff.
>
>
> Bugs: MESOS-8486
> https://issues.apache.org/jira/browse/MESOS-8486
>
>
> Repository: mesos
>
>
> Description
> -------
>
> There is no limit field yet thus the limit displayed is currently
> the guarantee. We will access this field once it will be exposed.
>
>
> Diffs
> -----
>
> src/webui/master/static/css/mesos.css 3e3a3b13cfc4d63aea73d0a6572b22a2de94541e
> src/webui/master/static/index.html 46cb2843c2221ccebb7d811c0045be2c124afec1
> src/webui/master/static/js/app.js 8960f9d4421f7b96ba06deb623afafb06013b622
> src/webui/master/static/roles.html 1c84ad33a554e078d854e25b4d5ca311c8507f91
>
>
> Diff: https://reviews.apache.org/r/65346/diff/5/
>
>
> Testing
> -------
>
> New UI:
> 
> The group columns cannot be ordered as they have sub-columns, this is expected.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 65346: Updated Web UI to show quota guarantee and
limit for roles.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65346/
-----------------------------------------------------------
(Updated March 1, 2018, 10:50 p.m.)
Review request for mesos, Benjamin Mahler, Kapil Arya, Michael Park, Meng Zhu, and Till Toenshoff.
Changes
-------
Removed `data-valign="middle"` attribute.
Bugs: MESOS-8486
https://issues.apache.org/jira/browse/MESOS-8486
Repository: mesos
Description
-------
There is no limit field yet thus the limit displayed is currently
the guarantee. We will access this field once it will be exposed.
Diffs (updated)
-----
src/webui/master/static/css/mesos.css 3e3a3b13cfc4d63aea73d0a6572b22a2de94541e
src/webui/master/static/index.html 46cb2843c2221ccebb7d811c0045be2c124afec1
src/webui/master/static/js/app.js 8960f9d4421f7b96ba06deb623afafb06013b622
src/webui/master/static/roles.html 1c84ad33a554e078d854e25b4d5ca311c8507f91
Diff: https://reviews.apache.org/r/65346/diff/5/
Changes: https://reviews.apache.org/r/65346/diff/4-5/
Testing
-------
New UI:
The group columns cannot be ordered as they have sub-columns, this is expected.
Thanks,
Armand Grillet
Re: Review Request 65346: Updated Web UI to show quota guarantee and
limit for roles.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65346/
-----------------------------------------------------------
(Updated March 1, 2018, 3:23 p.m.)
Review request for mesos, Benjamin Mahler, Kapil Arya, Michael Park, Meng Zhu, and Till Toenshoff.
Changes
-------
Fixed issues.
Bugs: MESOS-8486
https://issues.apache.org/jira/browse/MESOS-8486
Repository: mesos
Description (updated)
-------
There is no limit field yet thus the limit displayed is currently
the guarantee. We will access this field once it will be exposed.
Diffs (updated)
-----
src/webui/master/static/css/mesos.css 3e3a3b13cfc4d63aea73d0a6572b22a2de94541e
src/webui/master/static/index.html 46cb2843c2221ccebb7d811c0045be2c124afec1
src/webui/master/static/js/app.js 8960f9d4421f7b96ba06deb623afafb06013b622
src/webui/master/static/roles.html 1c84ad33a554e078d854e25b4d5ca311c8507f91
Diff: https://reviews.apache.org/r/65346/diff/3/
Changes: https://reviews.apache.org/r/65346/diff/2-3/
Testing (updated)
-------
New UI:
The group columns cannot be ordered as they have sub-columns, this is expected.
Thanks,
Armand Grillet
Re: Review Request 65346: Updated Web UI to show quota guarantee and
limit for roles.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65346/#review197801
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65503, 65346]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 4, 2018, 1:18 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65346/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2018, 1:18 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Kapil Arya, Michael Park, Meng Zhu, and Till Toenshoff.
>
>
> Bugs: MESOS-8486
> https://issues.apache.org/jira/browse/MESOS-8486
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/webui/master/static/css/mesos.css 3e3a3b13cfc4d63aea73d0a6572b22a2de94541e
> src/webui/master/static/index.html 46cb2843c2221ccebb7d811c0045be2c124afec1
> src/webui/master/static/js/app.js 8960f9d4421f7b96ba06deb623afafb06013b622
> src/webui/master/static/roles.html 1c84ad33a554e078d854e25b4d5ca311c8507f91
>
>
> Diff: https://reviews.apache.org/r/65346/diff/2/
>
>
> Testing
> -------
>
> New UI:
> 
> The group columns cannot be ordered as they have sub-columns, this is expected.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 65346: Updated Web UI to show quota guarantee and
limit for roles.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65346/#review196798
-----------------------------------------------------------
PASS: Mesos patch 65346 was successfully built and tested.
Reviews applied: `['65503', '65346']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65346
- Mesos Reviewbot Windows
On Feb. 4, 2018, 9:18 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65346/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2018, 9:18 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Kapil Arya, Michael Park, and Meng Zhu.
>
>
> Bugs: MESOS-8486
> https://issues.apache.org/jira/browse/MESOS-8486
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/webui/master/static/css/mesos.css 3e3a3b13cfc4d63aea73d0a6572b22a2de94541e
> src/webui/master/static/index.html 46cb2843c2221ccebb7d811c0045be2c124afec1
> src/webui/master/static/js/app.js 8960f9d4421f7b96ba06deb623afafb06013b622
> src/webui/master/static/roles.html 1c84ad33a554e078d854e25b4d5ca311c8507f91
>
>
> Diff: https://reviews.apache.org/r/65346/diff/2/
>
>
> Testing
> -------
>
> New UI:
> 
> The group columns cannot be ordered as they have sub-columns, this is expected.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 65346: Updated Web UI to show quota guarantee and
limit for roles.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65346/#review196859
-----------------------------------------------------------
Very nice! A couple of questions:
(1) What is this going to show when the quota.guarantee is set? It should show that limit is set to the same numbers, but FWICT this will continue to display None? Note that we don't expose a limit field yet, so the UI shouldn't be trying to access one.
(2) I think we've generally showed '-' for unset fields to reduce the amount of visual cluster. So s/None/-/ here would be more consistent and probably look a bit cleaner?
(3) Is it possible to show thicker vertical lines between the group columns to make the grouping a bit clearer when looking further down the table?
src/webui/master/static/roles.html
Lines 46-49 (patched)
<https://reviews.apache.org/r/65346/#comment276737>
I also wonder here if s/0/-/ would make the table cleaner. Even though no guarantee = 0, it also would help the user see when the guarantee is set to 0 vs it's 0 because it's unset.
src/webui/master/static/roles.html
Lines 51-54 (patched)
<https://reviews.apache.org/r/65346/#comment276736>
We can't look at `limit` field yet, since it doesn't exist. Right now the limit is implicitly:
(1) No guarantee: no limit, or
(2) Some guarantee X: limit set to X.
For each resource. Can you have the UI display it accordingly?
Also, can we show "-" for these? I think that's been the general pattern in the UI for "unset" things to reduce visual clutter.
- Benjamin Mahler
On Feb. 4, 2018, 9:18 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65346/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2018, 9:18 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Kapil Arya, Michael Park, and Meng Zhu.
>
>
> Bugs: MESOS-8486
> https://issues.apache.org/jira/browse/MESOS-8486
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/webui/master/static/css/mesos.css 3e3a3b13cfc4d63aea73d0a6572b22a2de94541e
> src/webui/master/static/index.html 46cb2843c2221ccebb7d811c0045be2c124afec1
> src/webui/master/static/js/app.js 8960f9d4421f7b96ba06deb623afafb06013b622
> src/webui/master/static/roles.html 1c84ad33a554e078d854e25b4d5ca311c8507f91
>
>
> Diff: https://reviews.apache.org/r/65346/diff/2/
>
>
> Testing
> -------
>
> New UI:
> 
> The group columns cannot be ordered as they have sub-columns, this is expected.
>
>
> Thanks,
>
> Armand Grillet
>
>