[GitHub] [samza] sborya commented on a diff in pull request #1653: SAMZA-2774: Resolve classpath symlinks

["sborya (via GitHub)" <gi...@apache.org>]

sborya commented on code in PR #1653:
URL: https://github.com/apache/samza/pull/1653#discussion_r1116044676


##########
samza-shell/src/main/bash/run-class.sh:
##########
@@ -57,7 +57,11 @@ CLASSPATH=""
 # all the jars need to be appended on newlines to ensure line argument length of 72 bytes is not violated
 for file in $BASE_LIB_DIR/*.[jw]ar;
 do
-  CLASSPATH=$CLASSPATH" $file \n"
+  # Symlinks need to be resolved here, otherwise, the jars listed in the
+  # manifest below will point at the first container launched instead of
+  # the jars at the application level.
+  resolved_file=$( cd $(dirname $(readlink `[[ $OSTYPE == linux* ]] && echo "-f"` "$file")) ; pwd -P)

Review Comment:
   -f options also works on Mac, why linux only?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org