You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/29 22:35:10 UTC
[GitHub] [superset] exemplary-citizen opened a new pull request #17293: docs(UPDATING): Adding downtime for #16756
exemplary-citizen opened a new pull request #17293:
URL: https://github.com/apache/superset/pull/17293
SUMMARY
updating docs to inform of downtime from #16756
TESTING INSTRUCTIONS
Watch CI and any suggestions from reviewers
cc: @john-bodley @betodealmeida @villebro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai merged pull request #17293: docs(UPDATING): Adding downtime for #16756
Posted by GitBox <gi...@apache.org>.
nytai merged pull request #17293:
URL: https://github.com/apache/superset/pull/17293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on a change in pull request #17293: docs(UPDATING): Adding downtime for #16756
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #17293:
URL: https://github.com/apache/superset/pull/17293#discussion_r739583652
##########
File path: UPDATING.md
##########
@@ -31,6 +31,8 @@ assists people when migrating to a new version.
### Potential Downtime
+- [16756](https://github.com/apache/incubator-superset/pull/16756): The renaming of column `dbs.allow_csv_upload` fails for MySQL 8 users because there's a check constraint on it.
Review comment:
```suggestion
- [16756](https://github.com/apache/incubator-superset/pull/16756): a change which renames the `dbs.allow_csv_upload` column to `dbs.allow_file_upload` via a (potentially locking) DDL operation.
```
##########
File path: UPDATING.md
##########
@@ -31,6 +31,8 @@ assists people when migrating to a new version.
### Potential Downtime
+- [16756](https://github.com/apache/incubator-superset/pull/16756): The renaming of column `dbs.allow_csv_upload` fails for MySQL 8 users because there's a check constraint on it.
Review comment:
@exemplary-citizen it seems like @betodealmeida fix the MySQL 8 issue in the same migration and thus your original comment isn't really relevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org