[jira] [Commented] (FLINK-7863) Make MetricFetcher work with RestfulGateway

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209544#comment-16209544 ] 

ASF GitHub Bot commented on FLINK-7863:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4852

    [FLINK-7863] Generalize MetricFetcher to work with a RestfulGateway

    ## What is the purpose of the change
    
    Generalize MetricFetcher to work with `T extends RestfulGateway` instead of the `JobManagerGateway`. That way also the Flip-6 code can be used in combination with the `MetricFetcher`.
    
    ## Brief change log
    
    - Add `RestfulGateway#requestMetricQueryServicePaths` to obtain the metric service query paths for the cluster (so far only the `JobManager` or the `Dispatcher` in the Flip-6 case)
    - Add `RestfulGateway#requestTaskManagerMetricQueryServicePaths` to obtain the metric service query paths for the `TaskManagers`
    - Adapt `MetricFetcher` to work with `RestfulGateway`.
    
    ## Verifying this change
    
    Manually tested.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink generalizeMetricFetcher

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4852.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4852
    
----
commit 8691b45eebe4ce8aa8874705f708b38c23e9decd
Author: Till <ti...@gmail.com>
Date:   2017-10-18T11:50:06Z

    [FLINK-7863] Generalize MetricFetcher to work with a RestfulGateway
    
    Add more logging to MetricFetcher

----


> Make MetricFetcher work with RestfulGateway
> -------------------------------------------
>
>                 Key: FLINK-7863
>                 URL: https://issues.apache.org/jira/browse/FLINK-7863
>             Project: Flink
>          Issue Type: Sub-task
>          Components: REST
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>
> In order to make the {{MetricFetcher}} work together with the new architecture, we have to remove it's dependence on the {{JobManagerGateway}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)