[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #5008: assert: unify stack and register dump across platforms

[GitBox <gi...@apache.org>]

davids5 commented on a change in pull request #5008:
URL: https://github.com/apache/incubator-nuttx/pull/5008#discussion_r770490242



##########
File path: arch/arm/src/armv6-m/arm_assert.c
##########
@@ -288,27 +286,13 @@ static void up_dumpstate(void)
 #ifdef CONFIG_STACK_COLORATION
   _alert("  used: %08x\n", up_check_tcbstack(rtcb));
 #endif
-
-  /* Dump the user stack if the stack pointer lies within the allocated user
-   * stack memory.
-   */
-
-  if (sp >= ustackbase && sp < ustackbase + ustacksize)
-    {
-      up_stackdump(sp, ustackbase);
-    }
-  else
-    {
-      _alert("ERROR: Stack pointer is not within the allocated stack\n");

Review comment:
       Where is the replacement for this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org