You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Frederik Boster (Jira)" <ji...@apache.org> on 2021/02/26 11:47:00 UTC

[jira] [Commented] (MGPG-66) sign goal's "excludes" configuration ignored

    [ https://issues.apache.org/jira/browse/MGPG-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291596#comment-17291596 ] 

Frederik Boster commented on MGPG-66:
-------------------------------------

I submitted a similar patch via [PR #10|https://github.com/apache/maven-gpg-plugin/pull/10].

> sign goal's "excludes" configuration ignored
> --------------------------------------------
>
>                 Key: MGPG-66
>                 URL: https://issues.apache.org/jira/browse/MGPG-66
>             Project: Maven GPG Plugin
>          Issue Type: Bug
>    Affects Versions: 1.6
>            Reporter: Marshall Schor
>            Priority: Major
>         Attachments: maven-gpg-plugin-MGPG-66-patch.txt
>
>
> The class GpgSignAttachedMojo computes the excludes, and has a method isExcluded(name), but that method is never called.  As a result, the excludes are ignored.
> A fix is to add if ( ! isExcluded( file.getPath() ) ) around the code in the loop over all attached artifacts.  (I tried this and it seems to work)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)