[jira] [Comment Edited] (MESOS-9302) Mesos fails to build on Fedora 28

["Benjamin Bannier (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-9302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650182#comment-16650182 ] 

Benjamin Bannier edited comment on MESOS-9302 at 10/15/18 1:12 PM:
-------------------------------------------------------------------

This is due to us interpreting this flag only in our own \{{Makefile}},
{code:java|title=configure.ac}
# Define `WERROR` if the use of `-Werror` was not disabled, leave
# unset otherwise. An unset variable evaluates to an empty string
# in autoconf's substitution.
AS_IF([test "x$enable_werror" != "xno"],
      [AC_SUBST([WERROR], [-Werror])])
{code}
and
{code:java|title=src/Makefile.am}
MESOS_CPPFLAGS += @WERROR@
{code}
If we care for {{--disable-werror}} to propagate to bundled dependencies, we should either patch their build systems to respect the flag when passed in, or disable warnings for these projects altogether with {{-w}}.


was (Author: bbannier):
This is due to use interpreting this flag only in our own {{Makefile}}s,
{code:title=configure.ac}
# Define `WERROR` if the use of `-Werror` was not disabled, leave
# unset otherwise. An unset variable evaluates to an empty string
# in autoconf's substitution.
AS_IF([test "x$enable_werror" != "xno"],
      [AC_SUBST([WERROR], [-Werror])])
{code}
and
{code:title=src/Makefile.am}
MESOS_CPPFLAGS += @WERROR@
{code}

If we care for {{--disable-werror}} to propagate to bundled dependencies, we should either patch their build systems to respect the flag when passed in, or disable warnings for these projects altogether with {{-w}}.

> Mesos fails to build on Fedora 28
> ---------------------------------
>
>                 Key: MESOS-9302
>                 URL: https://issues.apache.org/jira/browse/MESOS-9302
>             Project: Mesos
>          Issue Type: Bug
>         Environment: gcc (GCC) 8.1.1 20180712 (Red Hat 8.1.1-5)
> Fedora 28
>            Reporter: Benno Evers
>            Priority: Major
>              Labels: build-failure
>
> Trying to compile a fresh Mesos checkout on a Fedora 28 system with the following configuration flags:
> {noformat}
> ../configure --enable-debug --enable-optimize --disable-java --disable-python --disable-libtool-wrappers --enable-ssl --enable-libevent --disable-werror
> {noformat}
> and the following compiler
> {noformat}
> [bevers@core1.hw.ca1 build]$ gcc --version
> gcc (GCC) 8.1.1 20180712 (Red Hat 8.1.1-5)
> Copyright (C) 2018 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> {noformat}
> fails the build due to two warnings (even though --disable-werror was passed):
> {noformat}
> make[4]: Entering directory '/home/bevers/mesos/build/3rdparty/grpc-1.10.0'
> [C]       Compiling third_party/cares/cares/ares_init.c
> third_party/cares/cares/ares_init.c: In function ‘ares_dup’:
> third_party/cares/cares/ares_init.c:301:17: error: argument to ‘sizeof’ in ‘strncpy’ call is the same expression as the source; did you mean to use the size of the destination? [-Werror=sizeof-pointer-memaccess]
>            sizeof(src->local_dev_name));
>                  ^
> third_party/cares/cares/ares_init.c: At top level:
> cc1: error: unrecognized command line option ‘-Wno-invalid-source-encoding’ [-Werror]
> cc1: all warnings being treated as errors
> make[4]: *** [Makefile:2635: /home/bevers/mesos/build/3rdparty/grpc-1.10.0/objs/opt/third_party/cares/cares/ares_init.o] Error 1
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)