You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/27 10:17:48 UTC

[GitHub] [shardingsphere-elasticjob] wwj-go opened a new pull request #1665: Fix ZookeeperElectionServiceTest.assertContend failed for travis-ci

wwj-go opened a new pull request #1665:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1665


   Fixes #1660.
   
   Changes proposed in this pull request:
   - ZookeeperElectionServiceTest.assertContend
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a change in pull request #1665: Fix ZookeeperElectionServiceTest.assertContend failed for travis-ci

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #1665:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1665#discussion_r512630131



##########
File path: elasticjob-infra/elasticjob-registry-center/src/test/java/org/apache/shardingsphere/elasticjob/reg/zookeeper/ZookeeperElectionServiceTest.java
##########
@@ -29,9 +29,12 @@
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.mockito.Mock;
+import org.mockito.internal.verification.VerificationModeFactory;

Review comment:
       Should we use the Class defined under package `internal`?
   Maybe using `org.mockito.Mockito#atLeastOnce` is better.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere-elasticjob] Technoboy- merged pull request #1665: Fix ZookeeperElectionServiceTest.assertContend failed for travis-ci

Posted by GitBox <gi...@apache.org>.
Technoboy- merged pull request #1665:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1665


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere-elasticjob] wwj-go commented on a change in pull request #1665: Fix ZookeeperElectionServiceTest.assertContend failed for travis-ci

Posted by GitBox <gi...@apache.org>.
wwj-go commented on a change in pull request #1665:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1665#discussion_r512634601



##########
File path: elasticjob-infra/elasticjob-registry-center/src/test/java/org/apache/shardingsphere/elasticjob/reg/zookeeper/ZookeeperElectionServiceTest.java
##########
@@ -29,9 +29,12 @@
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.mockito.Mock;
+import org.mockito.internal.verification.VerificationModeFactory;

Review comment:
       you are right, I will correct it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a change in pull request #1665: Fix ZookeeperElectionServiceTest.assertContend failed for travis-ci

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #1665:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1665#discussion_r512630131



##########
File path: elasticjob-infra/elasticjob-registry-center/src/test/java/org/apache/shardingsphere/elasticjob/reg/zookeeper/ZookeeperElectionServiceTest.java
##########
@@ -29,9 +29,12 @@
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.mockito.Mock;
+import org.mockito.internal.verification.VerificationModeFactory;

Review comment:
       Should we use the Class define under package `internal`?
   Maybe using `org.mockito.Mockito#atLeastOnce` is better.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org