You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/06/04 12:50:06 UTC
[GitHub] [incubator-apisix] nic-chen opened a new pull request #1655: feat: resource name
nic-chen opened a new pull request #1655:
URL: https://github.com/apache/incubator-apisix/pull/1655
### Summary
add `name` field for route, service, upstream to name each instance, and it is unique, can't be duplicate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] nic-chen commented on pull request #1655: feat: resource name
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1655:
URL: https://github.com/apache/incubator-apisix/pull/1655#issuecomment-640161180
yes , please. @moonming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on pull request #1655: feat: resource name
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1655:
URL: https://github.com/apache/incubator-apisix/pull/1655#issuecomment-640332247
@nic-chen missing doc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] moonming commented on pull request #1655: feat: resource name
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #1655:
URL: https://github.com/apache/incubator-apisix/pull/1655#issuecomment-640151186
@nic-chen Is this PR reday for review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis merged pull request #1655: feat: resource name
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1655:
URL: https://github.com/apache/incubator-apisix/pull/1655
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on a change in pull request #1655: feat: resource name
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1655:
URL: https://github.com/apache/incubator-apisix/pull/1655#discussion_r435656111
##########
File path: t/admin/upstream.t
##########
@@ -1146,7 +1146,7 @@ GET /t
-=== TEST 35: type chash, hash_on: consumer, don't need upstream key
+=== TEST 35: type chash, hash_on: consumer, donot need upstream key
Review comment:
`donot` -> `do not`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] nic-chen commented on pull request #1655: feat: resource name
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1655:
URL: https://github.com/apache/incubator-apisix/pull/1655#issuecomment-640459425
done. @membphis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org