[jira] [Commented] (TOBAGO-1721) Optimize HTML output when two renderer are involved

["Hudson (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/TOBAGO-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948951#comment-15948951 ] 

Hudson commented on TOBAGO-1721:
--------------------------------

SUCCESS: Integrated in Jenkins build Tobago Trunk #838 (See [https://builds.apache.org/job/Tobago%20Trunk/838/])
TOBAGO-1721 Optimize HTML output when two renderer are involved
* RadioButtons, checkboxes and links in a dropdown menu improved
[developed by hnoeth] (lofwyr: [http://svn.apache.org/viewvc/?view=rev&rev=1789500])
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/component/RendererTypes.java
* (add) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/ButtonAlternativeInRenderer.java
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/ButtonsRenderer.java
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/CommandRendererBase.java
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/FormRenderer.java
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/InRenderer.java
* (add) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/LinkAlternativeCommandRenderer.java
* (add) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/LinkAlternativeLinksRenderer.java
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/LinksRenderer.java
* (add) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectBooleanCheckboxAlternativeCommandRenderer.java
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectBooleanCheckboxRenderer.java
* (add) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyCheckboxAlternativeCommandRenderer.java
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyCheckboxRenderer.java
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneChoiceAlternativeInRenderer.java
* (add) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneRadioAlternativeCommandRenderer.java
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneRadioRenderer.java
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/ButtonTagDeclaration.java
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/LinkTagDeclaration.java
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/SelectBooleanCheckboxTagDeclaration.java
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/SelectManyCheckboxTagDeclaration.java
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/SelectOneRadioTagDeclaration.java
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/layout/Measure.java
* (edit) tobago-trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriter.java
* (edit) tobago-trunk/tobago-core/src/main/resources/scss/_tobago.scss


> Optimize HTML output when two renderer are involved
> ---------------------------------------------------
>
>                 Key: TOBAGO-1721
>                 URL: https://issues.apache.org/jira/browse/TOBAGO-1721
>             Project: MyFaces Tobago
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.0.3
>            Reporter: Henning Noeth
>            Assignee: Henning Noeth
>
> A renderer produce HTML code without consider the environment.
> For example:
> The InRenderer always generate a <span/> around children.
> If a button has children, the ButtonRenderer always generate a <span/> element around the button and its children.
> So if a <tc:button> is inside a <tc:in>, two <span/> elements would be generated.
> In this case, the renderer should work together, to only generate one <span> element.
> The generated code is more compact.
> It's more the way of bootstrap.
> And because of that, there are less problems to solve with CSS.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)