You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/10/21 12:25:38 UTC
[GitHub] [nifi] mark-bathori opened a new pull request, #6565: NIFI-10516: PutORC with Java 17 fails when using SNAPPY Compression
mark-bathori opened a new pull request, #6565:
URL: https://github.com/apache/nifi/pull/6565
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-10516](https://issues.apache.org/jira/browse/NIFI-10516)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [x] Build completed using `mvn clean install -P contrib-check`
- [x] JDK 8
- [ ] JDK 11
- [x] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6565: NIFI-10516: PutORC with Java 17 fails when using SNAPPY Compression
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6565:
URL: https://github.com/apache/nifi/pull/6565#issuecomment-1289025385
Thanks for the reply @mark-bathori.
Although it will take more effort for a user to adjust a bootstrap.conf setting, it seems like the best solution in this case due to the nature of the workaround.
There is an open issue for the Snappy Java project to change the behavior, so I recommend referencing this issue URL in the comment, and note that it applies to any component that makes use of snappy-java.
https://github.com/xerial/snappy-java/issues/348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6565: NIFI-10516: PutORC with Java 17 fails when using SNAPPY Compression
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6565:
URL: https://github.com/apache/nifi/pull/6565#issuecomment-1302101249
@mark-bathori Given that the changes to make this work would require a more generalized change to bootstrap.conf, I think it is best to close this pull request and create a new one that describes the more generalized nature of the change. Alternatively, it seems better to leave the Jira issue open for now and monitor progress on the snappy-java issue. I'm closing this pull request for now, but if you want to propose a configurable bootstrap.conf approach, feel free to open to a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6565: NIFI-10516: PutORC with Java 17 fails when using SNAPPY Compression
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #6565: NIFI-10516: PutORC with Java 17 fails when using SNAPPY Compression
URL: https://github.com/apache/nifi/pull/6565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mark-bathori commented on pull request #6565: NIFI-10516: PutORC with Java 17 fails when using SNAPPY Compression
Posted by GitBox <gi...@apache.org>.
mark-bathori commented on PR #6565:
URL: https://github.com/apache/nifi/pull/6565#issuecomment-1288733132
Thanks @exceptionfactory for the review.
First I wanted to upgrade the snappy version but it already use the latest version. After that I also checked the `bootstrap.conf` solution just didn’t know if it can be expected from the user to know that enabling this jvm parameter is required to use certain processor, that’s why I thought that the NiFi runner should do this automatically based on the jdk version.
I was looking the oracle’s documentation for the jdk8+ migration: https://docs.oracle.com/en/java/javase/16/migrate/migrating-jdk-8-later-jdk-releases.html
However as you mentioned, modifying the JVM’s behaviour for one processor doesn't seems to be the best solution.
My question is, should I add any specific comment in the bootstrap.conf that reflects to the PutOrc processor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org