You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Mithun Radhakrishnan (JIRA)" <ji...@apache.org> on 2012/11/07 01:30:12 UTC
[jira] [Created] (HIVE-3680) Include Table information in Hive's
AddPartitionEvent.
Mithun Radhakrishnan created HIVE-3680:
------------------------------------------
Summary: Include Table information in Hive's AddPartitionEvent.
Key: HIVE-3680
URL: https://issues.apache.org/jira/browse/HIVE-3680
Project: Hive
Issue Type: Bug
Components: Metastore
Affects Versions: 0.9.1
Reporter: Mithun Radhakrishnan
Fix For: 0.9.1
This has to do with a minor overhaul of the HCatalog notifications that we're attempting in HCATALOG-546.
It is proposed that HCatalog's notifications (on Add/Drop of Partitions) provide details to identify the affected partitions.
Using the Partition object in AddPartitionEvent, one is able to retrieve the values of the partition-keys and the name of the Table. However, the partition-keys themselves aren't available (since the Table instance isn't part of the AddPartitionEvent).
Adding the table-reference to the AddPartitionEvent and DropPartitionEvent classes will expose all the info we need. (The alternative is to query the metastore for the table's schema and use the partition-keys from there. :/)
I'll post a patch for this shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3680) Include Table information in Hive's
AddPartitionEvent.
Posted by "Mithun Radhakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mithun Radhakrishnan updated HIVE-3680:
---------------------------------------
Attachment: HIVE-3680.trunk.patch
HIVE-3680.branch9.patch
@[~ashutoshc]: Quite right. Here's the updated diff(s), with tests modified. Does this look alright?
> Include Table information in Hive's AddPartitionEvent.
> ------------------------------------------------------
>
> Key: HIVE-3680
> URL: https://issues.apache.org/jira/browse/HIVE-3680
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.1
> Reporter: Mithun Radhakrishnan
> Fix For: 0.9.1
>
> Attachments: HIVE-3680.branch9.patch, HIVE-3680.trunk.patch
>
>
> This has to do with a minor overhaul of the HCatalog notifications that we're attempting in HCATALOG-546.
> It is proposed that HCatalog's notifications (on Add/Drop of Partitions) provide details to identify the affected partitions.
> Using the Partition object in AddPartitionEvent, one is able to retrieve the values of the partition-keys and the name of the Table. However, the partition-keys themselves aren't available (since the Table instance isn't part of the AddPartitionEvent).
> Adding the table-reference to the AddPartitionEvent and DropPartitionEvent classes will expose all the info we need. (The alternative is to query the metastore for the table's schema and use the partition-keys from there. :/)
> I'll post a patch for this shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3680) Include Table information in Hive's
AddPartitionEvent.
Posted by "Mithun Radhakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mithun Radhakrishnan updated HIVE-3680:
---------------------------------------
Status: Patch Available (was: Open)
> Include Table information in Hive's AddPartitionEvent.
> ------------------------------------------------------
>
> Key: HIVE-3680
> URL: https://issues.apache.org/jira/browse/HIVE-3680
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.1
> Reporter: Mithun Radhakrishnan
> Fix For: 0.9.1
>
> Attachments: HIVE-3680.patch
>
>
> This has to do with a minor overhaul of the HCatalog notifications that we're attempting in HCATALOG-546.
> It is proposed that HCatalog's notifications (on Add/Drop of Partitions) provide details to identify the affected partitions.
> Using the Partition object in AddPartitionEvent, one is able to retrieve the values of the partition-keys and the name of the Table. However, the partition-keys themselves aren't available (since the Table instance isn't part of the AddPartitionEvent).
> Adding the table-reference to the AddPartitionEvent and DropPartitionEvent classes will expose all the info we need. (The alternative is to query the metastore for the table's schema and use the partition-keys from there. :/)
> I'll post a patch for this shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3680) Include Table information in Hive's
AddPartitionEvent.
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503016#comment-13503016 ]
Ashutosh Chauhan commented on HIVE-3680:
----------------------------------------
Committed to 0.9 branch as well.
> Include Table information in Hive's AddPartitionEvent.
> ------------------------------------------------------
>
> Key: HIVE-3680
> URL: https://issues.apache.org/jira/browse/HIVE-3680
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.1
> Reporter: Mithun Radhakrishnan
> Assignee: Mithun Radhakrishnan
> Fix For: 0.10.0, 0.9.1
>
> Attachments: HIVE-3680.branch9.patch, HIVE-3680.trunk.patch
>
>
> This has to do with a minor overhaul of the HCatalog notifications that we're attempting in HCATALOG-546.
> It is proposed that HCatalog's notifications (on Add/Drop of Partitions) provide details to identify the affected partitions.
> Using the Partition object in AddPartitionEvent, one is able to retrieve the values of the partition-keys and the name of the Table. However, the partition-keys themselves aren't available (since the Table instance isn't part of the AddPartitionEvent).
> Adding the table-reference to the AddPartitionEvent and DropPartitionEvent classes will expose all the info we need. (The alternative is to query the metastore for the table's schema and use the partition-keys from there. :/)
> I'll post a patch for this shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3680) Include Table information in Hive's
AddPartitionEvent.
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-3680:
-----------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.9.1)
0.10.0
Assignee: Mithun Radhakrishnan
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks, Mithun!
> Include Table information in Hive's AddPartitionEvent.
> ------------------------------------------------------
>
> Key: HIVE-3680
> URL: https://issues.apache.org/jira/browse/HIVE-3680
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.1
> Reporter: Mithun Radhakrishnan
> Assignee: Mithun Radhakrishnan
> Fix For: 0.10.0
>
> Attachments: HIVE-3680.branch9.patch, HIVE-3680.trunk.patch
>
>
> This has to do with a minor overhaul of the HCatalog notifications that we're attempting in HCATALOG-546.
> It is proposed that HCatalog's notifications (on Add/Drop of Partitions) provide details to identify the affected partitions.
> Using the Partition object in AddPartitionEvent, one is able to retrieve the values of the partition-keys and the name of the Table. However, the partition-keys themselves aren't available (since the Table instance isn't part of the AddPartitionEvent).
> Adding the table-reference to the AddPartitionEvent and DropPartitionEvent classes will expose all the info we need. (The alternative is to query the metastore for the table's schema and use the partition-keys from there. :/)
> I'll post a patch for this shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3680) Include Table information in Hive's
AddPartitionEvent.
Posted by "Mithun Radhakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498107#comment-13498107 ]
Mithun Radhakrishnan commented on HIVE-3680:
--------------------------------------------
Thank you, [~ashutoshc]. :] Any chance at a backport to branch-9? The patch is included.
> Include Table information in Hive's AddPartitionEvent.
> ------------------------------------------------------
>
> Key: HIVE-3680
> URL: https://issues.apache.org/jira/browse/HIVE-3680
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.1
> Reporter: Mithun Radhakrishnan
> Assignee: Mithun Radhakrishnan
> Fix For: 0.10.0
>
> Attachments: HIVE-3680.branch9.patch, HIVE-3680.trunk.patch
>
>
> This has to do with a minor overhaul of the HCatalog notifications that we're attempting in HCATALOG-546.
> It is proposed that HCatalog's notifications (on Add/Drop of Partitions) provide details to identify the affected partitions.
> Using the Partition object in AddPartitionEvent, one is able to retrieve the values of the partition-keys and the name of the Table. However, the partition-keys themselves aren't available (since the Table instance isn't part of the AddPartitionEvent).
> Adding the table-reference to the AddPartitionEvent and DropPartitionEvent classes will expose all the info we need. (The alternative is to query the metastore for the table's schema and use the partition-keys from there. :/)
> I'll post a patch for this shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3680) Include Table information in Hive's
AddPartitionEvent.
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-3680:
-----------------------------------
Fix Version/s: 0.9.1
> Include Table information in Hive's AddPartitionEvent.
> ------------------------------------------------------
>
> Key: HIVE-3680
> URL: https://issues.apache.org/jira/browse/HIVE-3680
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.1
> Reporter: Mithun Radhakrishnan
> Assignee: Mithun Radhakrishnan
> Fix For: 0.10.0, 0.9.1
>
> Attachments: HIVE-3680.branch9.patch, HIVE-3680.trunk.patch
>
>
> This has to do with a minor overhaul of the HCatalog notifications that we're attempting in HCATALOG-546.
> It is proposed that HCatalog's notifications (on Add/Drop of Partitions) provide details to identify the affected partitions.
> Using the Partition object in AddPartitionEvent, one is able to retrieve the values of the partition-keys and the name of the Table. However, the partition-keys themselves aren't available (since the Table instance isn't part of the AddPartitionEvent).
> Adding the table-reference to the AddPartitionEvent and DropPartitionEvent classes will expose all the info we need. (The alternative is to query the metastore for the table's schema and use the partition-keys from there. :/)
> I'll post a patch for this shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3680) Include Table information in Hive's
AddPartitionEvent.
Posted by "Mithun Radhakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mithun Radhakrishnan updated HIVE-3680:
---------------------------------------
Attachment: (was: HIVE-3680.patch)
> Include Table information in Hive's AddPartitionEvent.
> ------------------------------------------------------
>
> Key: HIVE-3680
> URL: https://issues.apache.org/jira/browse/HIVE-3680
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.1
> Reporter: Mithun Radhakrishnan
> Fix For: 0.9.1
>
>
> This has to do with a minor overhaul of the HCatalog notifications that we're attempting in HCATALOG-546.
> It is proposed that HCatalog's notifications (on Add/Drop of Partitions) provide details to identify the affected partitions.
> Using the Partition object in AddPartitionEvent, one is able to retrieve the values of the partition-keys and the name of the Table. However, the partition-keys themselves aren't available (since the Table instance isn't part of the AddPartitionEvent).
> Adding the table-reference to the AddPartitionEvent and DropPartitionEvent classes will expose all the info we need. (The alternative is to query the metastore for the table's schema and use the partition-keys from there. :/)
> I'll post a patch for this shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3680) Include Table information in Hive's
AddPartitionEvent.
Posted by "Mithun Radhakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mithun Radhakrishnan updated HIVE-3680:
---------------------------------------
Attachment: HIVE-3680.patch
Proposed change.
> Include Table information in Hive's AddPartitionEvent.
> ------------------------------------------------------
>
> Key: HIVE-3680
> URL: https://issues.apache.org/jira/browse/HIVE-3680
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.1
> Reporter: Mithun Radhakrishnan
> Fix For: 0.9.1
>
> Attachments: HIVE-3680.patch
>
>
> This has to do with a minor overhaul of the HCatalog notifications that we're attempting in HCATALOG-546.
> It is proposed that HCatalog's notifications (on Add/Drop of Partitions) provide details to identify the affected partitions.
> Using the Partition object in AddPartitionEvent, one is able to retrieve the values of the partition-keys and the name of the Table. However, the partition-keys themselves aren't available (since the Table instance isn't part of the AddPartitionEvent).
> Adding the table-reference to the AddPartitionEvent and DropPartitionEvent classes will expose all the info we need. (The alternative is to query the metastore for the table's schema and use the partition-keys from there. :/)
> I'll post a patch for this shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3680) Include Table information in Hive's
AddPartitionEvent.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503026#comment-13503026 ]
Hudson commented on HIVE-3680:
------------------------------
Integrated in Hive-0.9.1-SNAPSHOT-h0.21-keepgoing=false #207 (See [https://builds.apache.org/job/Hive-0.9.1-SNAPSHOT-h0.21-keepgoing=false/207/])
HIVE-3680 : Include Table information in Hive's AddPartitionEvent. (Mithun RadhaKrishnan via Ashutosh Chauhan) (Revision 1412750)
Result = FAILURE
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1412750
Files :
* /hive/branches/branch-0.9/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
* /hive/branches/branch-0.9/metastore/src/java/org/apache/hadoop/hive/metastore/events/AddPartitionEvent.java
* /hive/branches/branch-0.9/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java
* /hive/branches/branch-0.9/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
> Include Table information in Hive's AddPartitionEvent.
> ------------------------------------------------------
>
> Key: HIVE-3680
> URL: https://issues.apache.org/jira/browse/HIVE-3680
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.1
> Reporter: Mithun Radhakrishnan
> Assignee: Mithun Radhakrishnan
> Fix For: 0.10.0, 0.9.1
>
> Attachments: HIVE-3680.branch9.patch, HIVE-3680.trunk.patch
>
>
> This has to do with a minor overhaul of the HCatalog notifications that we're attempting in HCATALOG-546.
> It is proposed that HCatalog's notifications (on Add/Drop of Partitions) provide details to identify the affected partitions.
> Using the Partition object in AddPartitionEvent, one is able to retrieve the values of the partition-keys and the name of the Table. However, the partition-keys themselves aren't available (since the Table instance isn't part of the AddPartitionEvent).
> Adding the table-reference to the AddPartitionEvent and DropPartitionEvent classes will expose all the info we need. (The alternative is to query the metastore for the table's schema and use the partition-keys from there. :/)
> I'll post a patch for this shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3680) Include Table information in Hive's
AddPartitionEvent.
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495993#comment-13495993 ]
Ashutosh Chauhan commented on HIVE-3680:
----------------------------------------
Patch looks good. Mithun, can you also add a test for completeness. TestMetaStoreEventListener.java seems to be appropriate to add this test.
> Include Table information in Hive's AddPartitionEvent.
> ------------------------------------------------------
>
> Key: HIVE-3680
> URL: https://issues.apache.org/jira/browse/HIVE-3680
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.1
> Reporter: Mithun Radhakrishnan
> Fix For: 0.9.1
>
> Attachments: HIVE-3680.patch
>
>
> This has to do with a minor overhaul of the HCatalog notifications that we're attempting in HCATALOG-546.
> It is proposed that HCatalog's notifications (on Add/Drop of Partitions) provide details to identify the affected partitions.
> Using the Partition object in AddPartitionEvent, one is able to retrieve the values of the partition-keys and the name of the Table. However, the partition-keys themselves aren't available (since the Table instance isn't part of the AddPartitionEvent).
> Adding the table-reference to the AddPartitionEvent and DropPartitionEvent classes will expose all the info we need. (The alternative is to query the metastore for the table's schema and use the partition-keys from there. :/)
> I'll post a patch for this shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3680) Include Table information in Hive's
AddPartitionEvent.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498537#comment-13498537 ]
Hudson commented on HIVE-3680:
------------------------------
Integrated in Hive-trunk-h0.21 #1799 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1799/])
HIVE-3680 : Include Table information in Hive's AddPartitionEvent. (Mithun Radhakrishnan via Ashutosh Chauhan) (Revision 1409861)
Result = FAILURE
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409861
Files :
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AddPartitionEvent.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java
* /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
> Include Table information in Hive's AddPartitionEvent.
> ------------------------------------------------------
>
> Key: HIVE-3680
> URL: https://issues.apache.org/jira/browse/HIVE-3680
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.1
> Reporter: Mithun Radhakrishnan
> Assignee: Mithun Radhakrishnan
> Fix For: 0.10.0
>
> Attachments: HIVE-3680.branch9.patch, HIVE-3680.trunk.patch
>
>
> This has to do with a minor overhaul of the HCatalog notifications that we're attempting in HCATALOG-546.
> It is proposed that HCatalog's notifications (on Add/Drop of Partitions) provide details to identify the affected partitions.
> Using the Partition object in AddPartitionEvent, one is able to retrieve the values of the partition-keys and the name of the Table. However, the partition-keys themselves aren't available (since the Table instance isn't part of the AddPartitionEvent).
> Adding the table-reference to the AddPartitionEvent and DropPartitionEvent classes will expose all the info we need. (The alternative is to query the metastore for the table's schema and use the partition-keys from there. :/)
> I'll post a patch for this shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3680) Include Table information in Hive's
AddPartitionEvent.
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497645#comment-13497645 ]
Ashutosh Chauhan commented on HIVE-3680:
----------------------------------------
Yup, it does. +1 Running tests now, will commit if tests pass.
> Include Table information in Hive's AddPartitionEvent.
> ------------------------------------------------------
>
> Key: HIVE-3680
> URL: https://issues.apache.org/jira/browse/HIVE-3680
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.1
> Reporter: Mithun Radhakrishnan
> Fix For: 0.9.1
>
> Attachments: HIVE-3680.branch9.patch, HIVE-3680.trunk.patch
>
>
> This has to do with a minor overhaul of the HCatalog notifications that we're attempting in HCATALOG-546.
> It is proposed that HCatalog's notifications (on Add/Drop of Partitions) provide details to identify the affected partitions.
> Using the Partition object in AddPartitionEvent, one is able to retrieve the values of the partition-keys and the name of the Table. However, the partition-keys themselves aren't available (since the Table instance isn't part of the AddPartitionEvent).
> Adding the table-reference to the AddPartitionEvent and DropPartitionEvent classes will expose all the info we need. (The alternative is to query the metastore for the table's schema and use the partition-keys from there. :/)
> I'll post a patch for this shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3680) Include Table information in Hive's
AddPartitionEvent.
Posted by "Mark Grover (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492097#comment-13492097 ]
Mark Grover commented on HIVE-3680:
-----------------------------------
For completeness, the review is at
https://reviews.apache.org/r/7910/
> Include Table information in Hive's AddPartitionEvent.
> ------------------------------------------------------
>
> Key: HIVE-3680
> URL: https://issues.apache.org/jira/browse/HIVE-3680
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.1
> Reporter: Mithun Radhakrishnan
> Fix For: 0.9.1
>
> Attachments: HIVE-3680.patch
>
>
> This has to do with a minor overhaul of the HCatalog notifications that we're attempting in HCATALOG-546.
> It is proposed that HCatalog's notifications (on Add/Drop of Partitions) provide details to identify the affected partitions.
> Using the Partition object in AddPartitionEvent, one is able to retrieve the values of the partition-keys and the name of the Table. However, the partition-keys themselves aren't available (since the Table instance isn't part of the AddPartitionEvent).
> Adding the table-reference to the AddPartitionEvent and DropPartitionEvent classes will expose all the info we need. (The alternative is to query the metastore for the table's schema and use the partition-keys from there. :/)
> I'll post a patch for this shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3680) Include Table information in Hive's
AddPartitionEvent.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503171#comment-13503171 ]
Hudson commented on HIVE-3680:
------------------------------
Integrated in Hive-0.9.1-SNAPSHOT-h0.21 #207 (See [https://builds.apache.org/job/Hive-0.9.1-SNAPSHOT-h0.21/207/])
HIVE-3680 : Include Table information in Hive's AddPartitionEvent. (Mithun RadhaKrishnan via Ashutosh Chauhan) (Revision 1412750)
Result = SUCCESS
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1412750
Files :
* /hive/branches/branch-0.9/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
* /hive/branches/branch-0.9/metastore/src/java/org/apache/hadoop/hive/metastore/events/AddPartitionEvent.java
* /hive/branches/branch-0.9/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java
* /hive/branches/branch-0.9/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
> Include Table information in Hive's AddPartitionEvent.
> ------------------------------------------------------
>
> Key: HIVE-3680
> URL: https://issues.apache.org/jira/browse/HIVE-3680
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.1
> Reporter: Mithun Radhakrishnan
> Assignee: Mithun Radhakrishnan
> Fix For: 0.10.0, 0.9.1
>
> Attachments: HIVE-3680.branch9.patch, HIVE-3680.trunk.patch
>
>
> This has to do with a minor overhaul of the HCatalog notifications that we're attempting in HCATALOG-546.
> It is proposed that HCatalog's notifications (on Add/Drop of Partitions) provide details to identify the affected partitions.
> Using the Partition object in AddPartitionEvent, one is able to retrieve the values of the partition-keys and the name of the Table. However, the partition-keys themselves aren't available (since the Table instance isn't part of the AddPartitionEvent).
> Adding the table-reference to the AddPartitionEvent and DropPartitionEvent classes will expose all the info we need. (The alternative is to query the metastore for the table's schema and use the partition-keys from there. :/)
> I'll post a patch for this shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira