You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by "Leif Hedstrom (JIRA)" <ji...@apache.org> on 2010/03/22 18:35:27 UTC

[jira] Created: (TS-265) Deprecated APIs has misleading (wrong?) comments in ts/ts.h

Deprecated APIs has misleading (wrong?) comments in ts/ts.h
-----------------------------------------------------------

                 Key: TS-265
                 URL: https://issues.apache.org/jira/browse/TS-265
             Project: Traffic Server
          Issue Type: Bug
          Components: InkAPI
            Reporter: Leif Hedstrom
            Priority: Minor


In ts/ts.h, there's a number of APIs marked as deprecated, and suggesting new APIs which I can't seem to find anywhere:

 // --------------------------------------------------------------------------
  // Deprecated MIME field functions in SDK3.0

  /** @deprecated Use INKMimeHdrFieldAppend() instead */
  inkapi INKReturnCode INKMimeHdrFieldInsert(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx);

  /** @deprecated Use INKMimeHdrFieldStringInsert() instead */
  inkapi INKReturnCode INKMimeHdrFieldValueInsert(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, const char *value, int length, int idx);

  /** @deprecated Use INKMimeHdrFieldIntInsert() instead */
  inkapi INKReturnCode INKMimeHdrFieldValueInsertInt(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int value, int idx);

  /** @deprecated Use INKMimeHdrFieldUintInsert() instead */
  inkapi INKReturnCode INKMimeHdrFieldValueInsertUint(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, unsigned int value, int idx);

  /** @deprecated Use INKMimeHdrFieldDateInsert() instead */
  inkapi INKReturnCode INKMimeHdrFieldValueInsertDate(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, time_t value, int idx);

  /** @deprecated Use INKMimeHdrFieldStringGet() instead */
  inkapi const char *INKMimeHdrFieldValueGet(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx, int *value_len_ptr);

  /** @deprecated Use INKMimeHdrFieldIntGet() instead */
  inkapi int INKMimeHdrFieldValueGetInt(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx);

  /** @deprecated Use INKMimeHdrFieldUintGet() instead */
  inkapi unsigned int INKMimeHdrFieldValueGetUint(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx);

  /** @deprecated Use INKMimeHdrFieldDateGet() instead */
  inkapi time_t INKMimeHdrFieldValueGetDate(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx);

  /** @deprecated Use INKMimeHdrFieldStringSet() instead */
  inkapi INKReturnCode INKMimeHdrFieldValueSet(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx, const char *value, int length);

  /** @deprecated Use INKMimeHdrFieldIntSet() instead */
  inkapi INKReturnCode INKMimeHdrFieldValueSetInt(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx, int value);

  /** @deprecated Use INKMimeHdrFieldUintSet() instead */
  inkapi INKReturnCode INKMimeHdrFieldValueSetUint(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx, unsigned int value);

  /** @deprecated Use INKMimeHdrFieldDateSet() instead */
  inkapi INKReturnCode INKMimeHdrFieldValueSetDate(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx, time_t value);

  /** @deprecated Use INKMimeHdrFieldDestroy() instead */
  inkapi INKReturnCode INKMimeHdrFieldDelete(INKMBuffer bufp, INKMLoc hdr, INKMLoc field);



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TS-265) Deprecated APIs has misleading (wrong?) comments in ts/ts.h

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom updated TS-265:
-----------------------------

    Fix Version/s: 2.1.0

> Deprecated APIs has misleading (wrong?) comments in ts/ts.h
> -----------------------------------------------------------
>
>                 Key: TS-265
>                 URL: https://issues.apache.org/jira/browse/TS-265
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: InkAPI
>            Reporter: Leif Hedstrom
>            Priority: Minor
>             Fix For: 2.1.0
>
>
> In ts/ts.h, there's a number of APIs marked as deprecated, and suggesting new APIs which I can't seem to find anywhere:
>  // --------------------------------------------------------------------------
>   // Deprecated MIME field functions in SDK3.0
>   /** @deprecated Use INKMimeHdrFieldAppend() instead */
>   inkapi INKReturnCode INKMimeHdrFieldInsert(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx);
>   /** @deprecated Use INKMimeHdrFieldStringInsert() instead */
>   inkapi INKReturnCode INKMimeHdrFieldValueInsert(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, const char *value, int length, int idx);
>   /** @deprecated Use INKMimeHdrFieldIntInsert() instead */
>   inkapi INKReturnCode INKMimeHdrFieldValueInsertInt(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int value, int idx);
>   /** @deprecated Use INKMimeHdrFieldUintInsert() instead */
>   inkapi INKReturnCode INKMimeHdrFieldValueInsertUint(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, unsigned int value, int idx);
>   /** @deprecated Use INKMimeHdrFieldDateInsert() instead */
>   inkapi INKReturnCode INKMimeHdrFieldValueInsertDate(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, time_t value, int idx);
>   /** @deprecated Use INKMimeHdrFieldStringGet() instead */
>   inkapi const char *INKMimeHdrFieldValueGet(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx, int *value_len_ptr);
>   /** @deprecated Use INKMimeHdrFieldIntGet() instead */
>   inkapi int INKMimeHdrFieldValueGetInt(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx);
>   /** @deprecated Use INKMimeHdrFieldUintGet() instead */
>   inkapi unsigned int INKMimeHdrFieldValueGetUint(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx);
>   /** @deprecated Use INKMimeHdrFieldDateGet() instead */
>   inkapi time_t INKMimeHdrFieldValueGetDate(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx);
>   /** @deprecated Use INKMimeHdrFieldStringSet() instead */
>   inkapi INKReturnCode INKMimeHdrFieldValueSet(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx, const char *value, int length);
>   /** @deprecated Use INKMimeHdrFieldIntSet() instead */
>   inkapi INKReturnCode INKMimeHdrFieldValueSetInt(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx, int value);
>   /** @deprecated Use INKMimeHdrFieldUintSet() instead */
>   inkapi INKReturnCode INKMimeHdrFieldValueSetUint(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx, unsigned int value);
>   /** @deprecated Use INKMimeHdrFieldDateSet() instead */
>   inkapi INKReturnCode INKMimeHdrFieldValueSetDate(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx, time_t value);
>   /** @deprecated Use INKMimeHdrFieldDestroy() instead */
>   inkapi INKReturnCode INKMimeHdrFieldDelete(INKMBuffer bufp, INKMLoc hdr, INKMLoc field);

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TS-265) Deprecated APIs has misleading (wrong?) comments in ts/ts.h

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848239#action_12848239 ] 

Leif Hedstrom commented on TS-265:
----------------------------------

Looking a little further, these comments might just point to the wrong names ? E.g. where it says to use

     INKMimeHdrFieldIntGet()


I think it means to say use

     INKMimeHdrFieldValueIntGet

> Deprecated APIs has misleading (wrong?) comments in ts/ts.h
> -----------------------------------------------------------
>
>                 Key: TS-265
>                 URL: https://issues.apache.org/jira/browse/TS-265
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: InkAPI
>            Reporter: Leif Hedstrom
>            Priority: Minor
>
> In ts/ts.h, there's a number of APIs marked as deprecated, and suggesting new APIs which I can't seem to find anywhere:
>  // --------------------------------------------------------------------------
>   // Deprecated MIME field functions in SDK3.0
>   /** @deprecated Use INKMimeHdrFieldAppend() instead */
>   inkapi INKReturnCode INKMimeHdrFieldInsert(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx);
>   /** @deprecated Use INKMimeHdrFieldStringInsert() instead */
>   inkapi INKReturnCode INKMimeHdrFieldValueInsert(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, const char *value, int length, int idx);
>   /** @deprecated Use INKMimeHdrFieldIntInsert() instead */
>   inkapi INKReturnCode INKMimeHdrFieldValueInsertInt(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int value, int idx);
>   /** @deprecated Use INKMimeHdrFieldUintInsert() instead */
>   inkapi INKReturnCode INKMimeHdrFieldValueInsertUint(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, unsigned int value, int idx);
>   /** @deprecated Use INKMimeHdrFieldDateInsert() instead */
>   inkapi INKReturnCode INKMimeHdrFieldValueInsertDate(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, time_t value, int idx);
>   /** @deprecated Use INKMimeHdrFieldStringGet() instead */
>   inkapi const char *INKMimeHdrFieldValueGet(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx, int *value_len_ptr);
>   /** @deprecated Use INKMimeHdrFieldIntGet() instead */
>   inkapi int INKMimeHdrFieldValueGetInt(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx);
>   /** @deprecated Use INKMimeHdrFieldUintGet() instead */
>   inkapi unsigned int INKMimeHdrFieldValueGetUint(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx);
>   /** @deprecated Use INKMimeHdrFieldDateGet() instead */
>   inkapi time_t INKMimeHdrFieldValueGetDate(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx);
>   /** @deprecated Use INKMimeHdrFieldStringSet() instead */
>   inkapi INKReturnCode INKMimeHdrFieldValueSet(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx, const char *value, int length);
>   /** @deprecated Use INKMimeHdrFieldIntSet() instead */
>   inkapi INKReturnCode INKMimeHdrFieldValueSetInt(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx, int value);
>   /** @deprecated Use INKMimeHdrFieldUintSet() instead */
>   inkapi INKReturnCode INKMimeHdrFieldValueSetUint(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx, unsigned int value);
>   /** @deprecated Use INKMimeHdrFieldDateSet() instead */
>   inkapi INKReturnCode INKMimeHdrFieldValueSetDate(INKMBuffer bufp, INKMLoc hdr, INKMLoc field, int idx, time_t value);
>   /** @deprecated Use INKMimeHdrFieldDestroy() instead */
>   inkapi INKReturnCode INKMimeHdrFieldDelete(INKMBuffer bufp, INKMLoc hdr, INKMLoc field);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.