You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/07/19 10:49:18 UTC

Review Request 23707: Fix line comments end punctuation in mesos source

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23707/
-----------------------------------------------------------

Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.


Repository: mesos-git


Description
-------

Fix line comments end punctuation in mesos source


Diffs
-----

  src/common/date_utils.cpp 1c7565d261f212d2f53b763ab138ce94034e79d7 
  src/common/factory.hpp 94056f67373cc55acb1da1c2b942b5622773683f 
  src/credentials/credentials.hpp 1790793ae8190fc5986c8dab089e9bdf32d55eb0 
  src/exec/exec.cpp e09ac8d41bc569b624f3866547348fbe1cfbc5ce 
  src/launcher/executor.cpp 7397b653d6f15efe25c9b84feefee15a97fe9763 
  src/launcher/fetcher.cpp 427a2d68274bc0ed5107cbb797dba5377f4bbc94 
  src/master/constants.hpp 2daa9b004ab0cc79773730350369f66315356cad 
  src/master/http.cpp 4fba007bfb9909056dc85f9dc04483994d662740 
  src/master/master.hpp 10bd95abc816c58fc2b72d3ce2d85128333cde39 
  src/master/master.cpp 3ba8c334b38e16f072f59f13c718b2deb48a39f4 
  src/master/registrar.cpp 5c74471d5f61338080ad68cd9a7a6d6346682573 
  src/python/native/mesos_executor_driver_impl.hpp ce0571f6e2769a9c5412b997b1bfab7979d3cbe7 
  src/python/native/mesos_executor_driver_impl.cpp 407d8d13d2fe5030ca799f9d52ca2e791b9ff2fb 
  src/python/native/mesos_scheduler_driver_impl.hpp 772227e40e342e62efd244074c8149d89f9a5343 
  src/python/native/mesos_scheduler_driver_impl.cpp e014eed43ff52979138e06ee14c150625210d6c5 
  src/python/native/module.hpp 1be2e3856e462c8cdc9120cd8817cdef99aa4912 
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.cpp 5e8637e9a2cf65209bf13648b11314ed886e6cdb 
  src/python/native/proxy_scheduler.cpp 95b09cf65dd772719c1dac982522c9aa0b6f9fa7 
  src/slave/containerizer/isolators/network/port_mapping.cpp 03fca2bb59ee26f0036f5ecfb3bba7803a63a2e0 
  src/slave/containerizer/linux_launcher.cpp f3cc813c64e9298f43c9691de9d51ba29c3a8e91 
  src/slave/slave.cpp 6f0e121bc06c3f98c43865c4808496b04aa13f2a 
  src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7 
  src/tests/credentials_tests.cpp c2e2ee7d630f1eb3d47592398a956be8d4044261 
  src/tests/external_containerizer_test.cpp c26f3c262e60733849fbe8fbdc70a49bb55f5fff 
  src/tests/mesos.cpp 35c94fa908ad728ea92a7d1bfcbe90d57b1b83d9 
  src/tests/port_mapping_tests.cpp f1de157620d56b3d49dc391e652e1150a97312ab 
  src/tests/rate_limiting_tests.cpp fc23a1946ad1a78e699552440df2193ea10dc472 
  src/tests/shutdown_tests.cpp ad13aa1a0bdc4d77fa8fe3c52b34a178fdf96e01 
  src/tests/slave_recovery_tests.cpp 9361c45ba70857bed8e189ac93f6502854bcbd25 

Diff: https://reviews.apache.org/r/23707/diff/


Testing
-------

make check


Thanks,

Timothy Chen


Re: Review Request 23707: Fix line comments end punctuation in mesos source

Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23707/#review49331
-----------------------------------------------------------

Ship it!


Ship It!

- Adam B


On July 19, 2014, 1:49 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23707/
> -----------------------------------------------------------
> 
> (Updated July 19, 2014, 1:49 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Fix line comments end punctuation in mesos source
> 
> 
> Diffs
> -----
> 
>   src/common/date_utils.cpp 1c7565d261f212d2f53b763ab138ce94034e79d7 
>   src/common/factory.hpp 94056f67373cc55acb1da1c2b942b5622773683f 
>   src/credentials/credentials.hpp 1790793ae8190fc5986c8dab089e9bdf32d55eb0 
>   src/exec/exec.cpp e09ac8d41bc569b624f3866547348fbe1cfbc5ce 
>   src/launcher/executor.cpp 7397b653d6f15efe25c9b84feefee15a97fe9763 
>   src/launcher/fetcher.cpp 427a2d68274bc0ed5107cbb797dba5377f4bbc94 
>   src/master/constants.hpp 2daa9b004ab0cc79773730350369f66315356cad 
>   src/master/http.cpp 4fba007bfb9909056dc85f9dc04483994d662740 
>   src/master/master.hpp 10bd95abc816c58fc2b72d3ce2d85128333cde39 
>   src/master/master.cpp 3ba8c334b38e16f072f59f13c718b2deb48a39f4 
>   src/master/registrar.cpp 5c74471d5f61338080ad68cd9a7a6d6346682573 
>   src/python/native/mesos_executor_driver_impl.hpp ce0571f6e2769a9c5412b997b1bfab7979d3cbe7 
>   src/python/native/mesos_executor_driver_impl.cpp 407d8d13d2fe5030ca799f9d52ca2e791b9ff2fb 
>   src/python/native/mesos_scheduler_driver_impl.hpp 772227e40e342e62efd244074c8149d89f9a5343 
>   src/python/native/mesos_scheduler_driver_impl.cpp e014eed43ff52979138e06ee14c150625210d6c5 
>   src/python/native/module.hpp 1be2e3856e462c8cdc9120cd8817cdef99aa4912 
>   src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
>   src/python/native/proxy_executor.cpp 5e8637e9a2cf65209bf13648b11314ed886e6cdb 
>   src/python/native/proxy_scheduler.cpp 95b09cf65dd772719c1dac982522c9aa0b6f9fa7 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 03fca2bb59ee26f0036f5ecfb3bba7803a63a2e0 
>   src/slave/containerizer/linux_launcher.cpp f3cc813c64e9298f43c9691de9d51ba29c3a8e91 
>   src/slave/slave.cpp 6f0e121bc06c3f98c43865c4808496b04aa13f2a 
>   src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7 
>   src/tests/credentials_tests.cpp c2e2ee7d630f1eb3d47592398a956be8d4044261 
>   src/tests/external_containerizer_test.cpp c26f3c262e60733849fbe8fbdc70a49bb55f5fff 
>   src/tests/mesos.cpp 35c94fa908ad728ea92a7d1bfcbe90d57b1b83d9 
>   src/tests/port_mapping_tests.cpp f1de157620d56b3d49dc391e652e1150a97312ab 
>   src/tests/rate_limiting_tests.cpp fc23a1946ad1a78e699552440df2193ea10dc472 
>   src/tests/shutdown_tests.cpp ad13aa1a0bdc4d77fa8fe3c52b34a178fdf96e01 
>   src/tests/slave_recovery_tests.cpp 9361c45ba70857bed8e189ac93f6502854bcbd25 
> 
> Diff: https://reviews.apache.org/r/23707/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Re: Review Request 23707: Fix line comments end punctuation in mesos source

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23707/#review48771
-----------------------------------------------------------

Ship it!


Ship It!

- Niklas Nielsen


On July 19, 2014, 1:49 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23707/
> -----------------------------------------------------------
> 
> (Updated July 19, 2014, 1:49 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Fix line comments end punctuation in mesos source
> 
> 
> Diffs
> -----
> 
>   src/common/date_utils.cpp 1c7565d261f212d2f53b763ab138ce94034e79d7 
>   src/common/factory.hpp 94056f67373cc55acb1da1c2b942b5622773683f 
>   src/credentials/credentials.hpp 1790793ae8190fc5986c8dab089e9bdf32d55eb0 
>   src/exec/exec.cpp e09ac8d41bc569b624f3866547348fbe1cfbc5ce 
>   src/launcher/executor.cpp 7397b653d6f15efe25c9b84feefee15a97fe9763 
>   src/launcher/fetcher.cpp 427a2d68274bc0ed5107cbb797dba5377f4bbc94 
>   src/master/constants.hpp 2daa9b004ab0cc79773730350369f66315356cad 
>   src/master/http.cpp 4fba007bfb9909056dc85f9dc04483994d662740 
>   src/master/master.hpp 10bd95abc816c58fc2b72d3ce2d85128333cde39 
>   src/master/master.cpp 3ba8c334b38e16f072f59f13c718b2deb48a39f4 
>   src/master/registrar.cpp 5c74471d5f61338080ad68cd9a7a6d6346682573 
>   src/python/native/mesos_executor_driver_impl.hpp ce0571f6e2769a9c5412b997b1bfab7979d3cbe7 
>   src/python/native/mesos_executor_driver_impl.cpp 407d8d13d2fe5030ca799f9d52ca2e791b9ff2fb 
>   src/python/native/mesos_scheduler_driver_impl.hpp 772227e40e342e62efd244074c8149d89f9a5343 
>   src/python/native/mesos_scheduler_driver_impl.cpp e014eed43ff52979138e06ee14c150625210d6c5 
>   src/python/native/module.hpp 1be2e3856e462c8cdc9120cd8817cdef99aa4912 
>   src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
>   src/python/native/proxy_executor.cpp 5e8637e9a2cf65209bf13648b11314ed886e6cdb 
>   src/python/native/proxy_scheduler.cpp 95b09cf65dd772719c1dac982522c9aa0b6f9fa7 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 03fca2bb59ee26f0036f5ecfb3bba7803a63a2e0 
>   src/slave/containerizer/linux_launcher.cpp f3cc813c64e9298f43c9691de9d51ba29c3a8e91 
>   src/slave/slave.cpp 6f0e121bc06c3f98c43865c4808496b04aa13f2a 
>   src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7 
>   src/tests/credentials_tests.cpp c2e2ee7d630f1eb3d47592398a956be8d4044261 
>   src/tests/external_containerizer_test.cpp c26f3c262e60733849fbe8fbdc70a49bb55f5fff 
>   src/tests/mesos.cpp 35c94fa908ad728ea92a7d1bfcbe90d57b1b83d9 
>   src/tests/port_mapping_tests.cpp f1de157620d56b3d49dc391e652e1150a97312ab 
>   src/tests/rate_limiting_tests.cpp fc23a1946ad1a78e699552440df2193ea10dc472 
>   src/tests/shutdown_tests.cpp ad13aa1a0bdc4d77fa8fe3c52b34a178fdf96e01 
>   src/tests/slave_recovery_tests.cpp 9361c45ba70857bed8e189ac93f6502854bcbd25 
> 
> Diff: https://reviews.apache.org/r/23707/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Re: Review Request 23707: Fix line comments end punctuation in mesos source

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23707/#review48458
-----------------------------------------------------------



src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/23707/#comment85081>

    Does a period really make any sense here at all?



src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/23707/#comment85082>

    Same as above.


- Bernd Mathiske


On July 19, 2014, 1:49 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23707/
> -----------------------------------------------------------
> 
> (Updated July 19, 2014, 1:49 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Fix line comments end punctuation in mesos source
> 
> 
> Diffs
> -----
> 
>   src/common/date_utils.cpp 1c7565d261f212d2f53b763ab138ce94034e79d7 
>   src/common/factory.hpp 94056f67373cc55acb1da1c2b942b5622773683f 
>   src/credentials/credentials.hpp 1790793ae8190fc5986c8dab089e9bdf32d55eb0 
>   src/exec/exec.cpp e09ac8d41bc569b624f3866547348fbe1cfbc5ce 
>   src/launcher/executor.cpp 7397b653d6f15efe25c9b84feefee15a97fe9763 
>   src/launcher/fetcher.cpp 427a2d68274bc0ed5107cbb797dba5377f4bbc94 
>   src/master/constants.hpp 2daa9b004ab0cc79773730350369f66315356cad 
>   src/master/http.cpp 4fba007bfb9909056dc85f9dc04483994d662740 
>   src/master/master.hpp 10bd95abc816c58fc2b72d3ce2d85128333cde39 
>   src/master/master.cpp 3ba8c334b38e16f072f59f13c718b2deb48a39f4 
>   src/master/registrar.cpp 5c74471d5f61338080ad68cd9a7a6d6346682573 
>   src/python/native/mesos_executor_driver_impl.hpp ce0571f6e2769a9c5412b997b1bfab7979d3cbe7 
>   src/python/native/mesos_executor_driver_impl.cpp 407d8d13d2fe5030ca799f9d52ca2e791b9ff2fb 
>   src/python/native/mesos_scheduler_driver_impl.hpp 772227e40e342e62efd244074c8149d89f9a5343 
>   src/python/native/mesos_scheduler_driver_impl.cpp e014eed43ff52979138e06ee14c150625210d6c5 
>   src/python/native/module.hpp 1be2e3856e462c8cdc9120cd8817cdef99aa4912 
>   src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
>   src/python/native/proxy_executor.cpp 5e8637e9a2cf65209bf13648b11314ed886e6cdb 
>   src/python/native/proxy_scheduler.cpp 95b09cf65dd772719c1dac982522c9aa0b6f9fa7 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 03fca2bb59ee26f0036f5ecfb3bba7803a63a2e0 
>   src/slave/containerizer/linux_launcher.cpp f3cc813c64e9298f43c9691de9d51ba29c3a8e91 
>   src/slave/slave.cpp 6f0e121bc06c3f98c43865c4808496b04aa13f2a 
>   src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7 
>   src/tests/credentials_tests.cpp c2e2ee7d630f1eb3d47592398a956be8d4044261 
>   src/tests/external_containerizer_test.cpp c26f3c262e60733849fbe8fbdc70a49bb55f5fff 
>   src/tests/mesos.cpp 35c94fa908ad728ea92a7d1bfcbe90d57b1b83d9 
>   src/tests/port_mapping_tests.cpp f1de157620d56b3d49dc391e652e1150a97312ab 
>   src/tests/rate_limiting_tests.cpp fc23a1946ad1a78e699552440df2193ea10dc472 
>   src/tests/shutdown_tests.cpp ad13aa1a0bdc4d77fa8fe3c52b34a178fdf96e01 
>   src/tests/slave_recovery_tests.cpp 9361c45ba70857bed8e189ac93f6502854bcbd25 
> 
> Diff: https://reviews.apache.org/r/23707/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Re: Review Request 23707: Fix line comments end punctuation in mesos source

Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23707/#review51381
-----------------------------------------------------------

Ship it!


Ship It!

- Adam B


On Aug. 19, 2014, 5:35 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23707/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 5:35 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Review: https://reviews.apache.org/r/23707
> 
> 
> Diffs
> -----
> 
>   src/common/factory.hpp ade05030e551b3608992391dfe36928e91d57ed3 
>   src/exec/exec.cpp 36d177812c7a46b44a4f98c5076353ba1ce28cec 
>   src/launcher/executor.cpp 12ac14bba767b1b52dcf36aca90ba0ce862ad329 
>   src/launcher/fetcher.cpp 50e991840b542e98b1b2870699b45505d4cf75f1 
>   src/linux/routing/filter/handle.hpp 03819338d99f71e24de6e32912b59a7778f6e81b 
>   src/master/constants.hpp ce7995bb3c81dcafd1f9db58defc7f4c200dfeb4 
>   src/master/master.hpp c9f989aa209c1067b60d02cfb4f032afe0f9de4c 
>   src/master/master.cpp 18464baad0864ae890d91097035edf8c49b6f60c 
>   src/master/registrar.cpp 5c74471d5f61338080ad68cd9a7a6d6346682573 
>   src/python/native/src/mesos/native/mesos_executor_driver_impl.hpp 7245414c0edce21be83ef9724f834522f8da065e 
>   src/python/native/src/mesos/native/mesos_executor_driver_impl.cpp 16b9bc1e6e1debed7e1c1ecd6465de00d9e77254 
>   src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 8c285ae7a65b44f4e2a6638e1558aa2da71490dc 
>   src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp e014eed43ff52979138e06ee14c150625210d6c5 
>   src/python/native/src/mesos/native/module.hpp 1c35e2e8897920ba214000939168744daf3b9ff0 
>   src/python/native/src/mesos/native/module.cpp 6d0de5fc2f836d7b88b3793732ede4488853b479 
>   src/python/native/src/mesos/native/proxy_executor.cpp 5e8637e9a2cf65209bf13648b11314ed886e6cdb 
>   src/python/native/src/mesos/native/proxy_scheduler.cpp 95b09cf65dd772719c1dac982522c9aa0b6f9fa7 
>   src/slave/containerizer/composing.cpp 9b36d91118b4af780893c4f27a73e2f0b501582d 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 938782ae2ab1da34eb316381131e9bfcb7c810d1 
>   src/slave/containerizer/linux_launcher.cpp f3cc813c64e9298f43c9691de9d51ba29c3a8e91 
>   src/slave/slave.cpp 6253a5dcde543ff448ad2e710a74892620e3bb87 
>   src/tests/allocator_tests.cpp 774528a61c937b2f6aa9fa3ecc59868070e21860 
>   src/tests/credentials_tests.cpp c2e2ee7d630f1eb3d47592398a956be8d4044261 
>   src/tests/external_containerizer_test.cpp 2f6aa50cf3cbfcb56aab418fedfbfede4418eeb8 
>   src/tests/fault_tolerance_tests.cpp b0e74b94db8a68cd676569d42b2ccd120f12b9d3 
>   src/tests/mesos.cpp 0f759a70b457561bc878fa62b819142a064d5ea4 
>   src/tests/port_mapping_tests.cpp a990da38bd1ff8dcfb6510ed4aa411253020ba20 
>   src/tests/rate_limiting_tests.cpp 4adebd12e8314a4896fb578f3483459c9e57576c 
>   src/tests/shutdown_tests.cpp 12ebef43a1ff339b30329d96d3c00646462ba37e 
>   src/tests/slave_recovery_tests.cpp 357edfc134e825036aeea58ca0b66bb48f3d08e9 
> 
> Diff: https://reviews.apache.org/r/23707/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Re: Review Request 23707: Fix line comments end punctuation in mesos source

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23707/
-----------------------------------------------------------

(Updated Aug. 20, 2014, 12:35 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.


Repository: mesos-git


Description (updated)
-------

Review: https://reviews.apache.org/r/23707


Diffs (updated)
-----

  src/common/factory.hpp ade05030e551b3608992391dfe36928e91d57ed3 
  src/exec/exec.cpp 36d177812c7a46b44a4f98c5076353ba1ce28cec 
  src/launcher/executor.cpp 12ac14bba767b1b52dcf36aca90ba0ce862ad329 
  src/launcher/fetcher.cpp 50e991840b542e98b1b2870699b45505d4cf75f1 
  src/linux/routing/filter/handle.hpp 03819338d99f71e24de6e32912b59a7778f6e81b 
  src/master/constants.hpp ce7995bb3c81dcafd1f9db58defc7f4c200dfeb4 
  src/master/master.hpp c9f989aa209c1067b60d02cfb4f032afe0f9de4c 
  src/master/master.cpp 18464baad0864ae890d91097035edf8c49b6f60c 
  src/master/registrar.cpp 5c74471d5f61338080ad68cd9a7a6d6346682573 
  src/python/native/src/mesos/native/mesos_executor_driver_impl.hpp 7245414c0edce21be83ef9724f834522f8da065e 
  src/python/native/src/mesos/native/mesos_executor_driver_impl.cpp 16b9bc1e6e1debed7e1c1ecd6465de00d9e77254 
  src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 8c285ae7a65b44f4e2a6638e1558aa2da71490dc 
  src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp e014eed43ff52979138e06ee14c150625210d6c5 
  src/python/native/src/mesos/native/module.hpp 1c35e2e8897920ba214000939168744daf3b9ff0 
  src/python/native/src/mesos/native/module.cpp 6d0de5fc2f836d7b88b3793732ede4488853b479 
  src/python/native/src/mesos/native/proxy_executor.cpp 5e8637e9a2cf65209bf13648b11314ed886e6cdb 
  src/python/native/src/mesos/native/proxy_scheduler.cpp 95b09cf65dd772719c1dac982522c9aa0b6f9fa7 
  src/slave/containerizer/composing.cpp 9b36d91118b4af780893c4f27a73e2f0b501582d 
  src/slave/containerizer/isolators/network/port_mapping.cpp 938782ae2ab1da34eb316381131e9bfcb7c810d1 
  src/slave/containerizer/linux_launcher.cpp f3cc813c64e9298f43c9691de9d51ba29c3a8e91 
  src/slave/slave.cpp 6253a5dcde543ff448ad2e710a74892620e3bb87 
  src/tests/allocator_tests.cpp 774528a61c937b2f6aa9fa3ecc59868070e21860 
  src/tests/credentials_tests.cpp c2e2ee7d630f1eb3d47592398a956be8d4044261 
  src/tests/external_containerizer_test.cpp 2f6aa50cf3cbfcb56aab418fedfbfede4418eeb8 
  src/tests/fault_tolerance_tests.cpp b0e74b94db8a68cd676569d42b2ccd120f12b9d3 
  src/tests/mesos.cpp 0f759a70b457561bc878fa62b819142a064d5ea4 
  src/tests/port_mapping_tests.cpp a990da38bd1ff8dcfb6510ed4aa411253020ba20 
  src/tests/rate_limiting_tests.cpp 4adebd12e8314a4896fb578f3483459c9e57576c 
  src/tests/shutdown_tests.cpp 12ebef43a1ff339b30329d96d3c00646462ba37e 
  src/tests/slave_recovery_tests.cpp 357edfc134e825036aeea58ca0b66bb48f3d08e9 

Diff: https://reviews.apache.org/r/23707/diff/


Testing
-------

make check


Thanks,

Timothy Chen