You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/08/17 03:21:53 UTC

[GitHub] [james-project] chibenwa commented on a diff in pull request #1131: [Draft] Split webadmin-http-client in a separate maven module than webadmin-cli

chibenwa commented on code in PR #1131:
URL: https://github.com/apache/james-project/pull/1131#discussion_r947415687


##########
server/pom.xml:
##########
@@ -49,6 +49,7 @@
         <module>apps/scaling-pulsar-smtp</module>
         <module>apps/spring-app</module>
         <module>apps/webadmin-cli</module>
+        <module>apps/webadmin-http-client</module>

Review Comment:
   I would prefer to have it in `server/protocols/webadmin/webadmin-http-client`. After all this is not an application (no Main)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org