[GitHub] [skywalking-eyes] kezhenxu94 commented on a change in pull request #13: Fix strict is not working

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #13:
URL: https://github.com/apache/skywalking-eyes/pull/13#discussion_r548965410



##########
File path: .asf.yaml
##########
@@ -28,3 +28,8 @@ github:
     main:
       required_status_checks:
         strict: true
+        contexts:
+          - build-license-eye
+      required_pull_request_reviews:
+        dismiss_stale_reviews: true
+        required_approving_review_count: 1

Review comment:
       I don't want to enable this in this repo.
   
   https://github.com/apache/skywalking-python/pull/107#discussion_r548336881
   
   We enabled it in the main repo because we faced problem that committer(s) merged the PRs too early, but in these repos where we have limited committers and I think we just leave it as is until we really need, so that some trivial changes can be merged as quickly as possible.

##########
File path: .asf.yaml
##########
@@ -28,3 +28,8 @@ github:
     main:
       required_status_checks:
         strict: true
+        contexts:
+          - build-license-eye

Review comment:
       This is not right




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org