You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Daisuke Kobayashi <da...@cloudera.com> on 2013/02/14 09:54:27 UTC
Review Request: [FLUME-1904] Add 'message' parser in
ElasticSearchLogStashEventSerializer.java
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9441/
-----------------------------------------------------------
Review request for Flume.
Description
-------
In 'appendBody', before adding "@message" field, it should check the headers if there is "message" headers.
This addresses bug FLUME-1904.
https://issues.apache.org/jira/browse/FLUME-1904
Diffs
-----
flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchLogStashEventSerializer.java 3638368
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchLogStashEventSerializer.java 9dff4b0
Diff: https://reviews.apache.org/r/9441/diff/
Testing
-------
Thanks,
Daisuke Kobayashi
Re: Review Request: [FLUME-1904] Add 'message' parser in
ElasticSearchLogStashEventSerializer.java
Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9441/#review16570
-----------------------------------------------------------
Please add a test result
flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchLogStashEventSerializer.java
<https://reviews.apache.org/r/9441/#comment35156>
Please remove the spaces in line 92, 93 and the empty lines 87, 89, 95
- Alexander Alten-Lorenz
On Feb. 14, 2013, 8:54 a.m., Daisuke Kobayashi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9441/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2013, 8:54 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> In 'appendBody', before adding "@message" field, it should check the headers if there is "message" headers.
>
>
> This addresses bug FLUME-1904.
> https://issues.apache.org/jira/browse/FLUME-1904
>
>
> Diffs
> -----
>
> flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchLogStashEventSerializer.java 3638368
> flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchLogStashEventSerializer.java 9dff4b0
>
> Diff: https://reviews.apache.org/r/9441/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daisuke Kobayashi
>
>
Re: Review Request: [FLUME-1904] Add 'message' parser in
ElasticSearchLogStashEventSerializer.java
Posted by Daisuke Kobayashi <da...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9441/
-----------------------------------------------------------
(Updated Feb. 14, 2013, 9:32 a.m.)
Review request for Flume.
Changes
-------
removed the extra spaces and lines
Description
-------
In 'appendBody', before adding "@message" field, it should check the headers if there is "message" headers.
This addresses bug FLUME-1904.
https://issues.apache.org/jira/browse/FLUME-1904
Diffs (updated)
-----
flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchLogStashEventSerializer.java 3638368
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchLogStashEventSerializer.java 9dff4b0
Diff: https://reviews.apache.org/r/9441/diff/
Testing
-------
Thanks,
Daisuke Kobayashi