[GitHub] [sling-org-apache-sling-starter] rombert commented on a change in pull request #59: SLING-11168 - Sling Starter 12: Unable to launch Composum

[GitBox <gi...@apache.org>]

rombert commented on a change in pull request #59:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/59#discussion_r823680920



##########
File path: src/main/features/base.json
##########
@@ -358,6 +358,10 @@
             "user.mapping":[
                 "org.apache.sling.jcr.contentloader=[sling-jcr-content-loader]"
             ]
+        },
+        "org.apache.sling.jcr.contentloader.internal.ContentReaderWhiteboard": {
+            // SLING-11168 - ensure all four ootb readers are started
+            "contentReader.cardinality.minimum": 4

Review comment:
       My understanding is that the contentloader fix is still under review, with an alternate proposal at https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/13 . 
   
   I would suggest that we merge this fix for Starter 12, revert it after the release, and then update to the latest JCR ContentLoader release once we have a fix.
   
   How does that sound?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org