You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <ta...@jakarta.apache.org> on 2005/06/14 20:11:46 UTC

[jira] Created: (TAPESTRY-341) Need better line-precise reporting for listener method

Need better line-precise reporting  for listener method
-------------------------------------------------------

         Key: TAPESTRY-341
         URL: http://issues.apache.org/jira/browse/TAPESTRY-341
     Project: Tapestry
        Type: Bug
  Components: Framework  
    Versions: 4.0    
    Reporter: Howard M. Lewis Ship
    Priority: Minor


When there's a name mismatch between whats in the template/spec and the name of an actual Java method, the error gets associated with the <page-specification>, rather than the <binding> for the listener:


org.apache.hivemind.ApplicationRuntimeException
Object $Home_6@1603522[Home] does not implement a listener method named 'doRegister'.
component: 	$Home_6@1603522[Home]
location: 	context:/WEB-INF/Home.page, line 6, column 21
1	<?xml version="1.0"?>
2	<!DOCTYPE page-specification PUBLIC
3	"-//Apache Software Foundation//Tapestry Specification 4.0//EN"
4	"http://jakarta.apache.org/tapestry/dtd/Tapestry_4_0.dtd">
5	
6	<page-specification>
7	
8	<component id="register" type="DirectLink">
9	<binding name="listener" value="doRegister"/>
10	</component>
11	</page-specification>
Stack Trace:

    * org.apache.tapestry.listener.ListenerMapImpl.createListener(ListenerMapImpl.java:75)
    * org.apache.tapestry.listener.ListenerMapImpl.getListener(ListenerMapImpl.java:63)
    * org.apache.tapestry.binding.ListenerMethodBinding.getObject(ListenerMethodBinding.java:51)
    * org.apache.tapestry.binding.AbstractBinding.getObject(AbstractBinding.java:87)
    * $DirectLink_7.getListener($DirectLink_7.java)
    * org.apache.tapestry.link.DirectLink.trigger(DirectLink.java:100)
    * org.apache.tapestry.engine.DirectService.service(DirectService.java:132)
    * $IEngineService_1047bff3e6d.service($IEngineService_1047bff3e6d.java)


This needs to identify line 9 as the error, not line 6.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org


[jira] Closed: (TAPESTRY-341) Need better line-precise reporting for listener method

Posted by "Howard M. Lewis Ship (JIRA)" <ta...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/TAPESTRY-341?page=all ]
     
Howard M. Lewis Ship closed TAPESTRY-341:
-----------------------------------------

    Fix Version: 4.0
     Resolution: Fixed
      Assign To: Howard M. Lewis Ship

Looks like the status.xml update and commit messages confused this bug with TAPESTRY-307 (I must have gotten a bit confused coding while travelling), but I've confirmed that both bugs are fixed in 4.0-beta-7.

> Need better line-precise reporting  for listener method
> -------------------------------------------------------
>
>          Key: TAPESTRY-341
>          URL: http://issues.apache.org/jira/browse/TAPESTRY-341
>      Project: Tapestry
>         Type: Bug
>   Components: Framework
>     Versions: 4.0
>     Reporter: Howard M. Lewis Ship
>     Assignee: Howard M. Lewis Ship
>     Priority: Minor
>      Fix For: 4.0

>
> When there's a name mismatch between whats in the template/spec and the name of an actual Java method, the error gets associated with the <page-specification>, rather than the <binding> for the listener:
> org.apache.hivemind.ApplicationRuntimeException
> Object $Home_6@1603522[Home] does not implement a listener method named 'doRegister'.
> component: 	$Home_6@1603522[Home]
> location: 	context:/WEB-INF/Home.page, line 6, column 21
> 1	<?xml version="1.0"?>
> 2	<!DOCTYPE page-specification PUBLIC
> 3	"-//Apache Software Foundation//Tapestry Specification 4.0//EN"
> 4	"http://jakarta.apache.org/tapestry/dtd/Tapestry_4_0.dtd">
> 5	
> 6	<page-specification>
> 7	
> 8	<component id="register" type="DirectLink">
> 9	<binding name="listener" value="doRegister"/>
> 10	</component>
> 11	</page-specification>
> Stack Trace:
>     * org.apache.tapestry.listener.ListenerMapImpl.createListener(ListenerMapImpl.java:75)
>     * org.apache.tapestry.listener.ListenerMapImpl.getListener(ListenerMapImpl.java:63)
>     * org.apache.tapestry.binding.ListenerMethodBinding.getObject(ListenerMethodBinding.java:51)
>     * org.apache.tapestry.binding.AbstractBinding.getObject(AbstractBinding.java:87)
>     * $DirectLink_7.getListener($DirectLink_7.java)
>     * org.apache.tapestry.link.DirectLink.trigger(DirectLink.java:100)
>     * org.apache.tapestry.engine.DirectService.service(DirectService.java:132)
>     * $IEngineService_1047bff3e6d.service($IEngineService_1047bff3e6d.java)
> This needs to identify line 9 as the error, not line 6.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org


[jira] Commented: (TAPESTRY-341) Need better line-precise reporting for listener method

Posted by "Andreas Andreou (JIRA)" <ta...@jakarta.apache.org>.
    [ http://issues.apache.org/jira/browse/TAPESTRY-341?page=comments#action_12329618 ] 

Andreas Andreou commented on TAPESTRY-341:
------------------------------------------

In 4.0-beta7, i get both a BindingException (identifying the correct line)
and after that, an ApplicationRuntimeException (showing the line of the page-specification tag).
So this seems to work ok now.

> Need better line-precise reporting  for listener method
> -------------------------------------------------------
>
>          Key: TAPESTRY-341
>          URL: http://issues.apache.org/jira/browse/TAPESTRY-341
>      Project: Tapestry
>         Type: Bug
>   Components: Framework
>     Versions: 4.0
>     Reporter: Howard M. Lewis Ship
>     Priority: Minor

>
> When there's a name mismatch between whats in the template/spec and the name of an actual Java method, the error gets associated with the <page-specification>, rather than the <binding> for the listener:
> org.apache.hivemind.ApplicationRuntimeException
> Object $Home_6@1603522[Home] does not implement a listener method named 'doRegister'.
> component: 	$Home_6@1603522[Home]
> location: 	context:/WEB-INF/Home.page, line 6, column 21
> 1	<?xml version="1.0"?>
> 2	<!DOCTYPE page-specification PUBLIC
> 3	"-//Apache Software Foundation//Tapestry Specification 4.0//EN"
> 4	"http://jakarta.apache.org/tapestry/dtd/Tapestry_4_0.dtd">
> 5	
> 6	<page-specification>
> 7	
> 8	<component id="register" type="DirectLink">
> 9	<binding name="listener" value="doRegister"/>
> 10	</component>
> 11	</page-specification>
> Stack Trace:
>     * org.apache.tapestry.listener.ListenerMapImpl.createListener(ListenerMapImpl.java:75)
>     * org.apache.tapestry.listener.ListenerMapImpl.getListener(ListenerMapImpl.java:63)
>     * org.apache.tapestry.binding.ListenerMethodBinding.getObject(ListenerMethodBinding.java:51)
>     * org.apache.tapestry.binding.AbstractBinding.getObject(AbstractBinding.java:87)
>     * $DirectLink_7.getListener($DirectLink_7.java)
>     * org.apache.tapestry.link.DirectLink.trigger(DirectLink.java:100)
>     * org.apache.tapestry.engine.DirectService.service(DirectService.java:132)
>     * $IEngineService_1047bff3e6d.service($IEngineService_1047bff3e6d.java)
> This needs to identify line 9 as the error, not line 6.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org