Re: [PR] Optimize isOvershadowed when there is a unique minor version for an interval (druid)

["AmatyaAvadhanula (via GitHub)" <gi...@apache.org>]

AmatyaAvadhanula commented on code in PR #15952:
URL: https://github.com/apache/druid/pull/15952#discussion_r1508475810


##########
server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManagerConfig.java:
##########
@@ -31,6 +31,9 @@ public class SegmentsMetadataManagerConfig
   @JsonProperty
   private Period pollDuration = new Period("PT1M");
 
+  @JsonProperty
+  private boolean useFindFullyOvershadowed;

Review Comment:
   I've tried out the alternative with benchmarks. It's simpler and seems very effective.
   Could you please share your thoughts?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org