You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@teaclave.apache.org by Qinkun Bao <no...@github.com.INVALID> on 2022/01/30 20:06:22 UTC

[apache/incubator-teaclave] Support optional input/output files (PR #603)

## Description
This PR introduces optional input/output files.
For some tasks in biometric computing, the number of input/output files varies case by case. Therefore, this PR adds a new feature called optional files. Once a file is marked with `option: True`, users do not need to register the files before creating tasks. The C, Python, Rust SDKs have been updated accordingly.


Fixes # (issue)

## Type of change (select or add applied and delete the others)

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] API change with a documentation update
- [ ] Additional test coverage
- [ ] Code cleanup or just sync with upstream third-party crates

## How has this been tested?

## Checklist

- [x] Fork the repo and create your branch from `master`.
- [x] If you&#39;ve added code that should be tested, add tests.
- [x] If you&#39;ve changed APIs, update the documentation.
- [x] Ensure the tests pass (see CI results).
- [x] Make sure your code lints/format.

You can view, comment on, or merge this pull request online at:

  https://github.com/apache/incubator-teaclave/pull/603

-- Commit Summary --

  * Support optional input/output files

-- File Changes --

    M cmake/scripts/test.sh (1)
    M examples/c/builtin_ordered_set_intersect.c (8)
    A examples/python/mesapy_optional_files.py (113)
    A examples/python/mesapy_optional_files_payload.py (27)
    M examples/rust/builtin_ordered_set_intersect/src/main.rs (8)
    M sdk/python/teaclave.py (8)
    M services/management/enclave/src/service.rs (16)
    M services/proto/src/proto/teaclave_frontend_service.proto (6)
    M services/proto/src/teaclave_frontend_service.rs (4)
    M tests/functional/enclave/src/end_to_end/builtin_gbdt_train.rs (4)
    M tests/functional/enclave/src/end_to_end/mesapy_data_fusion.rs (8)
    M tests/functional/enclave/src/management_service.rs (24)
    M types/src/function.rs (8)
    M types/src/lib.rs (2)
    M types/src/task_state.rs (21)

-- Patch Links --

https://github.com/apache/incubator-teaclave/pull/603.patch
https://github.com/apache/incubator-teaclave/pull/603.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/603
You are receiving this because you are subscribed to this thread.

Message ID: &lt;apache/incubator-teaclave/pull/603@github.com&gt;

Re: [apache/incubator-teaclave] Support optional input/output files (PR #603)

Posted by Qinkun Bao <no...@github.com.INVALID>.

> Please rebase to the latest master for CI checking.

Done.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/603#issuecomment-1028618579
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/incubator-teaclave] Support optional input/output files (PR #603)

Posted by Mingshen Sun <no...@github.com.INVALID>.

Please rebase to the latest master for CI checking.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/603#issuecomment-1028614263
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/incubator-teaclave] Support optional input/output files (PR #603)

Posted by Mingshen Sun <no...@github.com.INVALID>.

Merged #603 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/603#event-6007449591
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>