You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2017/01/04 16:31:59 UTC
[GitHub] storm pull request #1853: STORM-2264 OpaqueTridentKafkaSpout failing after S...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1853
STORM-2264 OpaqueTridentKafkaSpout failing after STORM-2216
* use JSONValue.parse() instead of JSONValue.parseWithException() in TransactionState
* this just rolls back to previous, doesn't provide better approach
Please note that this is just a quick and dirty fix given that the priority of STORM-2264 is critical.
Even after merging this, we should find better solution and apply soon. (#1844 is one of)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-2264
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1853.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1853
----
commit 71269e411bec714f4844790831200dda25d0241b
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2017-01-04T16:24:25Z
STORM-2264 OpaqueTridentKafkaSpout failing after STORM-2216
* use JSONValue.parse() instead of JSONValue.parseWithException() in TransactionState
* this just rolls back to previous, doesn't provide better approach
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1853: STORM-2264 OpaqueTridentKafkaSpout failing after S...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1853
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1853: STORM-2264 OpaqueTridentKafkaSpout failing after STORM-22...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1853
@revans2 I think the direction of STORM-2216 is right, and we just found a spot which is not trivial to fix to the right way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1853: STORM-2264 OpaqueTridentKafkaSpout failing after STORM-22...
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1853
+1
@HeartSaVioR [STORM-2265](https://github.com/apache/storm/pull/1844) is a duplicate of this that I found independently. We can go ahead and merge this (revert) fix. We can keep STORM-2265 open to track a more solid way to address this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1853: STORM-2264 OpaqueTridentKafkaSpout failing after STORM-22...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1853
+1 seems fine to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1853: STORM-2264 OpaqueTridentKafkaSpout failing after STORM-22...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1853
I am also OK with reverting STORM-2216 if it is causing a lot of issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1853: STORM-2264 OpaqueTridentKafkaSpout failing after STORM-22...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1853
@revans2 Could you please take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---