[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #5006: fix(sec): upgrade com.google.guava:guava to 30.0-jre

[GitBox <gi...@apache.org>]

ashutoshcipher commented on code in PR #5006:
URL: https://github.com/apache/hadoop/pull/5006#discussion_r993560833


##########
hadoop-project/pom.xml:
##########
@@ -2586,4 +2582,4 @@
   <repositories>
 
   </repositories>
-</project>
+</project>

Review Comment:
   This can be reverted too.



##########
hadoop-project/pom.xml:
##########
@@ -11,11 +11,7 @@
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   See the License for the specific language governing permissions and
   limitations under the License. See accompanying LICENSE file.
--->
-<project xmlns="http://maven.apache.org/POM/4.0.0"
-  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
-                      https://maven.apache.org/xsd/maven-4.0.0.xsd">
+--><project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0                       https://maven.apache.org/xsd/maven-4.0.0.xsd">

Review Comment:
   Can please you revert and keep original?  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org