You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2025/02/05 00:06:00 UTC
[jira] [Commented] (TINKERPOP-3038) Console plugins file can't accept empty lines
[ https://issues.apache.org/jira/browse/TINKERPOP-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923868#comment-17923868 ]
ASF GitHub Bot commented on TINKERPOP-3038:
-------------------------------------------
kenhuuu commented on code in PR #3003:
URL: https://github.com/apache/tinkerpop/pull/3003#discussion_r1942072845
##########
CHANGELOG.asciidoc:
##########
@@ -31,6 +31,7 @@ image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
* Changed Gremlin grammar to make use of `g` to spawn child traversals a syntax error.
* Added `unexpected-response` handler to `ws` for `gremlin-javascript`
* Fixed bug in `TinkerTransactionGraph` where a read-only transaction may leave elements trapped in a "zombie transaction".
+* Changed console to consider typos and empty lines in plugins.txt by skipping over or clarifying as invalid.
Review Comment:
```suggestion
* Fixed issue in `gremlin-console` where it couldn't accept plugin files that included empty lines or invalid plugin names.
```
Explain what was fixed, not how it was fixed since this is a user facing file.
> Console plugins file can't accept empty lines
> ---------------------------------------------
>
> Key: TINKERPOP-3038
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3038
> Project: TinkerPop
> Issue Type: Bug
> Components: console
> Affects Versions: 3.6.6, 3.7.1
> Reporter: Ken Hu
> Priority: Trivial
>
> As reported in https://groups.google.com/g/gremlin-users/c/U2gIxmRcrI8/m/WzX3eyhTAAAJ
> An empty line in the plugins.txt file will cause a NPE to occur.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)