You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/14 08:23:48 UTC

[GitHub] [flink] xuyangzhong opened a new pull request, #19470: [FLINK-27247][table-planner] ScalarOperatorGens.numericCasting is not compatible with legacy behavior

xuyangzhong opened a new pull request, #19470:
URL: https://github.com/apache/flink/pull/19470

   ## What is the purpose of the change
   
   In [FLINK-24779], some logics are lost in ScalarOperatorGens.numericCasting. This pr aims to add the lost code in it.
   
   ## Brief change log
     - Check if casting is unnecessary first before applying casting rules in numericCasting
     - Add some tests to verify this pr
   
   ## Verifying this change
   
   Some test cases are added to verify it.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: (no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] twalthr closed pull request #19470: [FLINK-27247][table-planner] ScalarOperatorGens.numericCasting is not compatible with legacy behavior

Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #19470: [FLINK-27247][table-planner] ScalarOperatorGens.numericCasting is not compatible with legacy behavior
URL: https://github.com/apache/flink/pull/19470


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] matriv commented on pull request #19470: [FLINK-27247][table-planner] ScalarOperatorGens.numericCasting is not compatible with legacy behavior

Posted by GitBox <gi...@apache.org>.
matriv commented on PR #19470:
URL: https://github.com/apache/flink/pull/19470#issuecomment-1102526615

   @xuyangzhong Opened https://issues.apache.org/jira/browse/FLINK-27312 to address this issue in a nice way, and avoid introducing cast under the hood in during code generation.
   
   We can proceed with this fix as is for the time being. thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] matriv commented on pull request #19470: [FLINK-27247][table-planner] ScalarOperatorGens.numericCasting is not compatible with legacy behavior

Posted by GitBox <gi...@apache.org>.
matriv commented on PR #19470:
URL: https://github.com/apache/flink/pull/19470#issuecomment-1099220412

   I think the solution should be on a different level, where the implicit cast is introduced, so we should cast from a `DOUBLE` to a `DOUBLE NOT NULL`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] flinkbot commented on pull request #19470: [FLINK-27247][table-planner] ScalarOperatorGens.numericCasting is not compatible with legacy behavior

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19470:
URL: https://github.com/apache/flink/pull/19470#issuecomment-1098851865

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "aa1dfaa3fc1ddecaa686b72d0669b31005ace8e0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "aa1dfaa3fc1ddecaa686b72d0669b31005ace8e0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * aa1dfaa3fc1ddecaa686b72d0669b31005ace8e0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] xuyangzhong commented on pull request #19470: [FLINK-27247][table-planner] ScalarOperatorGens.numericCasting is not compatible with legacy behavior

Posted by GitBox <gi...@apache.org>.
xuyangzhong commented on PR #19470:
URL: https://github.com/apache/flink/pull/19470#issuecomment-1103435404

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org