You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@rocketmq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/06 15:41:41 UTC
[jira] [Commented] (ROCKETMQ-166) onException callback may capture
compressed message body
[ https://issues.apache.org/jira/browse/ROCKETMQ-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959125#comment-15959125 ]
ASF GitHub Bot commented on ROCKETMQ-166:
-----------------------------------------
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/89
[ROCKETMQ-166] onException callback may capture compressed message body
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-166
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/89.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #89
----
commit 638a692b9540f31768b76d43936a3ca277138ae1
Author: Zhanhui Li <li...@apache.org>
Date: 2017-04-06T15:39:33Z
Fix ROCKETMQ-166
----
> onException callback may capture compressed message body
> --------------------------------------------------------
>
> Key: ROCKETMQ-166
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-166
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-client
> Affects Versions: 4.0.0-incubating, 4.1.0-incubating
> Reporter: Zhanhui Li
> Assignee: Zhanhui Li
> Fix For: 4.1.0-incubating
>
>
> If message body size exceeds specified threshold, client would try to compress the message body.
> Here there are two issues: 1) current implementation changes message body directly, which is not a good practice; 2) if asynchronous send method is employed to deliver message, when onException is invoked, the callback may capture the compressed message body before the finally block restores it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)