You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/05/12 10:48:07 UTC

[GitHub] [couchdb-helm] colearendt commented on a diff in pull request #75: ingress.ingressClassName added

colearendt commented on code in PR #75:
URL: https://github.com/apache/couchdb-helm/pull/75#discussion_r871234012


##########
couchdb/templates/ingress.yaml:
##########
@@ -16,6 +16,9 @@ metadata:
       {{ $key }}: {{ $value | quote }}
     {{- end }}
 spec:
+  {{- if .Values.ingress.ingressClassName }}
+  ingressClassName: {{ .Values.ingress.ingressClassName }}

Review Comment:
   Not sure what the authors prefer, but I personally am preferential towards `ingress.className` instead of `ingress.ingressClassName` 🤷‍♂️ Helm has an interesting tradeoff between "namespacing" and "using what Kubernetes does verbatim"
   
   Example:
   https://github.com/colearendt/helm/blob/56bc0a48b13005b250b387d27e94d79dc96eb48f/charts/generic/values.yaml#L63



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org