You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sumit Mohanty <sm...@hortonworks.com> on 2016/04/11 06:27:33 UTC
Review Request 46000: Parallel execution should only be allowed on
commands that have auto retry enabled
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46000/
-----------------------------------------------------------
Review request for Ambari, Sandor Magyari and Sebastian Toader.
Bugs: AMBARI-15795
https://issues.apache.org/jira/browse/AMBARI-15795
Repository: ambari
Description
-------
Parallel execution should only be allowed on commands that have auto retry enabled
Diffs
-----
ambari-agent/src/main/python/ambari_agent/ActionQueue.py 4d4103e
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 466c3a8
Diff: https://reviews.apache.org/r/46000/diff/
Testing
-------
mvn test against ambari-agent passed. New unit tests added.
Thanks,
Sumit Mohanty
Re: Review Request 46000: Parallel execution should only be allowed on
commands that have auto retry enabled
Posted by Sandor Magyari <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46000/#review128086
-----------------------------------------------------------
Ship it!
Ship It!
- Sandor Magyari
On April 11, 2016, 4:27 a.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46000/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 4:27 a.m.)
>
>
> Review request for Ambari, Sandor Magyari and Sebastian Toader.
>
>
> Bugs: AMBARI-15795
> https://issues.apache.org/jira/browse/AMBARI-15795
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Parallel execution should only be allowed on commands that have auto retry enabled
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py 4d4103e
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 466c3a8
>
> Diff: https://reviews.apache.org/r/46000/diff/
>
>
> Testing
> -------
>
> mvn test against ambari-agent passed. New unit tests added.
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 46000: Parallel execution should only be allowed on
commands that have auto retry enabled
Posted by Sumit Mohanty <sm...@hortonworks.com>.
> On April 11, 2016, 6:32 p.m., Alejandro Fernandez wrote:
> > ambari-agent/src/main/python/ambari_agent/ActionQueue.py, line 163
> > <https://reviews.apache.org/r/46000/diff/1/?file=1338572#file1338572line163>
> >
> > What was failing because of these multiple threads?
Parallel start/stop of components.
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46000/#review128196
-----------------------------------------------------------
On April 11, 2016, 4:27 a.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46000/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 4:27 a.m.)
>
>
> Review request for Ambari, Sandor Magyari and Sebastian Toader.
>
>
> Bugs: AMBARI-15795
> https://issues.apache.org/jira/browse/AMBARI-15795
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Parallel execution should only be allowed on commands that have auto retry enabled
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py 4d4103e
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 466c3a8
>
> Diff: https://reviews.apache.org/r/46000/diff/
>
>
> Testing
> -------
>
> mvn test against ambari-agent passed. New unit tests added.
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 46000: Parallel execution should only be allowed on
commands that have auto retry enabled
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46000/#review128196
-----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/ActionQueue.py (line 163)
<https://reviews.apache.org/r/46000/#comment191584>
What was failing because of these multiple threads?
- Alejandro Fernandez
On April 11, 2016, 4:27 a.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46000/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 4:27 a.m.)
>
>
> Review request for Ambari, Sandor Magyari and Sebastian Toader.
>
>
> Bugs: AMBARI-15795
> https://issues.apache.org/jira/browse/AMBARI-15795
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Parallel execution should only be allowed on commands that have auto retry enabled
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py 4d4103e
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 466c3a8
>
> Diff: https://reviews.apache.org/r/46000/diff/
>
>
> Testing
> -------
>
> mvn test against ambari-agent passed. New unit tests added.
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 46000: Parallel execution should only be allowed on
commands that have auto retry enabled
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46000/#review128088
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On April 11, 2016, 6:27 a.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46000/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 6:27 a.m.)
>
>
> Review request for Ambari, Sandor Magyari and Sebastian Toader.
>
>
> Bugs: AMBARI-15795
> https://issues.apache.org/jira/browse/AMBARI-15795
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Parallel execution should only be allowed on commands that have auto retry enabled
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py 4d4103e
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 466c3a8
>
> Diff: https://reviews.apache.org/r/46000/diff/
>
>
> Testing
> -------
>
> mvn test against ambari-agent passed. New unit tests added.
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 46000: Parallel execution should only be allowed on
commands that have auto retry enabled
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46000/#review128280
-----------------------------------------------------------
Ship it!
Ship It!
- Mahadev Konar
On April 11, 2016, 4:27 a.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46000/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 4:27 a.m.)
>
>
> Review request for Ambari, Sandor Magyari and Sebastian Toader.
>
>
> Bugs: AMBARI-15795
> https://issues.apache.org/jira/browse/AMBARI-15795
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Parallel execution should only be allowed on commands that have auto retry enabled
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py 4d4103e
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 466c3a8
>
> Diff: https://reviews.apache.org/r/46000/diff/
>
>
> Testing
> -------
>
> mvn test against ambari-agent passed. New unit tests added.
>
>
> Thanks,
>
> Sumit Mohanty
>
>