[GitHub] [spark] gatorsmile commented on a change in pull request #26361: [SPARK-29630][SQL] Disallow creating a permanent view that references a temporary view in an expression

[GitBox <gi...@apache.org>]

gatorsmile commented on a change in pull request #26361: [SPARK-29630][SQL] Disallow creating a permanent view that references a temporary view in an expression
URL: https://github.com/apache/spark/pull/26361#discussion_r361771355
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/create_view.sql.out
 ##########
 @@ -803,61 +806,77 @@ Not allowed to create a permanent view `temporal4` by referencing a temporary vi
 
 
 -- !query 71
-CREATE TABLE tbl1 ( a int, b int) using parquet
+CREATE VIEW temporal5 AS SELECT * FROM t1 WHERE num IN (SELECT num FROM t1 WHERE EXISTS (SELECT 1 FROM tt))
 -- !query 71 schema
 struct<>
 -- !query 71 output
-
+org.apache.spark.sql.AnalysisException
+Not allowed to create a permanent view `temporal5` by referencing a temporary view `tt`;
 
 Review comment:
   I think we should also provide the workaround in the error message. Instead just telling the users temp views are not allowed, we can say users can use permanent views in these cases?
   
   cc @imback82 @cloud-fan 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org