[jira] (MRELEASE-358) CheckDependencySnapshotsPhase fails when resolving all dependencies

["Robert Scholte (JIRA)" <ji...@codehaus.org>]

    [ https://jira.codehaus.org/browse/MRELEASE-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=294149#comment-294149 ] 

Robert Scholte commented on MRELEASE-358:
-----------------------------------------

The patch is not complete, it's missing the unversioned files. The code has changed quite a lot since this issue was filed, so I can't say it's fixed by only looking at the patch. 
@Rich, could you confirm this is fixed? Otherwise attach the test with the missing files.
If there's no response I'll have to close it as {{incomplete}}.
                
> CheckDependencySnapshotsPhase fails when resolving all dependencies
> -------------------------------------------------------------------
>
>                 Key: MRELEASE-358
>                 URL: https://jira.codehaus.org/browse/MRELEASE-358
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: prepare
>    Affects Versions: 2.0-beta-7
>            Reporter: Rich Seller
>         Attachments: patch.txt
>
>
> In CheckDependencySnapshotsPhase, if '0' (All) is selected in response to the prompt "specify the selection number ..." the dependencies are not removed from the original set, so a ReleaseFailureException is thrown at the end of checkProject().
> In the attached patch the dependencies are removed from the original set, and the snapshotSet is returned from resolveSnapshots() to be checked in checkProject().
> In the tests, I implemented a custom Prompter because I don't know how to set multiple conditional responses on JMock1 mocks.
> One other change made while testing: in processSnapshot, "What is the next development version?" is set with a singleton list so a different value has been entered. I removed the list to make the supplied value the default but allow different responses. I can raise this as a separate issue if required

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira