You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/11/07 09:59:10 UTC
[GitHub] [apisix-java-plugin-runner] OrezzerO opened a new pull request, #213: Improve quick start document
OrezzerO opened a new pull request, #213:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/213
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [x] Improve document
* The quick start document is out of date. For example : the PluginFilter's signature and jre version.
* Add a guide to remote debug with Java plugin in docker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass merged pull request #213: docs: improve quick start document
Posted by GitBox <gi...@apache.org>.
tzssangglass merged PR #213:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a diff in pull request #213: docs: improve quick start document
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on code in PR #213:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/213#discussion_r1016626742
##########
docs/zh/quick-start.md:
##########
@@ -48,18 +45,17 @@ apisix-java-plugin-runner 与 APISIX 用 `Unix Domain Socket` 进行进程间通
构建完成，你会在 `dist` 目录看见构建产物
```
-apache-apisix-java-plugin-runner-0.1.0-bin.tar.gz
+apache-apisix-java-plugin-runner-${your_plugin_version}-bin.tar.gz
```
在`dist`目录添加`Dockerfile`文件
```dockerfile
-FROM apache/apisix:${version}-alpine
-
-RUN sed -i "s/dl-cdn.alpinelinux.org/mirrors.aliyun.com/g" /etc/apk/repositories && apk add --no-cache openjdk8-jre
+FROM apache/apisix:${version}-debian
-ADD apache-apisix-java-plugin-runner-0.1.0-bin.tar.gz /usr/local/
+RUN apt -y install openjdk-11-jdk
Review Comment:
could we use the base image with jdk 11?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] OrezzerO commented on a diff in pull request #213: docs: improve quick start document
Posted by GitBox <gi...@apache.org>.
OrezzerO commented on code in PR #213:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/213#discussion_r1017361227
##########
docs/zh/quick-start.md:
##########
@@ -48,18 +45,17 @@ apisix-java-plugin-runner 与 APISIX 用 `Unix Domain Socket` 进行进程间通
构建完成，你会在 `dist` 目录看见构建产物
```
-apache-apisix-java-plugin-runner-0.1.0-bin.tar.gz
+apache-apisix-java-plugin-runner-${your_plugin_version}-bin.tar.gz
```
在`dist`目录添加`Dockerfile`文件
```dockerfile
-FROM apache/apisix:${version}-alpine
-
-RUN sed -i "s/dl-cdn.alpinelinux.org/mirrors.aliyun.com/g" /etc/apk/repositories && apk add --no-cache openjdk8-jre
+FROM apache/apisix:${version}-debian
-ADD apache-apisix-java-plugin-runner-0.1.0-bin.tar.gz /usr/local/
+RUN apt -y install openjdk-11-jdk
Review Comment:
I use the image of apisix , and jdk should in the same image. If i use the base image with jdk , I have to install apisix .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #213: docs: improve quick start document
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on PR #213:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/213#issuecomment-1308297976
@OrezzerO merged, many thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org