[GitHub] [iceberg] danielcweeks commented on a diff in pull request #7487: Core: Add FileIO cache for REST catalog

["danielcweeks (via GitHub)" <gi...@apache.org>]

danielcweeks commented on code in PR #7487:
URL: https://github.com/apache/iceberg/pull/7487#discussion_r1182843224


##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -874,4 +874,17 @@ private static Cache<String, AuthSession> newSessionCache(Map<String, String> pr
             (RemovalListener<String, AuthSession>) (id, auth, cause) -> auth.stopRefreshing())
         .build();
   }
+
+  private Cache<TableIdentifier, FileIO> newFileIOCache() {
+    return Caffeine.newBuilder()

Review Comment:
   Probably need to close this when the catalog.close() is called



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org