You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "17krishna8 (via GitHub)" <gi...@apache.org> on 2026/10/17 04:48:29 UTC

Re: [PR] Name the parameter when a websocket pageId is not a number [wicket]

17krishna8 commented on PR #1674:
URL: https://github.com/apache/wicket/pull/1674#issuecomment-6229813321

   Thanks for walking me through what actually happens after the constructor - I had stopped too early. I did not know about `WebSocketResourcePage`.
   
   I have reworked the change: the handshake still fails when `pageId` is not a number, but the constructor now throws `IllegalArgumentException("Request parameter 'pageId' must be a number")` instead of the bare `NumberFormatException`, and the test asserts the message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org