[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3701: Allow ACCUMULO_JAVA_PREFIX to be an array

["ctubbsii (via GitHub)" <gi...@apache.org>]

ctubbsii commented on code in PR #3701:
URL: https://github.com/apache/accumulo/pull/3701#discussion_r1296390606


##########
assemble/conf/accumulo-env.sh:
##########
@@ -142,5 +142,10 @@ esac
 # Variables that are optional. Uncomment to set
 ###############################################
 
-## Specifies command that will be placed before calls to Java in accumulo script
-# export ACCUMULO_JAVA_PREFIX=""
+## ACCUMULO_JAVA_PREFIX can be used to specify commands to prepend to the "java"
+## command when it is executed. This can be declared as either a scalar or an
+## array variable. The following use of declare to check if it's already set is
+## not strictly necessary, but ensures that if you set it in the calling
+## environment, that will override what is set here, rather than some mangled
+## merged result. You can set the variable any way you like.
+#declare -p 'ACCUMULO_JAVA_PREFIX' &>/dev/null || ACCUMULO_JAVA_PREFIX=''

Review Comment:
   I feel like if somebody is editing a bash script and doesn't know bash, they can Google that... I don't think we need to be teaching bash inside our config file. It's already quite verbose in there, and there are already other examples of setting scalar and array variables inside the same file, as `var=(a b c)` and `var='abc'`, so I don't think it's really necessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org