You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Thorsten Scherler (JIRA)" <ji...@apache.org> on 2006/01/28 19:50:32 UTC

[jira] Created: (FOR-799) remove all references from core the core to the dispatcher

remove all references from core the core to the dispatcher
----------------------------------------------------------

         Key: FOR-799
         URL: http://issues.apache.org/jira/browse/FOR-799
     Project: Forrest
        Type: Sub-task
  Components: Core operations, Dispatcher (aka views)  
    Reporter: Thorsten Scherler


They should be no direct references in the core for the dispatcher.

This should be done with the new plugin system forrest.properties.xml.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (FOR-799) remove all references from the core to the dispatcher

Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-799?page=comments#action_12364453 ] 

Ross Gardler commented on FOR-799:
----------------------------------

wow, even more confusing, not core, or the theme.core plugin but forrest-core.xconf, one tiny word, so many meanings ;-)

I get it now though, I may get some time to look at the dispatcher around the end of the week. If someone gets to this issue before me then an example of how to do this is in the Daisy plugin.

Basically just add a default.plugin.properties.xml file with all the necessary values in it, for example:

http://svn.apache.org/viewcvs.cgi/forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.input.Daisy/default.plugin.properties.xml?view=markup

You'll need to remove the correcponding entries from forrest.properties as well.

There is no need to change forrest.xconf or the sitemap as the new system is only on the input side, not the usage side, in other words there are no changes to the way we use properties.

Individual projects can then override any of the values in their own forrest.properties.xml file (oe even locl.forest.properties.xml)

For more info on the new properties system see FOR-588

> remove all references from the core to the dispatcher
> -----------------------------------------------------
>
>          Key: FOR-799
>          URL: http://issues.apache.org/jira/browse/FOR-799
>      Project: Forrest
>         Type: Sub-task
>   Components: Core operations, Dispatcher (aka views)
>     Reporter: Thorsten Scherler

>
> They should be no direct references in the core for the dispatcher.
> This should be done with the new plugin system forrest.properties.xml.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (FOR-799) remove all references from the core to the dispatcher

Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-799?page=comments#action_12364446 ] 

Ross Gardler commented on FOR-799:
----------------------------------

I don't understand this issue. Can you provide an example of the kind of direct reference you mean. 

What do you mean by core, the "*.themes.core" plugin or forrest core - Mr. Confusion is back ;-)



> remove all references from the core to the dispatcher
> -----------------------------------------------------
>
>          Key: FOR-799
>          URL: http://issues.apache.org/jira/browse/FOR-799
>      Project: Forrest
>         Type: Sub-task
>   Components: Core operations, Dispatcher (aka views)
>     Reporter: Thorsten Scherler

>
> They should be no direct references in the core for the dispatcher.
> This should be done with the new plugin system forrest.properties.xml.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Commented: (FOR-799) remove all references from the core to the dispatcher

Posted by Thorsten Scherler <th...@wyona.com>.
El mié, 09-08-2006 a las 01:29 +0200, Thorsten Scherler escribió:
> El mar, 08-08-2006 a las 06:15 -0700, Cyriaque Dupoirieux (JIRA)
> escribió:
> >     [ http://issues.apache.org/jira/browse/FOR-799?page=comments#action_12426562 ] 
> >             
> > Cyriaque Dupoirieux commented on FOR-799:
> > -----------------------------------------
> > 
> > What about the $FORREST_HOME/main/webapp/resources/stylesheets/variable.helper.xsl file ?
> > It is referenced in the locationmap-transforms.xml (main/webapp) and is not used but by the dispatcher.
> > 
> > Shouldn't we move it to $FORREST_HOME/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/resources/stylesheets/helper
> > And reference it in locationmap of the dispatcher.
> > 
> > (If Ok, I'll do it)
> 
> I have done this. 
> 
> Thanks Cyriaque for the feedback.

One thing more, till now we have foo.xml as generated file. We have to
change this to cocoon://module.project.properties. Then we need to copy
the returned properties into the properties again (changing the above
mentioned stylesheet). 

This way all (not yet possible see the forrestConf discussion)
properties are available in the contract. :)

The only thing is that dispatcher then has yet another dependency (yad)
to the  org.apache.forrest.plugin.output.inputModule.

It is time to look into plugin dependencies. The following link may be
interesting because it shows how lenya is handeling module (comparable
to plugins) dependencies.

http://svn.apache.org/viewvc/lenya/trunk/src/targets/modules-build.xml?view=markup

salu2

> 
> salu2
> > 
> > > remove all references from the core to the dispatcher
> > > -----------------------------------------------------
> > >
> > >                 Key: FOR-799
> > >                 URL: http://issues.apache.org/jira/browse/FOR-799
> > >             Project: Forrest
> > >          Issue Type: Sub-task
> > >          Components: Core operations, Dispatcher (aka views)
> > >            Reporter: Thorsten Scherler
> > >
> > > They should be no direct references in the core for the dispatcher.
> > > This should be done with the new plugin system forrest.properties.xml.
> > 
-- 
Thorsten Scherler
COO Spain
Wyona Inc.  -  Open Source Content Management  -  Apache Lenya
http://www.wyona.com                   http://lenya.apache.org
thorsten.scherler@wyona.com                thorsten@apache.org


Re: [jira] Commented: (FOR-799) remove all references from the core to the dispatcher

Posted by Thorsten Scherler <th...@apache.org>.
El mar, 08-08-2006 a las 06:15 -0700, Cyriaque Dupoirieux (JIRA)
escribió:
>     [ http://issues.apache.org/jira/browse/FOR-799?page=comments#action_12426562 ] 
>             
> Cyriaque Dupoirieux commented on FOR-799:
> -----------------------------------------
> 
> What about the $FORREST_HOME/main/webapp/resources/stylesheets/variable.helper.xsl file ?
> It is referenced in the locationmap-transforms.xml (main/webapp) and is not used but by the dispatcher.
> 
> Shouldn't we move it to $FORREST_HOME/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/resources/stylesheets/helper
> And reference it in locationmap of the dispatcher.
> 
> (If Ok, I'll do it)

I have done this. 

Thanks Cyriaque for the feedback.

salu2
> 
> > remove all references from the core to the dispatcher
> > -----------------------------------------------------
> >
> >                 Key: FOR-799
> >                 URL: http://issues.apache.org/jira/browse/FOR-799
> >             Project: Forrest
> >          Issue Type: Sub-task
> >          Components: Core operations, Dispatcher (aka views)
> >            Reporter: Thorsten Scherler
> >
> > They should be no direct references in the core for the dispatcher.
> > This should be done with the new plugin system forrest.properties.xml.
> 
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


[jira] Commented: (FOR-799) remove all references from the core to the dispatcher

Posted by "Cyriaque Dupoirieux (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-799?page=comments#action_12426562 ] 
            
Cyriaque Dupoirieux commented on FOR-799:
-----------------------------------------

What about the $FORREST_HOME/main/webapp/resources/stylesheets/variable.helper.xsl file ?
It is referenced in the locationmap-transforms.xml (main/webapp) and is not used but by the dispatcher.

Shouldn't we move it to $FORREST_HOME/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/resources/stylesheets/helper
And reference it in locationmap of the dispatcher.

(If Ok, I'll do it)

> remove all references from the core to the dispatcher
> -----------------------------------------------------
>
>                 Key: FOR-799
>                 URL: http://issues.apache.org/jira/browse/FOR-799
>             Project: Forrest
>          Issue Type: Sub-task
>          Components: Core operations, Dispatcher (aka views)
>            Reporter: Thorsten Scherler
>
> They should be no direct references in the core for the dispatcher.
> This should be done with the new plugin system forrest.properties.xml.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [HEADSUP] Dispatcher does not support forrest.properties anymore (was [jira] Closed: (FOR-799))

Posted by Cyriaque Dupoirieux <Cy...@pcotech.fr>.
le 03/08/2006 09:21 Cyriaque Dupoirieux a écrit :
> le 03/08/2006 01:47 Thorsten Scherler a écrit :
>> El mié, 02-08-2006 a las 16:32 -0700, Thorsten Scherler (JIRA) escribió:
>>  
>>>      [ http://issues.apache.org/jira/browse/FOR-799?page=all ]
>>>
>>> Thorsten Scherler closed FOR-799.
>>> ---------------------------------
>>>
>>>     Resolution: Fixed
>>>
>>> I removed all properties related to the dispatcher (or former 
>>> versions) from the core. The dispatcher relies now on the new 
>>> properties system and the forrest.properties values does have *NO* 
>>> effect anymore.
>>>
>>>    
>>>> remove all references from the core to the dispatcher
>>>> -----------------------------------------------------
>>>>
>>>>                 Key: FOR-799
>>>>                 URL: http://issues.apache.org/jira/browse/FOR-799
>>>>             Project: Forrest
>>>>          Issue Type: Sub-task
>>>>          Components: Core operations, Dispatcher (aka views)
>>>>            Reporter: Thorsten Scherler
>>>>
>>>> They should be no direct references in the core for the dispatcher.
>>>> This should be done with the new plugin system forrest.properties.xml.
>>>>       
>>
>> http://svn.apache.org/viewvc?rev=428188&view=rev
>>
>> In this commit you can find out how I have updated the basic and
>> fresh-seed site. Basically you need to add forrest.properties.xml to
>> your project looking like
>>
>> +<?xml version="1.0" encoding="UTF-8"?>
>> +<properties>
>> +  <!--
>> +    # codename: Dispatcher
>> +    # Dispatcher is using a fallback mechanism for theming.
>> +    # You can configure the theme name and its extension here
>> +    -->
>> +  <property name="dispatcher.theme" value="pelt"/>
>> +  <property name="dispatcher.theme-ext" value=".fv"/>
>> +</properties>
>>
>> The project.theme and project.theme-ext in forrest.properties does not
>> have any effect anymore.
>>   
> Brilliant !
> What about the project.skin properties that I still have in my 
> forrest.properties files ?
Oups, It's a skin property, sorry,
Cyriaque,

>> Sorry for any inconvenience.   
> No problem, that's the way we should go.
>
> Salutations,
> Cyriaque,
>> salu2
>>   
>
>

Re: [HEADSUP] Dispatcher does not support forrest.properties anymore (was [jira] Closed: (FOR-799))

Posted by Cyriaque Dupoirieux <Cy...@pcotech.fr>.
le 03/08/2006 01:47 Thorsten Scherler a écrit :
> El mié, 02-08-2006 a las 16:32 -0700, Thorsten Scherler (JIRA) escribió:
>   
>>      [ http://issues.apache.org/jira/browse/FOR-799?page=all ]
>>
>> Thorsten Scherler closed FOR-799.
>> ---------------------------------
>>
>>     Resolution: Fixed
>>
>> I removed all properties related to the dispatcher (or former versions) from the core. The dispatcher relies now on the new properties system and the forrest.properties values does have *NO* effect anymore.
>>
>>     
>>> remove all references from the core to the dispatcher
>>> -----------------------------------------------------
>>>
>>>                 Key: FOR-799
>>>                 URL: http://issues.apache.org/jira/browse/FOR-799
>>>             Project: Forrest
>>>          Issue Type: Sub-task
>>>          Components: Core operations, Dispatcher (aka views)
>>>            Reporter: Thorsten Scherler
>>>
>>> They should be no direct references in the core for the dispatcher.
>>> This should be done with the new plugin system forrest.properties.xml.
>>>       
>
> http://svn.apache.org/viewvc?rev=428188&view=rev
>
> In this commit you can find out how I have updated the basic and
> fresh-seed site. Basically you need to add forrest.properties.xml to
> your project looking like
>
> +<?xml version="1.0" encoding="UTF-8"?>
> +<properties>
> +  <!--
> +    # codename: Dispatcher
> +    # Dispatcher is using a fallback mechanism for theming.
> +    # You can configure the theme name and its extension here
> +    -->
> +  <property name="dispatcher.theme" value="pelt"/>
> +  <property name="dispatcher.theme-ext" value=".fv"/>
> +</properties>
>
> The project.theme and project.theme-ext in forrest.properties does not
> have any effect anymore.
>   
Brilliant !
What about the project.skin properties that I still have in my 
forrest.properties files ?
> Sorry for any inconvenience. 
>   
No problem, that's the way we should go.

Salutations,
Cyriaque,
> salu2
>   

[HEADSUP] Dispatcher does not support forrest.properties anymore (was [jira] Closed: (FOR-799))

Posted by Thorsten Scherler <th...@apache.org>.
El mié, 02-08-2006 a las 16:32 -0700, Thorsten Scherler (JIRA) escribió:
>      [ http://issues.apache.org/jira/browse/FOR-799?page=all ]
> 
> Thorsten Scherler closed FOR-799.
> ---------------------------------
> 
>     Resolution: Fixed
> 
> I removed all properties related to the dispatcher (or former versions) from the core. The dispatcher relies now on the new properties system and the forrest.properties values does have *NO* effect anymore.
> 
> > remove all references from the core to the dispatcher
> > -----------------------------------------------------
> >
> >                 Key: FOR-799
> >                 URL: http://issues.apache.org/jira/browse/FOR-799
> >             Project: Forrest
> >          Issue Type: Sub-task
> >          Components: Core operations, Dispatcher (aka views)
> >            Reporter: Thorsten Scherler
> >
> > They should be no direct references in the core for the dispatcher.
> > This should be done with the new plugin system forrest.properties.xml.

http://svn.apache.org/viewvc?rev=428188&view=rev

In this commit you can find out how I have updated the basic and
fresh-seed site. Basically you need to add forrest.properties.xml to
your project looking like

+<?xml version="1.0" encoding="UTF-8"?>
+<properties>
+  <!--
+    # codename: Dispatcher
+    # Dispatcher is using a fallback mechanism for theming.
+    # You can configure the theme name and its extension here
+    -->
+  <property name="dispatcher.theme" value="pelt"/>
+  <property name="dispatcher.theme-ext" value=".fv"/>
+</properties>

The project.theme and project.theme-ext in forrest.properties does not
have any effect anymore.

Sorry for any inconvenience. 

salu2
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


[jira] Closed: (FOR-799) remove all references from the core to the dispatcher

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FOR-799?page=all ]

Thorsten Scherler closed FOR-799.
---------------------------------

    Resolution: Fixed

I removed all properties related to the dispatcher (or former versions) from the core. The dispatcher relies now on the new properties system and the forrest.properties values does have *NO* effect anymore.

> remove all references from the core to the dispatcher
> -----------------------------------------------------
>
>                 Key: FOR-799
>                 URL: http://issues.apache.org/jira/browse/FOR-799
>             Project: Forrest
>          Issue Type: Sub-task
>          Components: Core operations, Dispatcher (aka views)
>            Reporter: Thorsten Scherler
>
> They should be no direct references in the core for the dispatcher.
> This should be done with the new plugin system forrest.properties.xml.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (FOR-799) remove all references from the core to the dispatcher

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-799?page=comments#action_12364449 ] 

Thorsten Scherler commented on FOR-799:
---------------------------------------

No, I mean mainly main/webapp/WEB-INF/xconf/forrest-core.xconf.

I added there heaps of properties that should be removed before the dispatcher will be released.
e.g. 
<theme-ext>.fv</theme-ext>
<themer>@forrest.home@/build/plugins/org.apache.forrest.themes.core</themer>
<structurer>@forrest.home@/build/plugins/org.apache.forrest.plugin.internal.dispatcher</structurer>

All this properties need to go away.

> remove all references from the core to the dispatcher
> -----------------------------------------------------
>
>          Key: FOR-799
>          URL: http://issues.apache.org/jira/browse/FOR-799
>      Project: Forrest
>         Type: Sub-task
>   Components: Core operations, Dispatcher (aka views)
>     Reporter: Thorsten Scherler

>
> They should be no direct references in the core for the dispatcher.
> This should be done with the new plugin system forrest.properties.xml.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (FOR-799) remove all references from the core to the dispatcher

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FOR-799?page=all ]

Thorsten Scherler updated FOR-799:
----------------------------------

    Summary: remove all references from the core to the dispatcher  (was: remove all references from core the core to the dispatcher)

> remove all references from the core to the dispatcher
> -----------------------------------------------------
>
>          Key: FOR-799
>          URL: http://issues.apache.org/jira/browse/FOR-799
>      Project: Forrest
>         Type: Sub-task
>   Components: Core operations, Dispatcher (aka views)
>     Reporter: Thorsten Scherler

>
> They should be no direct references in the core for the dispatcher.
> This should be done with the new plugin system forrest.properties.xml.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira