You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Doug Cutting (JIRA)" <ji...@apache.org> on 2007/03/22 21:14:32 UTC
[jira] Created: (HADOOP-1147) remove all @author tags from source
remove all @author tags from source
-----------------------------------
Key: HADOOP-1147
URL: https://issues.apache.org/jira/browse/HADOOP-1147
Project: Hadoop
Issue Type: Improvement
Reporter: Doug Cutting
Assigned To: Doug Cutting
Priority: Minor
We should remove @author tags from the source code. We give contributors credit in at least three places (Jira, subversion and CHANGES.txt). Many files have been substantially re-written by a range of contributors and their @author tags are no longer accurate. Also, @author tags imply individual ownership, when we should rather strive for community ownership.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (HADOOP-1147) remove all @author tags from
source
Posted by Tahir Hashmi <ta...@yahoo-inc.com>.
Konstantin Shvachko (JIRA) wrote:
> Anonymous code is like public property: nobody cares, nobody takes responsibility. Been there.
I'm not sure how file ownership solves this issue since the file may
have been revised with contributions from many others and the original
author may no longer be contributing. Besides, finding the person who
wrote a particular code snippet is not too difficult -- you follow the
commit message for a snippet and look at the name of the contributor.
OTOH, I've worked with a project with strong code ownership and it leads
to the same issues -- no one cares or takes responsibility for code
written by others. The person who wrote the code almost always falls
back on their task priorities while deciding whether or not to fix it.
--
Tahir Hashmi (Grid Dev)
Y!M: tn_hashmi
http://www.codemartial.org
[jira] Commented: (HADOOP-1147) remove all @author tags from source
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483813 ]
Konstantin Shvachko commented on HADOOP-1147:
---------------------------------------------
It looks like I am in the minority here, but still.
> The code should be anonymous.
Anonymous code is like public property: nobody cares, nobody takes responsibility. Been there.
We are supporting Sun's code convention. They have author field in every file. Even if they don't have an author the field says
@author unascribed
> remove all @author tags from source
> -----------------------------------
>
> Key: HADOOP-1147
> URL: https://issues.apache.org/jira/browse/HADOOP-1147
> Project: Hadoop
> Issue Type: Improvement
> Reporter: Doug Cutting
> Assigned To: Doug Cutting
> Priority: Minor
>
> We should remove @author tags from the source code. We give contributors credit in at least three places (Jira, subversion and CHANGES.txt). Many files have been substantially re-written by a range of contributors and their @author tags are no longer accurate. Also, @author tags imply individual ownership, when we should rather strive for community ownership.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: FW: [jira] Created: (HADOOP-1147) remove all @author tags from
source
Posted by Dennis Kubes <nu...@dragonflymc.com>.
It shouldn't be too much trouble to attack this with the logging changes.
Dennis Kubes
Chris Mattmann wrote:
> Hey Doug,
>
> Do you think we should do this in Nutch too? I'm in favor of doing this --
> what does everyone else feel?
>
> Thanks!
>
> Cheers,
> Chris
>
> ______________________________________________
> Chris A. Mattmann
> Chris.Mattmann@jpl.nasa.gov
> Staff Member
> Modeling and Data Management Systems Section (387)
> Data Management Systems and Technologies Group
>
> _________________________________________________
> Jet Propulsion Laboratory Pasadena, CA
> Office: 171-266B Mailstop: 171-246
> _______________________________________________________
>
> Disclaimer: The opinions presented within are my own and do not reflect
> those of either NASA, JPL, or the California Institute of Technology.
>
> ------ Forwarded Message
> From: "Doug Cutting (JIRA)" <ji...@apache.org>
> Reply-To: <ha...@lucene.apache.org>
> Date: Thu, 22 Mar 2007 13:14:32 -0700 (PDT)
> To: <ha...@lucene.apache.org>
> Subject: [jira] Created: (HADOOP-1147) remove all @author tags from source
>
> remove all @author tags from source
> -----------------------------------
>
> Key: HADOOP-1147
> URL: https://issues.apache.org/jira/browse/HADOOP-1147
> Project: Hadoop
> Issue Type: Improvement
> Reporter: Doug Cutting
> Assigned To: Doug Cutting
> Priority: Minor
>
>
> We should remove @author tags from the source code. We give contributors
> credit in at least three places (Jira, subversion and CHANGES.txt). Many
> files have been substantially re-written by a range of contributors and
> their @author tags are no longer accurate. Also, @author tags imply
> individual ownership, when we should rather strive for community ownership.
>
FW: [jira] Created: (HADOOP-1147) remove all @author tags from
source
Posted by Chris Mattmann <ch...@jpl.nasa.gov>.
Hey Doug,
Do you think we should do this in Nutch too? I'm in favor of doing this --
what does everyone else feel?
Thanks!
Cheers,
Chris
______________________________________________
Chris A. Mattmann
Chris.Mattmann@jpl.nasa.gov
Staff Member
Modeling and Data Management Systems Section (387)
Data Management Systems and Technologies Group
_________________________________________________
Jet Propulsion Laboratory Pasadena, CA
Office: 171-266B Mailstop: 171-246
_______________________________________________________
Disclaimer: The opinions presented within are my own and do not reflect
those of either NASA, JPL, or the California Institute of Technology.
------ Forwarded Message
From: "Doug Cutting (JIRA)" <ji...@apache.org>
Reply-To: <ha...@lucene.apache.org>
Date: Thu, 22 Mar 2007 13:14:32 -0700 (PDT)
To: <ha...@lucene.apache.org>
Subject: [jira] Created: (HADOOP-1147) remove all @author tags from source
remove all @author tags from source
-----------------------------------
Key: HADOOP-1147
URL: https://issues.apache.org/jira/browse/HADOOP-1147
Project: Hadoop
Issue Type: Improvement
Reporter: Doug Cutting
Assigned To: Doug Cutting
Priority: Minor
We should remove @author tags from the source code. We give contributors
credit in at least three places (Jira, subversion and CHANGES.txt). Many
files have been substantially re-written by a range of contributors and
their @author tags are no longer accurate. Also, @author tags imply
individual ownership, when we should rather strive for community ownership.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
------ End of Forwarded Message
Re: [jira] Commented: (HADOOP-1147) remove all @author tags from source
Posted by Nigel Daley <nd...@yahoo-inc.com>.
+1
On Mar 22, 2007, at 5:39 PM, Raghu Angadi (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/HADOOP-1147?
> page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel#action_12483369 ]
>
> Raghu Angadi commented on HADOOP-1147:
> --------------------------------------
>
> +1.
>
>> remove all @author tags from source
>> -----------------------------------
>>
>> Key: HADOOP-1147
>> URL: https://issues.apache.org/jira/browse/
>> HADOOP-1147
>> Project: Hadoop
>> Issue Type: Improvement
>> Reporter: Doug Cutting
>> Assigned To: Doug Cutting
>> Priority: Minor
>>
>> We should remove @author tags from the source code. We give
>> contributors credit in at least three places (Jira, subversion and
>> CHANGES.txt). Many files have been substantially re-written by a
>> range of contributors and their @author tags are no longer
>> accurate. Also, @author tags imply individual ownership, when we
>> should rather strive for community ownership.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Commented: (HADOOP-1147) remove all @author tags from source
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483369 ]
Raghu Angadi commented on HADOOP-1147:
--------------------------------------
+1.
> remove all @author tags from source
> -----------------------------------
>
> Key: HADOOP-1147
> URL: https://issues.apache.org/jira/browse/HADOOP-1147
> Project: Hadoop
> Issue Type: Improvement
> Reporter: Doug Cutting
> Assigned To: Doug Cutting
> Priority: Minor
>
> We should remove @author tags from the source code. We give contributors credit in at least three places (Jira, subversion and CHANGES.txt). Many files have been substantially re-written by a range of contributors and their @author tags are no longer accurate. Also, @author tags imply individual ownership, when we should rather strive for community ownership.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-1147) remove all @author tags from source
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting resolved HADOOP-1147.
----------------------------------
Resolution: Fixed
Fix Version/s: 0.14.0
I just committed this.
> remove all @author tags from source
> -----------------------------------
>
> Key: HADOOP-1147
> URL: https://issues.apache.org/jira/browse/HADOOP-1147
> Project: Hadoop
> Issue Type: Improvement
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Priority: Minor
> Fix For: 0.14.0
>
>
> We should remove @author tags from the source code. We give contributors credit in at least three places (Jira, subversion and CHANGES.txt). Many files have been substantially re-written by a range of contributors and their @author tags are no longer accurate. Also, @author tags imply individual ownership, when we should rather strive for community ownership.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1147) remove all @author tags from source
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483656 ]
Konstantin Shvachko commented on HADOOP-1147:
---------------------------------------------
-1 I consider @author tags not as a recognition of achievements but as a reference to whom I should ask questions about the code.
Removing will essentially make the code anonymous.
I agree the tags should be revised to make them up to date.
+1 for giving contributors credit in three places.
> remove all @author tags from source
> -----------------------------------
>
> Key: HADOOP-1147
> URL: https://issues.apache.org/jira/browse/HADOOP-1147
> Project: Hadoop
> Issue Type: Improvement
> Reporter: Doug Cutting
> Assigned To: Doug Cutting
> Priority: Minor
>
> We should remove @author tags from the source code. We give contributors credit in at least three places (Jira, subversion and CHANGES.txt). Many files have been substantially re-written by a range of contributors and their @author tags are no longer accurate. Also, @author tags imply individual ownership, when we should rather strive for community ownership.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1147) remove all @author tags from source
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483704 ]
Owen O'Malley commented on HADOOP-1147:
---------------------------------------
Subversion also prohibits author names in source files and has formalized the credit messages to make them tool parseable. Subversion is a much larger project, but it is interesting to see what they have done:
http://subversion.tigris.org/hacking.html#crediting
> remove all @author tags from source
> -----------------------------------
>
> Key: HADOOP-1147
> URL: https://issues.apache.org/jira/browse/HADOOP-1147
> Project: Hadoop
> Issue Type: Improvement
> Reporter: Doug Cutting
> Assigned To: Doug Cutting
> Priority: Minor
>
> We should remove @author tags from the source code. We give contributors credit in at least three places (Jira, subversion and CHANGES.txt). Many files have been substantially re-written by a range of contributors and their @author tags are no longer accurate. Also, @author tags imply individual ownership, when we should rather strive for community ownership.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1147) remove all @author tags from source
Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483750 ]
Andrzej Bialecki commented on HADOOP-1147:
-------------------------------------------
Big +1 - I'm familiar with this system from my FreeBSD days as a committer, and it was working very well, it made the commit logs much more useful. FreeBSD went even further - there was a pre-commit script that would check the proper formatting of these comments, and refuse the commit if e.g. Reviewed By: was missing for a particular critical sub-tree, such as kernel source. We could formalize at least the format of Jira issue # references, and "reviewed by" - although I'm wary of including literal people's emails, which are an easy target for spammers.
> remove all @author tags from source
> -----------------------------------
>
> Key: HADOOP-1147
> URL: https://issues.apache.org/jira/browse/HADOOP-1147
> Project: Hadoop
> Issue Type: Improvement
> Reporter: Doug Cutting
> Assigned To: Doug Cutting
> Priority: Minor
>
> We should remove @author tags from the source code. We give contributors credit in at least three places (Jira, subversion and CHANGES.txt). Many files have been substantially re-written by a range of contributors and their @author tags are no longer accurate. Also, @author tags imply individual ownership, when we should rather strive for community ownership.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1147) remove all @author tags from source
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483722 ]
Tom White commented on HADOOP-1147:
-----------------------------------
+1
> remove all @author tags from source
> -----------------------------------
>
> Key: HADOOP-1147
> URL: https://issues.apache.org/jira/browse/HADOOP-1147
> Project: Hadoop
> Issue Type: Improvement
> Reporter: Doug Cutting
> Assigned To: Doug Cutting
> Priority: Minor
>
> We should remove @author tags from the source code. We give contributors credit in at least three places (Jira, subversion and CHANGES.txt). Many files have been substantially re-written by a range of contributors and their @author tags are no longer accurate. Also, @author tags imply individual ownership, when we should rather strive for community ownership.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1147) remove all @author tags from source
Posted by "David Bowen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483861 ]
David Bowen commented on HADOOP-1147:
-------------------------------------
Sorry Konstantin, but I agree with the majority here. I think the idea is that the code is collectively owned. The concept of collective ownership seems not to work on a large scale, but has been shown to work quite well on Open Source projects.
Sun's code conventions don't recommend the use of @author, although it is shown in a code example. Netbeans puts it in by default, but you can change the template to turn this off.
> remove all @author tags from source
> -----------------------------------
>
> Key: HADOOP-1147
> URL: https://issues.apache.org/jira/browse/HADOOP-1147
> Project: Hadoop
> Issue Type: Improvement
> Reporter: Doug Cutting
> Assigned To: Doug Cutting
> Priority: Minor
>
> We should remove @author tags from the source code. We give contributors credit in at least three places (Jira, subversion and CHANGES.txt). Many files have been substantially re-written by a range of contributors and their @author tags are no longer accurate. Also, @author tags imply individual ownership, when we should rather strive for community ownership.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1147) remove all @author tags from source
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483689 ]
Doug Cutting commented on HADOOP-1147:
--------------------------------------
> I consider @author tags [ ...] a reference to whom I should ask questions about the code.
Aren't 'svn log' and 'svn annotate' superior for this? And shouldn't all questions be on the developer list anyway, not directed to individuals, but to the group?
> Removing will essentially make the code anonymous.
The code should be anonymous. We want lots of developers to be familiar with every file, and want to discourage individual gatekeepers for files, no?
> remove all @author tags from source
> -----------------------------------
>
> Key: HADOOP-1147
> URL: https://issues.apache.org/jira/browse/HADOOP-1147
> Project: Hadoop
> Issue Type: Improvement
> Reporter: Doug Cutting
> Assigned To: Doug Cutting
> Priority: Minor
>
> We should remove @author tags from the source code. We give contributors credit in at least three places (Jira, subversion and CHANGES.txt). Many files have been substantially re-written by a range of contributors and their @author tags are no longer accurate. Also, @author tags imply individual ownership, when we should rather strive for community ownership.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1147) remove all @author tags from source
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483702 ]
Owen O'Malley commented on HADOOP-1147:
---------------------------------------
+1
I was originally liked them, but they mostly end up creating noise. For example, I wrote the sort and word count examples that many people use for the start of their first map/reduce program and my name is in the @author. Someone didn't remove the comments and then handed off their program to someone else and it lead to confusion.
> remove all @author tags from source
> -----------------------------------
>
> Key: HADOOP-1147
> URL: https://issues.apache.org/jira/browse/HADOOP-1147
> Project: Hadoop
> Issue Type: Improvement
> Reporter: Doug Cutting
> Assigned To: Doug Cutting
> Priority: Minor
>
> We should remove @author tags from the source code. We give contributors credit in at least three places (Jira, subversion and CHANGES.txt). Many files have been substantially re-written by a range of contributors and their @author tags are no longer accurate. Also, @author tags imply individual ownership, when we should rather strive for community ownership.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1147) remove all @author tags from source
Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483368 ]
Milind Bhandarkar commented on HADOOP-1147:
-------------------------------------------
+1
> remove all @author tags from source
> -----------------------------------
>
> Key: HADOOP-1147
> URL: https://issues.apache.org/jira/browse/HADOOP-1147
> Project: Hadoop
> Issue Type: Improvement
> Reporter: Doug Cutting
> Assigned To: Doug Cutting
> Priority: Minor
>
> We should remove @author tags from the source code. We give contributors credit in at least three places (Jira, subversion and CHANGES.txt). Many files have been substantially re-written by a range of contributors and their @author tags are no longer accurate. Also, @author tags imply individual ownership, when we should rather strive for community ownership.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1147) remove all @author tags from source
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506872 ]
Hudson commented on HADOOP-1147:
--------------------------------
Integrated in Hadoop-Nightly #131 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/131/])
> remove all @author tags from source
> -----------------------------------
>
> Key: HADOOP-1147
> URL: https://issues.apache.org/jira/browse/HADOOP-1147
> Project: Hadoop
> Issue Type: Improvement
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Priority: Minor
> Fix For: 0.14.0
>
>
> We should remove @author tags from the source code. We give contributors credit in at least three places (Jira, subversion and CHANGES.txt). Many files have been substantially re-written by a range of contributors and their @author tags are no longer accurate. Also, @author tags imply individual ownership, when we should rather strive for community ownership.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.