You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/12/10 16:24:21 UTC

[GitHub] [tvm] ekalda commented on pull request #9706: [microNPU] Fix incorrect comparison in planning functions

ekalda commented on pull request #9706:
URL: https://github.com/apache/tvm/pull/9706#issuecomment-991110651


   Thanks for fixing it @jacobbohlin! Yeah I agree with Manupa that (c) is probably the smallest unit test (though arguably also the most cryptic one), but considering that this bug showed itself only in the case of diamond graphs, it means we don't also have any integration tests for diamond graphs, so it would be good to have some in general, in case the NPU compiler struggles with it in any other stage as well (we might want to add a proper integration test in a different PR though).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org