You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/09 23:46:22 UTC
[GitHub] [spark] amaliujia opened a new pull request, #38587: [SPARK-41078][CONNECT] DataFrame `withColumnsRenamed` can be implemented through `RenameColumns` proto
amaliujia opened a new pull request, #38587:
URL: https://github.com/apache/spark/pull/38587
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
`RenameColumns` proto is added by https://github.com/apache/spark/pull/38475, DataFrame `withColumnsRenamed` can reuse this proto to provide a map that help implement the API.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Improve API coverage.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
NO
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38587: [SPARK-41078][CONNECT] DataFrame `withColumnsRenamed` can be implemented through `RenameColumns` proto
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38587:
URL: https://github.com/apache/spark/pull/38587#discussion_r1018579606
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -280,9 +280,22 @@ message RenameColumns {
// Required. The input relation.
Relation input = 1;
- // Required.
+ // Optional.
//
// The number of columns of the input relation must be equal to the length
// of this field. If this is not true, an exception will be returned.
+ //
+ // This field does not co-exist with the field `rename_columns_map`.
Review Comment:
Example:
```
message RenameColumns {
ENUM {
toDF;
RenameColumnByNames;
RenameColumnByExpressions;
}
Enum type;
field1_used_by_toDF;
field2_used_by_RenameColumnByNames;
field3_used_by_RenameColumnByExpressions;
}
```
Then based on the enum value we just fetch the corresponding fields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38587: [SPARK-41078][CONNECT] DataFrame `withColumnsRenamed` can be implemented through `RenameColumns` proto
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38587:
URL: https://github.com/apache/spark/pull/38587#discussion_r1018578346
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -280,9 +280,22 @@ message RenameColumns {
// Required. The input relation.
Relation input = 1;
- // Required.
+ // Optional.
//
// The number of columns of the input relation must be equal to the length
// of this field. If this is not true, an exception will be returned.
+ //
+ // This field does not co-exist with the field `rename_columns_map`.
Review Comment:
I thinks it will face the same thing as https://github.com/apache/spark/pull/38578#discussion_r1017875279 if use oneof. In that case it would be better to just split to have two independent messages.
Maybe ENUM will be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38587: [SPARK-41078][CONNECT] DataFrame `withColumnsRenamed` can be implemented through `RenameColumns` proto
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38587:
URL: https://github.com/apache/spark/pull/38587#discussion_r1018616029
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -280,9 +280,22 @@ message RenameColumns {
// Required. The input relation.
Relation input = 1;
- // Required.
+ // Optional.
//
// The number of columns of the input relation must be equal to the length
// of this field. If this is not true, an exception will be returned.
+ //
+ // This field does not co-exist with the field `rename_columns_map`.
Review Comment:
I pushed a commit to split the message. For other `withColumnsXXX` we can add new messages for those by current approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #38587: [SPARK-41078][CONNECT] Implement DataFrame `withColumnsRenamed` in Connect proto
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #38587:
URL: https://github.com/apache/spark/pull/38587#issuecomment-1309780506
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38587: [SPARK-41078][CONNECT] DataFrame `withColumnsRenamed` can be implemented through `RenameColumns` proto
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38587:
URL: https://github.com/apache/spark/pull/38587#issuecomment-1309551225
R: @zhengruifeng
Sending out this PR to address your question at https://github.com/apache/spark/pull/38475#discussion_r1017629761. Can you take a look?
I am not adding the python side yet because I want to achieve consensus on this proto idea first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #38587: [SPARK-41078][CONNECT] DataFrame `withColumnsRenamed` can be implemented through `RenameColumns` proto
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #38587:
URL: https://github.com/apache/spark/pull/38587#discussion_r1018563280
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -280,9 +280,22 @@ message RenameColumns {
// Required. The input relation.
Relation input = 1;
- // Required.
+ // Optional.
//
// The number of columns of the input relation must be equal to the length
// of this field. If this is not true, an exception will be returned.
+ //
+ // This field does not co-exist with the field `rename_columns_map`.
Review Comment:
maybe use `oneof`?
can this message cover all other `withColumnXXX` APIs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #38587: [SPARK-41078][CONNECT] DataFrame `withColumnsRenamed` can be implemented through `RenameColumns` proto
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #38587:
URL: https://github.com/apache/spark/pull/38587#discussion_r1018596067
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -280,9 +280,22 @@ message RenameColumns {
// Required. The input relation.
Relation input = 1;
- // Required.
+ // Optional.
//
// The number of columns of the input relation must be equal to the length
// of this field. If this is not true, an exception will be returned.
+ //
+ // This field does not co-exist with the field `rename_columns_map`.
Review Comment:
I personally prefer independent messages if the field can not be reused.
also cc @cloud-fan @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38587: [SPARK-41078][CONNECT] DataFrame `withColumnsRenamed` can be implemented through `RenameColumns` proto
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38587:
URL: https://github.com/apache/spark/pull/38587#issuecomment-1309608550
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38587: [SPARK-41078][CONNECT] DataFrame `withColumnsRenamed` can be implemented through `RenameColumns` proto
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38587:
URL: https://github.com/apache/spark/pull/38587#discussion_r1018579606
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -280,9 +280,22 @@ message RenameColumns {
// Required. The input relation.
Relation input = 1;
- // Required.
+ // Optional.
//
// The number of columns of the input relation must be equal to the length
// of this field. If this is not true, an exception will be returned.
+ //
+ // This field does not co-exist with the field `rename_columns_map`.
Review Comment:
Example:
message RenameColumns {
ENUM {
toDF;
RenameColumnByNames;
RenameColumnByExpressions;
}
Enum type;
field1_used_by_toDF;
field2_used_by_RenameColumnByNames;
field3_used_by_RenameColumnByExpressions;
}
Then based on the enum value we just fetch the corresponding fields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38587: [SPARK-41078][CONNECT] DataFrame `withColumnsRenamed` can be implemented through `RenameColumns` proto
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38587:
URL: https://github.com/apache/spark/pull/38587#discussion_r1018580123
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -280,9 +280,22 @@ message RenameColumns {
// Required. The input relation.
Relation input = 1;
- // Required.
+ // Optional.
//
// The number of columns of the input relation must be equal to the length
// of this field. If this is not true, an exception will be returned.
+ //
+ // This field does not co-exist with the field `rename_columns_map`.
Review Comment:
To me, it seems to have two separate approaches:
1. use enum to decide which field to use (and document those well).
2. split into independent messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38587: [SPARK-41078][CONNECT] DataFrame `withColumnsRenamed` can be implemented through `RenameColumns` proto
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38587:
URL: https://github.com/apache/spark/pull/38587#discussion_r1018597017
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -280,9 +280,22 @@ message RenameColumns {
// Required. The input relation.
Relation input = 1;
- // Required.
+ // Optional.
//
// The number of columns of the input relation must be equal to the length
// of this field. If this is not true, an exception will be returned.
+ //
+ // This field does not co-exist with the field `rename_columns_map`.
Review Comment:
Sure let me actually just split. This will be consistent with the approach you will use in https://github.com/apache/spark/pull/38578#discussion_r1017875279.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #38587: [SPARK-41078][CONNECT] Implement DataFrame `withColumnsRenamed` in Connect proto
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #38587: [SPARK-41078][CONNECT] Implement DataFrame `withColumnsRenamed` in Connect proto
URL: https://github.com/apache/spark/pull/38587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org