You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "stephen mallette (JIRA)" <ji...@apache.org> on 2018/09/05 18:21:00 UTC
[jira] [Comment Edited] (TINKERPOP-2029)
ConcurrentModificationException for InlineFilterStrategy
[ https://issues.apache.org/jira/browse/TINKERPOP-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604692#comment-16604692 ]
stephen mallette edited comment on TINKERPOP-2029 at 9/5/18 6:20 PM:
---------------------------------------------------------------------
I've pushed a branch based on tp32 with associated tests that cause the failure:
https://github.com/apache/tinkerpop/tree/TINKERPOP-2029
The process test to {{AndTest}} will need to be added as a GLV test still. There are technically two issues to consider. First, it seems that {{ConnectiveStrategy}} will transform certain {{and()}} and {{or()}} combinations to something that {{InlineFilterStrategy}} doesn't properly handle. Specifically, {{ConnectiveStrategyTest}} includes test cases that show that
{code}
__.has("name", "marko").and().has("name", "marko").and().has("name", "marko")
{code}
does not convert to:
{code}
__.and(has("name", "marko"), __.has("name", "marko"), __.has("name", "marko"))
{code}
and instead produces something like this:
{code}
java.lang.AssertionError:
Expected :[AndStep([[HasStep([name.eq(marko)])], [HasStep([name.eq(marko)])], [HasStep([name.eq(marko)])]])]
Actual :[HasStep([name.eq(marko)]), AndStep([[], [AndStep([[HasStep([name.eq(marko)])], []]), HasStep([name.eq(marko)])]])]
{code}
That in turn feeds to {{InlineFilterStrategy}} which seems to properly deal with the expected output above, but not the actual output that it's currently producing. I'm not completely sure what {{InlineFilterStrategy}} should do with such Gremlin if anything, but we should probably change the flow of it to avoid {{ConcurrentModificationException}} irrespective of the situation with {{InlineFilterStrategy}}. I've not been able to create a standalone scenario to recreate the {{ConcurrentModificationException}} so it might be best to deal with that first since it's currently failing that way.
was (Author: spmallette):
I've pushed a branch with associated tests that cause the failure:
https://github.com/apache/tinkerpop/tree/TINKERPOP-2029
The process test to {{AndTest}} will need to be added as a GLV test still. There are technically two issues to consider. First, it seems that {{ConnectiveStrategy}} will transform certain {{and()}} and {{or()}} combinations to something that {{InlineFilterStrategy}} doesn't properly handle. Specifically, {{ConnectiveStrategyTest}} includes test cases that show that
{code}
__.has("name", "marko").and().has("name", "marko").and().has("name", "marko")
{code}
does not convert to:
{code}
__.and(has("name", "marko"), __.has("name", "marko"), __.has("name", "marko"))
{code}
and instead produces something like this:
{code}
java.lang.AssertionError:
Expected :[AndStep([[HasStep([name.eq(marko)])], [HasStep([name.eq(marko)])], [HasStep([name.eq(marko)])]])]
Actual :[HasStep([name.eq(marko)]), AndStep([[], [AndStep([[HasStep([name.eq(marko)])], []]), HasStep([name.eq(marko)])]])]
{code}
That in turn feeds to {{InlineFilterStrategy}} which seems to properly deal with the expected output above, but not the actual output that it's currently producing. I'm not completely sure what {{InlineFilterStrategy}} should do with such Gremlin if anything, but we should probably change the flow of it to avoid {{ConcurrentModificationException}} irrespective of the situation with {{InlineFilterStrategy}}. I've not been able to create a standalone scenario to recreate the {{ConcurrentModificationException}} so it might be best to deal with that first since it's currently failing that way.
> ConcurrentModificationException for InlineFilterStrategy
> --------------------------------------------------------
>
> Key: TINKERPOP-2029
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2029
> Project: TinkerPop
> Issue Type: Bug
> Components: process
> Affects Versions: 3.2.9
> Reporter: stephen mallette
> Assignee: Daniel Kuppitz
> Priority: Minor
>
> {code}
> gremlin> g.V().has("name", "marko").and().has("name", "marko").and().has("name", "marko")
> java.util.ConcurrentModificationException
> Type ':help' or ':h' for help.
> Display stack trace? [yN]y
> java.util.ConcurrentModificationException
> at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:909)
> at java.util.ArrayList$Itr.next(ArrayList.java:859)
> at java.util.Collections$UnmodifiableCollection$1.next(Collections.java:1042)
> at org.apache.tinkerpop.gremlin.process.traversal.strategy.optimization.InlineFilterStrategy.processHasStep(InlineFilterStrategy.java:114)
> at org.apache.tinkerpop.gremlin.process.traversal.strategy.optimization.InlineFilterStrategy.apply(InlineFilterStrategy.java:93)
> at org.apache.tinkerpop.gremlin.process.traversal.util.TraversalHelper.applySingleLevelStrategies(TraversalHelper.java:696)
> at org.apache.tinkerpop.gremlin.process.traversal.strategy.optimization.InlineFilterStrategy.processAndStep(InlineFilterStrategy.java:248)
> at org.apache.tinkerpop.gremlin.process.traversal.strategy.optimization.InlineFilterStrategy.apply(InlineFilterStrategy.java:96)
> at org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversalStrategies.applyStrategies(DefaultTraversalStrategies.java:86)
> at org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversal.applyStrategies(DefaultTraversal.java:119)
> at org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversal.hasNext(DefaultTraversal.java:191)
> at org.apache.tinkerpop.gremlin.console.Console$_closure3.doCall(Console.groovy:239)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:98)
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
> at org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:264)
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1034)
> at org.codehaus.groovy.tools.shell.Groovysh.setLastResult(Groovysh.groovy:460)
> at org.codehaus.groovy.tools.shell.Groovysh.execute(Groovysh.groovy:196)
> at org.apache.tinkerpop.gremlin.console.GremlinGroovysh.super$3$execute(GremlinGroovysh.groovy)
> at sun.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:98)
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1225)
> at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:145)
> at org.apache.tinkerpop.gremlin.console.GremlinGroovysh.execute(GremlinGroovysh.groovy:72)
> at org.codehaus.groovy.tools.shell.Shell.leftShift(Shell.groovy:122)
> at org.codehaus.groovy.tools.shell.ShellRunner.work(ShellRunner.groovy:95)
> at org.codehaus.groovy.tools.shell.InteractiveShellRunner.super$2$work(InteractiveShellRunner.groovy)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:98)
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1225)
> at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:145)
> at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuper0(ScriptBytecodeAdapter.java:165)
> at org.codehaus.groovy.tools.shell.InteractiveShellRunner.work(InteractiveShellRunner.groovy:130)
> at org.codehaus.groovy.tools.shell.ShellRunner.run(ShellRunner.groovy:59)
> at org.codehaus.groovy.tools.shell.InteractiveShellRunner.super$2$run(InteractiveShellRunner.groovy)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:98)
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325)
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1225)
> at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuperN(ScriptBytecodeAdapter.java:145)
> at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.invokeMethodOnSuper0(ScriptBytecodeAdapter.java:165)
> at org.codehaus.groovy.tools.shell.InteractiveShellRunner.run(InteractiveShellRunner.groovy:89)
> at org.codehaus.groovy.vmplugin.v7.IndyInterface.selectMethod(IndyInterface.java:236)
> at org.apache.tinkerpop.gremlin.console.Console.<init>(Console.groovy:171)
> at org.codehaus.groovy.vmplugin.v7.IndyInterface.selectMethod(IndyInterface.java:236)
> at org.apache.tinkerpop.gremlin.console.Console.main(Console.groovy:483)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)