[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8535: add scalar function for cast so it can be calculated at compile time

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on code in PR #8535:
URL: https://github.com/apache/pinot/pull/8535#discussion_r849711782


##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java:
##########
@@ -32,6 +33,23 @@ public class DataTypeConversionFunctions {
   private DataTypeConversionFunctions() {
   }
 
+  @ScalarFunction
+  public static Object cast(Object value, String targetType) {
+    if (value == null) {
+      return null;
+    }
+    try {
+      Class<?> clazz = value.getClass();
+      boolean isMultiValue = clazz.isArray();
+      PinotDataType sourceType = isMultiValue
+          ? PinotDataType.getMultiValueType(clazz)
+          : PinotDataType.getSingleValueType(clazz);
+      return PinotDataType.valueOf(targetType.toUpperCase()).convert(value, sourceType);

Review Comment:
   We should make the behavior the same as `CastTransformFunction` (support `INT` and `VARCHAR`). We can make a switch case here for the target data type similar to how we handle the types in `CastTransformFunction`



##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java:
##########
@@ -32,6 +33,23 @@ public class DataTypeConversionFunctions {
   private DataTypeConversionFunctions() {
   }
 
+  @ScalarFunction
+  public static Object cast(Object value, String targetType) {
+    if (value == null) {

Review Comment:
   (minor) both arguments won't be `null` here since the function is not annotated as `nullableParameters`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org