[GitHub] [iceberg] danielcweeks commented on a diff in pull request #5299: AWS: Dynamo Catalog: Pass CommitFailedException up the stack without wrapping

[GitBox <gi...@apache.org>]

danielcweeks commented on code in PR #5299:
URL: https://github.com/apache/iceberg/pull/5299#discussion_r923884333


##########
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbTableOperations.java:
##########
@@ -114,6 +114,9 @@ protected void doCommit(TableMetadata base, TableMetadata metadata) {
       commitStatus = CommitStatus.SUCCESS;
     } catch (ConditionalCheckFailedException e) {
       throw new CommitFailedException(e, "Cannot commit %s: concurrent update detected", tableName());
+    } catch (CommitFailedException e) {

Review Comment:
   I see what this is addressing and I believe this will fix that issue, but I believe the `checkMetadataLocation` call that throws the commit exception directly is unnecessary.  The base location should be checked in the `persistTable` and handled through the ConditionalCheckFailedException.
   
   This `checkMetadataLocation` seems like it is unnecessary, but I guess at a minimum it avoids a dynamo call. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org