You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Chao Sun <ch...@cloudera.com> on 2014/09/25 00:50:42 UTC
Review Request 26007: HIVE-8249 - Refactoring SparkPlan and
SparkPlanGenerator [Spark Branch]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26007/
-----------------------------------------------------------
Review request for hive, Brock Noland and Xuefu Zhang.
Bugs: hive-8249
https://issues.apache.org/jira/browse/hive-8249
Repository: hive-git
Description
-------
Currently, the code for SparkPlanGenerator seems a little bit messy, and the logic is not quite clear. This JIRA is created to refactor this and related classes.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/GraphTran.java acd42be
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlan.java 46e4b6d
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java 7ab2ca0
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/UnionTran.java 546b448
Diff: https://reviews.apache.org/r/26007/diff/
Testing
-------
Thanks,
Chao Sun
Re: Review Request 26007: HIVE-8249 - Refactoring SparkPlan and
SparkPlanGenerator [Spark Branch]
Posted by Chao Sun <ch...@cloudera.com>.
> On Sept. 24, 2014, 11:51 p.m., Xuefu Zhang wrote:
> >
OK, I'll change it in the next patch, once the test result is out.
- Chao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26007/#review54481
-----------------------------------------------------------
On Sept. 24, 2014, 10:50 p.m., Chao Sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26007/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2014, 10:50 p.m.)
>
>
> Review request for hive, Brock Noland and Xuefu Zhang.
>
>
> Bugs: hive-8249
> https://issues.apache.org/jira/browse/hive-8249
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently, the code for SparkPlanGenerator seems a little bit messy, and the logic is not quite clear. This JIRA is created to refactor this and related classes.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/GraphTran.java acd42be
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlan.java 46e4b6d
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java 7ab2ca0
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/UnionTran.java 546b448
>
> Diff: https://reviews.apache.org/r/26007/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chao Sun
>
>
Re: Review Request 26007: HIVE-8249 - Refactoring SparkPlan and
SparkPlanGenerator [Spark Branch]
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26007/#review54481
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/UnionTran.java
<https://reviews.apache.org/r/26007/#comment94628>
Nit: could we rename it to IdentityTran, as this has nothing close to union any more?
- Xuefu Zhang
On Sept. 24, 2014, 10:50 p.m., Chao Sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26007/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2014, 10:50 p.m.)
>
>
> Review request for hive, Brock Noland and Xuefu Zhang.
>
>
> Bugs: hive-8249
> https://issues.apache.org/jira/browse/hive-8249
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently, the code for SparkPlanGenerator seems a little bit messy, and the logic is not quite clear. This JIRA is created to refactor this and related classes.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/GraphTran.java acd42be
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlan.java 46e4b6d
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java 7ab2ca0
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/UnionTran.java 546b448
>
> Diff: https://reviews.apache.org/r/26007/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chao Sun
>
>
Re: Review Request 26007: HIVE-8249 - Refactoring SparkPlan and
SparkPlanGenerator [Spark Branch]
Posted by Chao Sun <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26007/
-----------------------------------------------------------
(Updated Sept. 25, 2014, 1:02 a.m.)
Review request for hive, Brock Noland and Xuefu Zhang.
Changes
-------
Changed UnionTran to IdentityTran. Thanks Xuefu for the suggestion!
Bugs: hive-8249
https://issues.apache.org/jira/browse/hive-8249
Repository: hive-git
Description
-------
Currently, the code for SparkPlanGenerator seems a little bit messy, and the logic is not quite clear. This JIRA is created to refactor this and related classes.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/GraphTran.java acd42be
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/IdentityTran.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlan.java 46e4b6d
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java 7ab2ca0
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/UnionTran.java 546b448
Diff: https://reviews.apache.org/r/26007/diff/
Testing
-------
Thanks,
Chao Sun