[GitHub] [arrow] jonkeane commented on a diff in pull request #13432: ARROW-16900: [R] Upgrade lintr

[GitBox <gi...@apache.org>]

jonkeane commented on code in PR #13432:
URL: https://github.com/apache/arrow/pull/13432#discussion_r906143717


##########
ci/docker/linux-apt-lint.dockerfile:
##########
@@ -56,20 +56,8 @@ COPY ci/etc/rprofile /arrow/ci/etc/
 RUN cat /arrow/ci/etc/rprofile >> $(R RHOME)/etc/Rprofile.site
 # Also ensure parallel compilation of C/C++ code
 RUN echo "MAKEFLAGS=-j$(R -s -e 'cat(parallel::detectCores())')" >> $(R RHOME)/etc/Renviron.site
-
-
-COPY ci/scripts/r_deps.sh /arrow/ci/scripts/
-COPY r/DESCRIPTION /arrow/r/
-# We need to install Arrow's dependencies in order for lintr's namespace searching to work.
-# This could be removed if lintr no longer loads the dependency namespaces (see issues/PRs below)

Review Comment:
   The namespace issue wasn't one of the ones I raised — it was just a consequence of the way lintr was looking up signatures for functions when linting. Though that code was under a decent amount of flux, so I wouldn't be surprised if it no longer requires the dependencies to be installed. 
   
   If it passes without installing them, we're totally fine to remove it IMO.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org