You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Dondi Imperial (JIRA)" <de...@geronimo.apache.org> on 2005/04/26 08:32:40 UTC
[jira] Created: (GERONIMO-637) LogFactory.release(ClassLoader) can release the parent config's logger.
LogFactory.release(ClassLoader) can release the parent config's logger.
-----------------------------------------------------------------------
Key: GERONIMO-637
URL: http://issues.apache.org/jira/browse/GERONIMO-637
Project: Geronimo
Type: Bug
Components: general
Reporter: Dondi Imperial
Priority: Minor
Calling LogFactory.release(ClassLoader) from a configuration appears to release the parent config's logger.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (GERONIMO-637) LogFactory.release(ClassLoader) can release the parent config's logger.
Posted by "Dain Sundstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-637?page=all ]
Dain Sundstrom closed GERONIMO-637:
-----------------------------------
Resolution: Fixed
No one complained so it must be working.
> LogFactory.release(ClassLoader) can release the parent config's logger.
> -----------------------------------------------------------------------
>
> Key: GERONIMO-637
> URL: http://issues.apache.org/jira/browse/GERONIMO-637
> Project: Geronimo
> Type: Bug
> Components: general
> Versions: 1.0-M4
> Reporter: Dondi Imperial
> Priority: Minor
> Fix For: 1.0
> Attachments: diff.txt, test.war
>
> Calling LogFactory.release(ClassLoader) from a configuration appears to release the parent config's logger.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-637) LogFactory.release(ClassLoader) can release the parent config's logger.
Posted by "Dondi Imperial (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-637?page=all ]
Dondi Imperial updated GERONIMO-637:
------------------------------------
Attachment: diff.txt
It looks like release in o.a.g.kernel.log.GeronimoLogFactory sets all of it's contained Logs (wrapped in instances of GeronimoLog) to null in release. This doesn't seem to be necessary and will even cause NullPointerExceptions when classes that continue to hold references to these Logs call one of their methods. It seems like this is done so Logs can get garbage collected but this might not be correct because some objects might still be holding references to there Logs. Attached here is a patch that removes the code described previously.
> LogFactory.release(ClassLoader) can release the parent config's logger.
> -----------------------------------------------------------------------
>
> Key: GERONIMO-637
> URL: http://issues.apache.org/jira/browse/GERONIMO-637
> Project: Geronimo
> Type: Bug
> Components: general
> Reporter: Dondi Imperial
> Priority: Minor
> Attachments: diff.txt, test.war
>
> Calling LogFactory.release(ClassLoader) from a configuration appears to release the parent config's logger.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-637) LogFactory.release(ClassLoader) can release the parent config's logger.
Posted by "Dain Sundstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-637?page=comments#action_64545 ]
Dain Sundstrom commented on GERONIMO-637:
-----------------------------------------
Applied the patch, but the commons-logging integration still need work. This issue should remain open until we are sure that we didn't actually need that code.
> LogFactory.release(ClassLoader) can release the parent config's logger.
> -----------------------------------------------------------------------
>
> Key: GERONIMO-637
> URL: http://issues.apache.org/jira/browse/GERONIMO-637
> Project: Geronimo
> Type: Bug
> Components: general
> Reporter: Dondi Imperial
> Priority: Minor
> Attachments: diff.txt, test.war
>
> Calling LogFactory.release(ClassLoader) from a configuration appears to release the parent config's logger.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-637) LogFactory.release(ClassLoader) can release the parent config's logger.
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-637?page=all ]
Aaron Mulder updated GERONIMO-637:
----------------------------------
Fix Version: 1.0
Version: 1.0-M4
Environment:
> LogFactory.release(ClassLoader) can release the parent config's logger.
> -----------------------------------------------------------------------
>
> Key: GERONIMO-637
> URL: http://issues.apache.org/jira/browse/GERONIMO-637
> Project: Geronimo
> Type: Bug
> Components: general
> Versions: 1.0-M4
> Reporter: Dondi Imperial
> Priority: Minor
> Fix For: 1.0
> Attachments: diff.txt, test.war
>
> Calling LogFactory.release(ClassLoader) from a configuration appears to release the parent config's logger.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-637) LogFactory.release(ClassLoader) can release the parent config's logger.
Posted by "Dondi Imperial (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-637?page=all ]
Dondi Imperial updated GERONIMO-637:
------------------------------------
Attachment: test.war
To test the bug deploy then start the attached webapp (test.war) then undeploy it.
> LogFactory.release(ClassLoader) can release the parent config's logger.
> -----------------------------------------------------------------------
>
> Key: GERONIMO-637
> URL: http://issues.apache.org/jira/browse/GERONIMO-637
> Project: Geronimo
> Type: Bug
> Components: general
> Reporter: Dondi Imperial
> Priority: Minor
> Attachments: test.war
>
> Calling LogFactory.release(ClassLoader) from a configuration appears to release the parent config's logger.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira