You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@datafusion.apache.org by "ShashidharM0118 (via GitHub)" <gi...@apache.org> on 2025/12/09 18:25:53 UTC

Re: [PR] feat: Make GenericDistinctBuffer generic over both Hashable and native types [datafusion]

ShashidharM0118 commented on PR #18763:
URL: https://github.com/apache/datafusion/pull/18763#issuecomment-3633649258

   > Apologies I still haven't been able to take a look at this; however before I dive into the PR it would be good to see some of the benchmarks I mention above just so we know this can be a valid approach that doesn't regress performance
   
   I added the requested micro-benchmarks (count/sum distinct int64/float64 and median/percentile_cont int64/float64) and ran them against `main` vs this branch, no regressions observed. Please take a look when you have time—thanks!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org