You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2026/05/15 07:31:30 UTC

[PR] [fix](sc) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Mryange opened a new pull request, #63290:
URL: https://github.com/apache/doris/pull/63290

   ### What problem does this PR solve?
   
   Issue Number: N/A
   
   Problem Summary:
   
   Schema change could fail when adding a TIMESTAMPTZ column with DEFAULT CURRENT_TIMESTAMP, such as ALTER TABLE ... ADD COLUMN ts TIMESTAMPTZ(6) DEFAULT CURRENT_TIMESTAMP(6). Existing rows are backfilled from Column.realDefaultValue during schema change, but FE previously materialized CURRENT_TIMESTAMP as a plain datetime string without a timezone offset. Root cause: the schema-change default serialization path was not type-aware for TIMESTAMPTZ, while BE expects a TIMESTAMPTZ literal with an offset when parsing the backfill value. This change makes both the Nereids and legacy ColumnDef paths materialize TIMESTAMPTZ CURRENT_TIMESTAMP defaults with the session offset, reuses TimestampTzLiteral formatting for the datetime body, and adds FE and regression coverage for the schema-change path.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4473892276

   # FE UT Coverage Report
   Increment line coverage `  28.57% (8/28)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63290_8e9addd3fc6b4039b58115fc8932f535d7005b81/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63290_8e9addd3fc6b4039b58115fc8932f535d7005b81/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4467259531

   # FE Regression Coverage Report
   Increment line coverage `  29.63% (8/27)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63290_54d069a28d09f7ca8635048531a801044ffc97a7_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63290_54d069a28d09f7ca8635048531a801044ffc97a7_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4460545154

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 30587 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 54d069a28d09f7ca8635048531a801044ffc97a7, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17701	3860	3832	3832
   q2	q3	10797	1424	827	827
   q4	4682	482	345	345
   q5	7555	2230	2147	2147
   q6	250	173	136	136
   q7	923	767	629	629
   q8	9339	1769	1502	1502
   q9	6597	4885	4883	4883
   q10	6432	2120	1750	1750
   q11	428	273	239	239
   q12	690	422	293	293
   q13	18227	3367	2772	2772
   q14	265	252	235	235
   q15	q16	814	759	712	712
   q17	1015	881	905	881
   q18	6731	5668	5420	5420
   q19	1264	1259	1039	1039
   q20	510	416	263	263
   q21	5816	2591	2388	2388
   q22	425	364	294	294
   Total cold run time: 100461 ms
   Total hot run time: 30587 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	4178	4196	4068	4068
   q2	q3	4452	4900	4245	4245
   q4	2102	2190	1405	1405
   q5	4354	4276	4303	4276
   q6	226	175	130	130
   q7	2057	1867	1698	1698
   q8	2517	2156	2030	2030
   q9	7801	7650	7772	7650
   q10	4505	4504	4023	4023
   q11	584	405	488	405
   q12	740	729	517	517
   q13	3339	3537	3013	3013
   q14	293	310	276	276
   q15	q16	709	734	660	660
   q17	1361	1311	1307	1307
   q18	7872	7298	6961	6961
   q19	1126	1101	1089	1089
   q20	2186	2201	1923	1923
   q21	5320	4597	4494	4494
   q22	510	475	404	404
   Total cold run time: 56232 ms
   Total hot run time: 50574 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4467220947

   # FE Regression Coverage Report
   Increment line coverage `  29.63% (8/27)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63290_54d069a28d09f7ca8635048531a801044ffc97a7_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63290_54d069a28d09f7ca8635048531a801044ffc97a7_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4458704422

   # FE UT Coverage Report
   Increment line coverage `  30.43% (7/23)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63290_0ae4067ffa40eadcfa97628b55417e5cbe2442d6/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63290_0ae4067ffa40eadcfa97628b55417e5cbe2442d6/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4466977559

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31331 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 54d069a28d09f7ca8635048531a801044ffc97a7, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17685	4020	3916	3916
   q2	q3	10792	1367	789	789
   q4	4685	471	343	343
   q5	7713	2314	2096	2096
   q6	246	184	146	146
   q7	917	806	618	618
   q8	9350	1743	1621	1621
   q9	6240	4894	4891	4891
   q10	6435	2119	1822	1822
   q11	436	277	248	248
   q12	694	425	301	301
   q13	18212	3392	2732	2732
   q14	261	256	242	242
   q15	q16	822	759	705	705
   q17	929	986	911	911
   q18	6809	5733	5538	5538
   q19	1192	1432	1178	1178
   q20	564	437	278	278
   q21	6119	2758	2637	2637
   q22	444	388	319	319
   Total cold run time: 100545 ms
   Total hot run time: 31331 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	4889	4655	4919	4655
   q2	q3	4831	5239	4588	4588
   q4	2109	2166	1420	1420
   q5	4820	4762	4630	4630
   q6	225	179	130	130
   q7	1842	1701	1558	1558
   q8	2352	1907	1897	1897
   q9	7190	7243	7259	7243
   q10	4468	4369	3945	3945
   q11	541	401	366	366
   q12	708	715	504	504
   q13	2987	3294	2817	2817
   q14	270	272	259	259
   q15	q16	679	690	605	605
   q17	1270	1225	1240	1225
   q18	7385	6795	6742	6742
   q19	1105	1057	1105	1057
   q20	2216	2220	1919	1919
   q21	5287	4629	4422	4422
   q22	520	485	418	418
   Total cold run time: 55694 ms
   Total hot run time: 50400 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](sc) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #63290:
URL: https://github.com/apache/doris/pull/63290#discussion_r3246663542


##########
regression-test/suites/schema_change_p0/test_timestamptz_default_schema_change.groovy:
##########
@@ -0,0 +1,65 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_timestamptz_default_schema_change", "p0") {
+    def tableName = "test_timestamptz_default_schema_change"

Review Comment:
   Doris regression-test standards in `AGENTS.md` require hardcoding table names for ordinary single-table tests instead of using `def tableName`. Please inline `test_timestamptz_default_schema_change` in the SQL strings, or use a literal only where dynamic naming is genuinely needed.



##########
regression-test/suites/schema_change_p0/test_timestamptz_default_schema_change.groovy:
##########
@@ -0,0 +1,65 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_timestamptz_default_schema_change", "p0") {
+    def tableName = "test_timestamptz_default_schema_change"
+    def getTableStatusSql = """ SHOW ALTER TABLE COLUMN WHERE IndexName='${tableName}' ORDER BY createtime DESC LIMIT 1 """
+
+    sql "DROP TABLE IF EXISTS ${tableName} FORCE"
+    sql "SET time_zone = '+08:00'"
+
+    sql """
+        CREATE TABLE IF NOT EXISTS ${tableName} (
+            id INT NOT NULL
+        )
+        DUPLICATE KEY(id)
+        DISTRIBUTED BY HASH(id) BUCKETS 1
+        PROPERTIES (
+            "replication_num" = "1",
+            "light_schema_change" = "false"
+        )
+    """
+
+    sql """ INSERT INTO ${tableName} VALUES (1), (2), (3) """
+
+    sql """
+        ALTER TABLE ${tableName}
+        ADD COLUMN ts TIMESTAMPTZ(6) DEFAULT CURRENT_TIMESTAMP(6)
+    """
+
+    waitForSchemaChangeDone {
+        sql getTableStatusSql
+        time 120
+    }
+
+    sql """ sync """
+
+    def rows = sql """
+        SELECT id, CAST(ts AS STRING) AS ts_str
+        FROM ${tableName}
+        ORDER BY id
+    """
+
+    assertEquals(3, rows.size())
+    rows.each { row ->
+        assertTrue(row[1] != null)
+        assertTrue(row[1].toString() ==~ /\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}\.\d{6}[+-]\d{2}:\d{2}/,
+                "Unexpected TIMESTAMPTZ value: ${row[1]}")
+    }
+
+    sql "DROP TABLE IF EXISTS ${tableName} FORCE"
+}

Review Comment:
   Doris regression-test standards require dropping tables before use, not after, so the failed-test environment is preserved for debugging. This suite already drops the table at the beginning; please remove the final `DROP TABLE` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4461560593

   # FE Regression Coverage Report
   Increment line coverage `  29.63% (8/27)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63290_54d069a28d09f7ca8635048531a801044ffc97a7_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63290_54d069a28d09f7ca8635048531a801044ffc97a7_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4474454719

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 168959 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 8e9addd3fc6b4039b58115fc8932f535d7005b81, data reload: false
   
   query5	4316	651	542	542
   query6	331	221	212	212
   query7	4254	567	303	303
   query8	337	237	218	218
   query9	8821	3987	3973	3973
   query10	463	356	297	297
   query11	5784	2337	2200	2200
   query12	183	131	125	125
   query13	1296	616	433	433
   query14	5879	5349	4987	4987
   query14_1	4314	4334	4299	4299
   query15	207	205	180	180
   query16	979	449	439	439
   query17	1006	723	584	584
   query18	2470	474	355	355
   query19	209	205	169	169
   query20	135	134	131	131
   query21	221	141	124	124
   query22	13599	13489	13351	13351
   query23	17323	16455	16028	16028
   query23_1	16180	16187	16216	16187
   query24	7662	1789	1288	1288
   query24_1	1339	1308	1311	1308
   query25	603	519	450	450
   query26	1312	329	177	177
   query27	2701	565	346	346
   query28	4522	1949	1953	1949
   query29	1006	674	532	532
   query30	306	250	206	206
   query31	1125	1067	945	945
   query32	93	78	79	78
   query33	574	371	315	315
   query34	1232	1185	640	640
   query35	756	802	698	698
   query36	1320	1358	1172	1172
   query37	160	110	105	105
   query38	3223	3137	3048	3048
   query39	926	938	933	933
   query39_1	876	912	892	892
   query40	234	151	129	129
   query41	72	70	68	68
   query42	113	111	110	110
   query43	326	331	285	285
   query44	
   query45	219	209	196	196
   query46	1103	1176	735	735
   query47	2329	2342	2235	2235
   query48	425	450	295	295
   query49	649	504	415	415
   query50	1042	345	249	249
   query51	4285	4298	4229	4229
   query52	111	109	99	99
   query53	254	279	215	215
   query54	332	296	269	269
   query55	97	97	89	89
   query56	319	326	314	314
   query57	1419	1384	1291	1291
   query58	312	284	282	282
   query59	1628	1655	1395	1395
   query60	314	330	314	314
   query61	162	163	152	152
   query62	670	641	569	569
   query63	243	220	214	214
   query64	2461	812	652	652
   query65	
   query66	1729	474	357	357
   query67	29990	29345	29193	29193
   query68	
   query69	451	340	302	302
   query70	1070	1013	975	975
   query71	316	277	266	266
   query72	3027	2896	2534	2534
   query73	873	781	392	392
   query74	5069	4844	4743	4743
   query75	2675	2592	2289	2289
   query76	2253	1130	755	755
   query77	399	406	334	334
   query78	12605	12263	11568	11568
   query79	1381	1156	709	709
   query80	648	542	458	458
   query81	463	285	246	246
   query82	1362	162	120	120
   query83	370	275	252	252
   query84	323	134	110	110
   query85	887	565	453	453
   query86	401	348	338	338
   query87	3380	3400	3205	3205
   query88	3539	2667	2654	2654
   query89	432	382	338	338
   query90	1954	192	181	181
   query91	183	166	147	147
   query92	76	79	73	73
   query93	1549	1433	849	849
   query94	558	351	318	318
   query95	696	452	340	340
   query96	1067	761	332	332
   query97	2682	2698	2565	2565
   query98	244	230	237	230
   query99	1129	1089	982	982
   Total cold run time: 253997 ms
   Total hot run time: 168959 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange closed pull request #63290: [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset
URL: https://github.com/apache/doris/pull/63290


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4467319112

   # FE Regression Coverage Report
   Increment line coverage `  29.63% (8/27)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63290_54d069a28d09f7ca8635048531a801044ffc97a7_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63290_54d069a28d09f7ca8635048531a801044ffc97a7_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4458226983

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4458987297

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 169649 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 0ae4067ffa40eadcfa97628b55417e5cbe2442d6, data reload: false
   
   query5	4336	657	518	518
   query6	340	220	199	199
   query7	4246	601	328	328
   query8	325	237	229	229
   query9	8834	4057	4033	4033
   query10	445	350	291	291
   query11	5826	2403	2282	2282
   query12	184	130	134	130
   query13	1280	614	470	470
   query14	6186	5298	5012	5012
   query14_1	4363	4349	4292	4292
   query15	207	203	181	181
   query16	1003	469	413	413
   query17	1183	742	573	573
   query18	2707	473	345	345
   query19	216	203	171	171
   query20	148	135	128	128
   query21	215	139	115	115
   query22	13596	13631	13439	13439
   query23	17159	16344	15999	15999
   query23_1	16268	16213	16249	16213
   query24	7480	1784	1307	1307
   query24_1	1337	1324	1316	1316
   query25	587	507	447	447
   query26	1348	308	179	179
   query27	2729	531	333	333
   query28	4412	1943	1948	1943
   query29	1030	640	540	540
   query30	308	238	204	204
   query31	1142	1062	947	947
   query32	88	77	80	77
   query33	583	370	314	314
   query34	1155	1148	630	630
   query35	776	780	672	672
   query36	1331	1332	1154	1154
   query37	156	110	98	98
   query38	3198	3142	3052	3052
   query39	945	939	923	923
   query39_1	898	874	866	866
   query40	230	152	130	130
   query41	76	74	70	70
   query42	115	109	117	109
   query43	323	326	292	292
   query44	
   query45	216	201	201	201
   query46	1044	1174	749	749
   query47	2268	2415	2215	2215
   query48	414	431	315	315
   query49	650	515	428	428
   query50	986	343	259	259
   query51	4345	4296	4227	4227
   query52	107	107	96	96
   query53	259	288	216	216
   query54	328	286	276	276
   query55	96	93	84	84
   query56	306	318	322	318
   query57	1435	1405	1325	1325
   query58	309	278	294	278
   query59	1549	1619	1399	1399
   query60	336	368	305	305
   query61	162	160	157	157
   query62	669	636	569	569
   query63	244	203	229	203
   query64	2347	838	635	635
   query65	
   query66	1667	475	353	353
   query67	29888	29902	29812	29812
   query68	
   query69	467	354	310	310
   query70	1010	1022	985	985
   query71	308	277	266	266
   query72	2997	2673	2414	2414
   query73	824	760	432	432
   query74	5058	4882	4745	4745
   query75	2649	2624	2270	2270
   query76	2334	1120	758	758
   query77	392	417	333	333
   query78	12071	12031	11675	11675
   query79	1427	1046	733	733
   query80	847	542	484	484
   query81	490	277	248	248
   query82	1387	158	124	124
   query83	355	281	257	257
   query84	257	146	108	108
   query85	930	540	462	462
   query86	448	336	316	316
   query87	3408	3346	3206	3206
   query88	3478	2641	2605	2605
   query89	447	388	338	338
   query90	1788	180	183	180
   query91	181	167	142	142
   query92	83	78	85	78
   query93	1542	1399	825	825
   query94	627	346	301	301
   query95	668	382	442	382
   query96	1018	796	359	359
   query97	2707	2697	2579	2579
   query98	236	235	227	227
   query99	1121	1111	989	989
   Total cold run time: 253316 ms
   Total hot run time: 169649 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4467002423

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 168755 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 54d069a28d09f7ca8635048531a801044ffc97a7, data reload: false
   
   query5	4312	662	521	521
   query6	332	215	206	206
   query7	4281	539	308	308
   query8	319	239	231	231
   query9	8845	3995	3998	3995
   query10	458	353	303	303
   query11	5846	2346	2224	2224
   query12	181	130	122	122
   query13	1290	602	429	429
   query14	5949	5350	5036	5036
   query14_1	4352	4362	4316	4316
   query15	218	207	183	183
   query16	998	426	456	426
   query17	1174	753	598	598
   query18	2534	494	368	368
   query19	232	210	173	173
   query20	144	140	132	132
   query21	216	147	126	126
   query22	13609	13608	13428	13428
   query23	17131	16349	16021	16021
   query23_1	16145	16173	16198	16173
   query24	7522	1726	1308	1308
   query24_1	1280	1295	1313	1295
   query25	558	518	453	453
   query26	1309	326	177	177
   query27	2695	560	350	350
   query28	4467	1968	1954	1954
   query29	1005	643	512	512
   query30	311	245	203	203
   query31	1131	1085	949	949
   query32	91	79	76	76
   query33	560	375	308	308
   query34	1168	1127	640	640
   query35	762	787	722	722
   query36	1323	1322	1163	1163
   query37	151	105	89	89
   query38	3212	3118	3048	3048
   query39	917	917	912	912
   query39_1	890	886	862	862
   query40	228	146	127	127
   query41	67	64	63	63
   query42	113	110	111	110
   query43	316	330	276	276
   query44	
   query45	207	199	192	192
   query46	1089	1151	724	724
   query47	2322	2317	2220	2220
   query48	399	409	288	288
   query49	707	498	391	391
   query50	997	334	257	257
   query51	4360	4310	4157	4157
   query52	105	106	95	95
   query53	245	284	212	212
   query54	317	269	253	253
   query55	95	90	83	83
   query56	311	315	312	312
   query57	1386	1403	1323	1323
   query58	303	273	272	272
   query59	1512	1639	1385	1385
   query60	326	318	310	310
   query61	164	157	159	157
   query62	669	636	561	561
   query63	253	209	213	209
   query64	2368	816	625	625
   query65	
   query66	1741	483	402	402
   query67	30143	29916	29685	29685
   query68	
   query69	449	346	303	303
   query70	1007	1007	992	992
   query71	322	275	260	260
   query72	2898	2705	2287	2287
   query73	835	771	430	430
   query74	5089	4899	4735	4735
   query75	2668	2592	2270	2270
   query76	2273	1131	762	762
   query77	397	425	342	342
   query78	12075	12076	11500	11500
   query79	1455	1013	712	712
   query80	1109	548	458	458
   query81	500	281	240	240
   query82	1344	157	122	122
   query83	353	269	255	255
   query84	265	143	113	113
   query85	940	540	468	468
   query86	421	345	326	326
   query87	3389	3377	3204	3204
   query88	3557	2694	2689	2689
   query89	442	389	335	335
   query90	1809	177	175	175
   query91	180	170	138	138
   query92	78	80	73	73
   query93	1441	1543	864	864
   query94	628	327	322	322
   query95	727	373	350	350
   query96	1049	783	327	327
   query97	2713	2711	2596	2596
   query98	233	232	232	232
   query99	1111	1080	977	977
   Total cold run time: 253335 ms
   Total hot run time: 168755 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4466911280

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4466911055

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4474409516

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31439 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 8e9addd3fc6b4039b58115fc8932f535d7005b81, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17645	3895	4052	3895
   q2	q3	10766	1402	807	807
   q4	4698	480	341	341
   q5	7578	2261	2140	2140
   q6	237	180	141	141
   q7	965	777	633	633
   q8	9364	1761	1648	1648
   q9	5200	4959	4895	4895
   q10	6395	2107	1806	1806
   q11	438	268	256	256
   q12	631	432	292	292
   q13	18091	3433	2808	2808
   q14	267	257	238	238
   q15	q16	824	775	712	712
   q17	994	987	915	915
   q18	7461	5701	5558	5558
   q19	1193	1278	1014	1014
   q20	647	453	278	278
   q21	5912	2894	2744	2744
   q22	458	374	318	318
   Total cold run time: 99764 ms
   Total hot run time: 31439 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	4985	4774	4644	4644
   q2	q3	4869	5229	4668	4668
   q4	2115	2218	1471	1471
   q5	4916	4696	4638	4638
   q6	226	180	130	130
   q7	1960	1718	1484	1484
   q8	2428	2058	2146	2058
   q9	7777	7408	7299	7299
   q10	4476	4404	4018	4018
   q11	548	377	350	350
   q12	713	725	536	536
   q13	3011	3444	2763	2763
   q14	287	272	249	249
   q15	q16	687	700	618	618
   q17	1275	1233	1247	1233
   q18	7299	6774	6762	6762
   q19	1121	1076	1086	1076
   q20	2251	2240	1940	1940
   q21	5443	4697	4526	4526
   q22	534	468	391	391
   Total cold run time: 56921 ms
   Total hot run time: 50854 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4473430463

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](sc) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4458057384

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4458921901

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31374 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 0ae4067ffa40eadcfa97628b55417e5cbe2442d6, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17668	3920	3836	3836
   q2	q3	10784	1361	804	804
   q4	4681	480	343	343
   q5	7541	2235	2102	2102
   q6	232	175	138	138
   q7	909	790	636	636
   q8	9365	1645	1644	1644
   q9	5128	4916	4908	4908
   q10	6390	2047	1785	1785
   q11	435	268	248	248
   q12	640	421	294	294
   q13	18097	3388	2738	2738
   q14	264	261	237	237
   q15	q16	823	766	711	711
   q17	953	887	845	845
   q18	6840	5736	5643	5643
   q19	1180	1339	1090	1090
   q20	504	415	259	259
   q21	6152	2894	2798	2798
   q22	458	394	315	315
   Total cold run time: 99044 ms
   Total hot run time: 31374 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	4831	4507	4528	4507
   q2	q3	4871	5248	4603	4603
   q4	2197	2209	1401	1401
   q5	4705	4951	4732	4732
   q6	230	184	127	127
   q7	1859	1735	1595	1595
   q8	2436	2104	2031	2031
   q9	7864	7417	7231	7231
   q10	4415	4393	3990	3990
   q11	527	379	353	353
   q12	711	717	515	515
   q13	3058	3424	2844	2844
   q14	286	271	252	252
   q15	q16	683	701	614	614
   q17	1268	1241	1243	1241
   q18	7103	6928	7033	6928
   q19	1142	1089	1108	1089
   q20	2206	2207	1943	1943
   q21	5349	4612	4472	4472
   q22	538	460	405	405
   Total cold run time: 56279 ms
   Total hot run time: 50873 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #63290:
URL: https://github.com/apache/doris/pull/63290#discussion_r3252833122


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimestampTzLiteral.java:
##########
@@ -454,6 +455,14 @@ public static Expression fromJavaDateType(LocalDateTime dateTime, int precision)

Review Comment:
   `ZoneOffset.toString()` returns `Z` for UTC, so when the FE default/session timezone is UTC this produces values like `2026-05-16 12:00:00.000000Z`. The new unit test expects `[+-]HH:MM`, and BE-side TIMESTAMPTZ formatting also emits numeric offsets (`+00:00`), so this is timezone-dependent and will fail in UTC test environments. Please normalize UTC to `+00:00` here, for example by formatting the offset with a formatter or replacing `Z` with `+00:00`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4473470286

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4459373814

   # FE Regression Coverage Report
   Increment line coverage `  16.07% (9/56)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63290_0ae4067ffa40eadcfa97628b55417e5cbe2442d6_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63290_0ae4067ffa40eadcfa97628b55417e5cbe2442d6_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4460296609

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](TIMESTAMPTZ) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4460623434

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 169226 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 54d069a28d09f7ca8635048531a801044ffc97a7, data reload: false
   
   query5	4320	653	504	504
   query6	338	220	199	199
   query7	4260	573	295	295
   query8	322	230	219	219
   query9	8794	3956	3964	3956
   query10	475	353	310	310
   query11	5783	2370	2204	2204
   query12	188	133	135	133
   query13	1291	625	448	448
   query14	5946	5328	5032	5032
   query14_1	4327	4327	4328	4327
   query15	212	206	183	183
   query16	1029	409	421	409
   query17	1154	749	618	618
   query18	2748	490	359	359
   query19	224	213	174	174
   query20	140	138	132	132
   query21	217	146	121	121
   query22	13536	13462	13388	13388
   query23	17106	16339	15981	15981
   query23_1	16094	16153	16139	16139
   query24	7404	1762	1314	1314
   query24_1	1312	1308	1299	1299
   query25	578	502	449	449
   query26	1180	324	174	174
   query27	2694	588	344	344
   query28	4448	1937	1924	1924
   query29	1005	641	522	522
   query30	310	241	202	202
   query31	1111	1064	933	933
   query32	96	76	76	76
   query33	554	366	298	298
   query34	1176	1114	645	645
   query35	766	781	721	721
   query36	1296	1292	1146	1146
   query37	150	106	91	91
   query38	3193	3126	3046	3046
   query39	924	916	892	892
   query39_1	874	875	890	875
   query40	227	147	123	123
   query41	65	63	62	62
   query42	108	108	108	108
   query43	325	323	278	278
   query44	
   query45	211	194	195	194
   query46	1030	1178	709	709
   query47	2318	2310	2238	2238
   query48	402	410	321	321
   query49	634	486	387	387
   query50	1016	353	251	251
   query51	4302	4313	4288	4288
   query52	107	108	96	96
   query53	257	279	210	210
   query54	330	277	252	252
   query55	99	97	85	85
   query56	318	330	312	312
   query57	1450	1446	1342	1342
   query58	302	262	278	262
   query59	1583	1642	1476	1476
   query60	325	328	311	311
   query61	158	160	156	156
   query62	676	633	572	572
   query63	246	204	202	202
   query64	2186	782	613	613
   query65	
   query66	2411	482	358	358
   query67	30044	29957	29824	29824
   query68	
   query69	451	344	340	340
   query70	1011	977	993	977
   query71	312	280	267	267
   query72	2984	2684	2427	2427
   query73	844	801	423	423
   query74	5022	4861	4702	4702
   query75	2655	2589	2250	2250
   query76	2298	1128	783	783
   query77	412	401	328	328
   query78	12073	12071	11590	11590
   query79	1457	1028	742	742
   query80	1310	541	448	448
   query81	523	280	237	237
   query82	1011	161	119	119
   query83	321	279	240	240
   query84	253	142	114	114
   query85	901	554	451	451
   query86	458	369	316	316
   query87	3398	3408	3203	3203
   query88	3485	2643	2604	2604
   query89	444	381	336	336
   query90	1903	173	181	173
   query91	176	166	139	139
   query92	79	79	75	75
   query93	1639	1478	898	898
   query94	715	353	303	303
   query95	704	367	341	341
   query96	1080	785	353	353
   query97	2688	2713	2551	2551
   query98	234	235	230	230
   query99	1136	1104	984	984
   Total cold run time: 253630 ms
   Total hot run time: 169226 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](sc) serialize TIMESTAMPTZ schema change defaults with offset [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #63290:
URL: https://github.com/apache/doris/pull/63290#issuecomment-4457923102

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org