You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2023/01/16 14:04:04 UTC
[GitHub] [maven-compiler-plugin] dependabot[bot] opened a new pull request, #168: Bump mockito-core from 4.8.0 to 5.0.0
dependabot[bot] opened a new pull request, #168:
URL: https://github.com/apache/maven-compiler-plugin/pull/168
Bumps [mockito-core](https://github.com/mockito/mockito) from 4.8.0 to 5.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/mockito/mockito/releases">mockito-core's releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<h1>Mockito 5: prepare for future JDK versions</h1>
<p>For a while now, we have seen an increase in problems/incompatibilities with recent versions of the JDK due to our usage of JVM-internal API.
Most notably, JDK 17 made some changes which are incompatible with the current subclass mockmaker.
Therefore, to prepare for the future of JDK, we are making some core changes to ensure Mockito keeps on working.</p>
<h2>Switch the default mockmaker to <code>mockito-inline</code></h2>
<p>Back in Mockito 2.7.6, we published a new mockmaker based on the "inline bytecode" principle.
This mockmaker creates mocks manipulating bytecode equivalent within the original class such that its method implementations hook into the normal Mockito machinery.
As a comparison, the subclass mockmaker generates "real" subclasses for mocks, to mimic the same behavior.
While the approaches are similar, the inline mockmaker avoids certain restrictions that the JDK imposes.
For example, it does not violate module boundaries (introduced in JDK 9, but more heavily used in JDK 17) and avoids the leaking of the creation of the subclass.</p>
<p>Massive thanks to community member <a href="https://github.com/reta"><code>@reta</code></a> who implemented this change.</p>
<h3>When should I still be using the subclass mockmaker?</h3>
<p>There are legitimate remaining use cases for the subclass mockmaker.
For example, on the Graal VM's native image, the inline mockmaker will not work and the subclass mockmaker is the appropriate choice.
Additionally, if you would like to avoid mocking final classes, using the subclass mockmaker is a possibibility.
Note however that if you solely want to use the subclass mockmaker to avoid mocking final, you will run into the above mentioned issues on JDK 17+.
We want to leave this choice up to our users, which is why we will keep on supporting the subclass mockmaker.</p>
<p>If you want to use the subclass mockmaker instead, you can use the new <code>mockito-subclass</code> artifact (published <a href="https://search.maven.org/artifact/org.mockito/mockito-subclass">on Maven Central</a> along with all our other artifacts).</p>
<h2>Update the minimum supported Java version to 11</h2>
<p>Mockito 4 supports Java 8 and above.
Similar to other open source projects, we are moving away from JDK 8 and to newer versions.
The primary reason for moving away from JDK 8 is the increasing maintenance costs with keeping our own infrastructure working.
Lately we have been running into more and more JDK 8 breakages.
Additionally, while we want to support the newest JDK API's, our current solution to support both JDK 8 and newer versions causes <a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2798">issues with the <code>SecurityManager</code></a>.
Since we want Mockito to work on the newest version and more and more businesses adopting JDK 11, we have decided to make the switch as well.</p>
<p>Massive thanks to community member <a href="https://github.com/reta"><code>@reta</code></a> who implemented this change.</p>
<h3>What should I do if I still run JDK 8?</h3>
<p>For JDK 8 and below, you can keep on using Mockito 4.
This is similar to if you are using JDK 6, for which you can keep on using Mockito 2.
The changes in Mockito 5 (for now) are primarily focused on the latest JDK versions, which means the API differences between Mockito 4 and 5 are minimal.
However, over time this will most likely widen, so we do recommend adopting JDK 11 in the future.</p>
<h2>New <code>type()</code> method on <code>ArgumentMatcher</code></h2>
<p>One of our most used public API's for customizing Mockito is the <a href="https://javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/ArgumentMatcher.html"><code>ArgumentMatcher</code> interface</a>.
The interface allows you to define a custom matcher, which you can pass into method arguments to provide more targeted matches.
One major shortcoming of the <code>ArgumentMatcher</code> was the lack of varargs support.</p>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/mockito/mockito/commit/adf528d173f8b763fcd4fedab245ed485b465211"><code>adf528d</code></a> Bump versions.bytebuddy from 1.12.21 to 1.12.22 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2864">#2864</a>)</li>
<li><a href="https://github.com/mockito/mockito/commit/2418419a1915bd234332eac2b4d5de85622d4699"><code>2418419</code></a> Bump versions.junitJupiter from 5.9.1 to 5.9.2 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2858">#2858</a>)</li>
<li><a href="https://github.com/mockito/mockito/commit/3d40cd51d3982e33f7c2a2670c65d28233ceb66e"><code>3d40cd5</code></a> Bump junit-platform-launcher from 1.9.1 to 1.9.2 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2859">#2859</a>)</li>
<li><a href="https://github.com/mockito/mockito/commit/9bec8e3a1a0f57e4baa9b64825d67641e9eb2d5e"><code>9bec8e3</code></a> Bump versions.errorprone from 2.17.0 to 2.18.0 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2857">#2857</a>)</li>
<li><a href="https://github.com/mockito/mockito/commit/a9595f559cf4acdaed92371537ced982e30f508d"><code>a9595f5</code></a> Switch the default mockmaker to the inline mockmaker on JDK 17+ (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2834">#2834</a>)</li>
<li><a href="https://github.com/mockito/mockito/commit/c5d7fbc532301d003293649b71c8a6f87283638e"><code>c5d7fbc</code></a> Bump assertj-core from 3.23.1 to 3.24.1 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2854">#2854</a>)</li>
<li><a href="https://github.com/mockito/mockito/commit/dbd7f2ff4aae294feb7c9f5506398c1d6e07dfac"><code>dbd7f2f</code></a> Bump versions.bytebuddy from 1.12.20 to 1.12.21 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2852">#2852</a>)</li>
<li><a href="https://github.com/mockito/mockito/commit/4d62fa75c731b63bec2b2e1ed22eadb472afb1a2"><code>4d62fa7</code></a> Bump junit from 1.1.4 to 1.1.5 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2850">#2850</a>)</li>
<li><a href="https://github.com/mockito/mockito/commit/b1b6d6afcbb6159b91c993b2d11f1498e9d25ad6"><code>b1b6d6a</code></a> Bump espresso-core from 3.5.0 to 3.5.1 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2849">#2849</a>)</li>
<li><a href="https://github.com/mockito/mockito/commit/7b5b8dd8408173ce1ee6fd3485a8bd5d5aae9ed7"><code>7b5b8dd</code></a> Remove use case for non-existent method VerificationWithTimeout#never (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2848">#2848</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/mockito/mockito/compare/v4.8.0...v5.0.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] slawekjaranowski commented on pull request #168: Bump mockito-core to 5.0.0 for Java11+
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #168:
URL: https://github.com/apache/maven-compiler-plugin/pull/168#issuecomment-1402822601
I'm not sure if it is safe.
What will be when api between 4.x and 5.x sometime become incompatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] dependabot[bot] commented on pull request #168: Bump mockito-core to 5.0.0 for Java11+
Posted by dependabot.
dependabot[bot] commented on PR #168:
URL: https://github.com/apache/maven-compiler-plugin/pull/168#issuecomment-1408682606
A newer version of org.mockito:mockito-core exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] dependabot[bot] commented on pull request #168: Bump mockito-core to 5.0.0 for Java11+
Posted by dependabot.
dependabot[bot] commented on PR #168:
URL: https://github.com/apache/maven-compiler-plugin/pull/168#issuecomment-1408695238
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] slachiewicz closed pull request #168: Bump mockito-core to 5.0.0 for Java11+
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz closed pull request #168: Bump mockito-core to 5.0.0 for Java11+
URL: https://github.com/apache/maven-compiler-plugin/pull/168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] slachiewicz commented on pull request #168: Bump mockito-core to 5.0.0 for Java11+
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #168:
URL: https://github.com/apache/maven-compiler-plugin/pull/168#issuecomment-1402824833
We could report incompatibility, adjust our tests. But sooner or later we could switch to Java 11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org