You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/05/18 18:33:07 UTC

[kudu-CR] tablet: refactor some common CHECKs into ApplyRowOperation()

Hello David Ribeiro Alves, Jean-Daniel Cryans,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3118

to review the following change.

Change subject: tablet: refactor some common CHECKs into ApplyRowOperation()
......................................................................

tablet: refactor some common CHECKs into ApplyRowOperation()

The Insert and Mutate paths had more or less the same set of precondition
CHECKs. These methods are not called from anywhere except for
ApplyRowOperation(), so this just moves the checks.

Change-Id: I5564296bacc97f224fed6d21f0c073e88fc1fbaa
---
M src/kudu/tablet/tablet.cc
1 file changed, 6 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/3118/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3118
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5564296bacc97f224fed6d21f0c073e88fc1fbaa
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans